Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   =?iso-2022-jp?B?SEFHSU8gS0FaVUhJVE8oGyRCR2tIeCEhMGw/ThsoQik=?= 
        <k-hagio-ab@nec.com>
To:     Baoquan He <bhe@redhat.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
CC:     "lijiang@redhat.com" <lijiang@redhat.com>,
        "kexec@lists.infradead.org" <kexec@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "ktkhai@virtuozzo.com" <ktkhai@virtuozzo.com>,
        "ebiederm@xmission.com" <ebiederm@xmission.com>,
        "akpm@linux-foundation.org" <akpm@linux-foundation.org>,
        "dyoung@redhat.com" <dyoung@redhat.com>,
        "christian.brauner@ubuntu.com" <christian.brauner@ubuntu.com>,
        "vgoyal@redhat.com" <vgoyal@redhat.com>,
        "keescook@chromium.org" <keescook@chromium.org>,
        Alexander Egorenkov <egorenar@linux.ibm.com>
Subject: RE: [PATCH v3 1/1] kdump: append uts_namespace.name offset to
 VMCOREINFO
Thread-Topic: [PATCH v3 1/1] kdump: append uts_namespace.name offset to
 VMCOREINFO
Thread-Index: AQHWlxP9iSN4NUmqe0mVMLoYv/8qc6odr7YAgABrXgA=
Date:   Fri, 8 Jan 2021 10:07:07 +0000
Message-ID: <OSBPR01MB1991DBFA6C4BD6818947EF6BDDAE0@OSBPR01MB1991.jpnprd01.prod.outlook.com>
References: <20200930102328.396488-1-egorenar@linux.ibm.com>
 <20210108033248.GA4959@MiWiFi-R3L-srv>
In-Reply-To: <20210108033248.GA4959@MiWiFi-R3L-srv>
Accept-Language: ja-JP, en-US
Content-Language: ja-JP
Content-Type: text/plain; charset="iso-2022-jp"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: dcbcb92e-4fbc-433a-d390-08d8b3bd2808
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jan 2021 10:07:07.3933
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: e67df547-9d0d-4f4d-9161-51c6ed1f7d11
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: FWwib+T0ZJiaujAEiU4/QEI67JDPIZEFJm2ao6J3DCFuNEi9CQMNALGy3jO+dfbBrtOXlZXEPad1ld9RG1f+1A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: OSBPR01MB2583
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Baoquan,

-----Original Message-----
> On 09/30/20 at 12:23pm, Alexander Egorenkov wrote:
> > The offset of the field 'init_uts_ns.name' has changed
> > since commit 9a56493f6942 ("uts: Use generic ns_common::count").
>=20
> This patch is merged into 5.11-rc1, but we met the makedumpfile failure
> of kdump test case in 5.10.0 kernel. Should affect 5.9 too since
> commit 9a56493f6942 is merged into 5.9-rc2.

Hmm, commit 9a56493f6942 should have been merged into 5.11-rc1
together with commit ca4a9241cc5e.

Does your makedumpfile have the following patch?
https://github.com/makedumpfile/makedumpfile/commit/54aec3878b3f91341e6bc73=
5eda158cca5c54ec9

or am I missing something?

Thanks,
Kazu

>=20
> Below tag and CC should have been added into patch when posted.
>=20
> Fixes: commit 9a56493f6942 ("uts: Use generic ns_common::count")
> Cc: <stable@vger.kernel.org>
>=20
> Hi Greg,
>=20
> Do we still have chance to make it added into stable?
>=20
> Thanks
> Baoquan
>=20
> >
> > Link: https://lore.kernel.org/r/159644978167.604812.1773586504374412107=
.stgit@localhost.localdomain
> >
> > Make the offset of the field 'uts_namespace.name' available
> > in VMCOREINFO because tools like 'crash-utility' and
> > 'makedumpfile' must be able to read it from crash dumps.
> >
> > Signed-off-by: Alexander Egorenkov <egorenar@linux.ibm.com>
> > ---
> >
> > v2 -> v3:
> >  * Added documentation to vmcoreinfo.rst
> >  * Use the short form of the commit reference
> >
> > v1 -> v2:
> >  * Improved commit message
> >  * Added link to the discussion of the uts namespace changes
> >
> >  Documentation/admin-guide/kdump/vmcoreinfo.rst | 6 ++++++
> >  kernel/crash_core.c                            | 1 +
> >  2 files changed, 7 insertions(+)
> >
> > diff --git a/Documentation/admin-guide/kdump/vmcoreinfo.rst
> b/Documentation/admin-guide/kdump/vmcoreinfo.rst
> > index e44a6c01f336..3861a25faae1 100644
> > --- a/Documentation/admin-guide/kdump/vmcoreinfo.rst
> > +++ b/Documentation/admin-guide/kdump/vmcoreinfo.rst
> > @@ -39,6 +39,12 @@ call.
> >  User-space tools can get the kernel name, host name, kernel release
> >  number, kernel version, architecture name and OS type from it.
> >
> > +(uts_namespace, name)
> > +---------------------
> > +
> > +Offset of the name's member. Crash Utility and Makedumpfile get
> > +the start address of the init_uts_ns.name from this.
> > +
> >  node_online_map
> >  ---------------
> >
> > diff --git a/kernel/crash_core.c b/kernel/crash_core.c
> > index 106e4500fd53..173fdc261882 100644
> > --- a/kernel/crash_core.c
> > +++ b/kernel/crash_core.c
> > @@ -447,6 +447,7 @@ static int __init crash_save_vmcoreinfo_init(void)
> >  	VMCOREINFO_PAGESIZE(PAGE_SIZE);
> >
> >  	VMCOREINFO_SYMBOL(init_uts_ns);
> > +	VMCOREINFO_OFFSET(uts_namespace, name);
> >  	VMCOREINFO_SYMBOL(node_online_map);
> >  #ifdef CONFIG_MMU
> >  	VMCOREINFO_SYMBOL_ARRAY(swapper_pg_dir);
> > --
> > 2.26.2
> >
>=20
>=20
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec