Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp203697pxb; Fri, 8 Jan 2021 02:43:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJzqvTB02jewAX+/9y+R30qiOHjZNZpkLM5Yau1ziy1bfEQDL/gBopzSX3NPUevBZ1fYEv9i X-Received: by 2002:a17:906:720e:: with SMTP id m14mr2194487ejk.161.1610102622933; Fri, 08 Jan 2021 02:43:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610102622; cv=none; d=google.com; s=arc-20160816; b=xB6sqx3OKZG8XeXXmgFQ8+GaBOlj5zBtZgggSxbpyJRjMzvNDieAaWRar1rUn2dl1R dsm6l+pVaoRjvknOLxZ50RYYN54T12YLNlmghH6QOldpJ9n/lolq33hjsBfTbv4sngmy 3q2T4fgWcND1eeFW9v5xR7bllInracP3s/CAJU4uf9WCwDJsyOCVS2I9cGLmCmNuOR2z GwEN3rUGmPzE9UvpBrlEmAy0mypWDdhVYmQ6oq1+/3rn+xxprm15oW6EdIIzjoNj8qeM guZmZl0bYVKTyGxhf38T58VcepJcDYV1OuigWTuJYFVyiRLhtzY6rJHXgogj++8JWWdG 8MsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:to:from; bh=hrOmOpq1kTR+T/G3teG+Bmy5l+gFlLpeaZO/4JvKuPw=; b=eSlq9vLd7uLljURwiZ9lWk1oXoJZ8c3xq9E+0EDlCZdt+L9Kaew9bZj9MIJISXAwhQ IxtGyvIrENOPHQiWhYZN+Saa3rUWPAoUo2klFTF9v9EtN7bYcVd6enjEQMr0tpIUjME5 KiHkldVH5rWY9HR8Hz2AR/Dp87rIoNGMcGn/GG2FDM4ppOzhcmBvrVzYW9e86WAdyIq8 QXz289qY5B1EBD/Shnly1HLlL2As108SDxz+SqHuAbbrfnd5SXiLPd0rzLb65lwBwPLH oR5jwpprGBKOILAClT/L3Iy8bFTvqX+BZHxyIx07Gl9DhteIjtLkdN0W8ohXLuaJRyMd xnnA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 15si3545075ejg.14.2021.01.08.02.43.18; Fri, 08 Jan 2021 02:43:42 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727496AbhAHKly (ORCPT + 99 others); Fri, 8 Jan 2021 05:41:54 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:10422 "EHLO szxga06-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727293AbhAHKly (ORCPT ); Fri, 8 Jan 2021 05:41:54 -0500 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga06-in.huawei.com (SkyGuard) with ESMTP id 4DC04B5Hr5zj46B; Fri, 8 Jan 2021 18:40:26 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.498.0; Fri, 8 Jan 2021 18:41:11 +0800 From: Tian Tao To: , , , , , , , , Subject: [PATCH] drm/hisilicon: Delete the empty function mode_valid Date: Fri, 8 Jan 2021 18:41:05 +0800 Message-ID: <1610102465-36501-1-git-send-email-tiantao6@hisilicon.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.69.192.56] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Based on the drm_connector_mode_valid, if the hibmc implementation of mode_valid only returns MODE_OK, then we can not implement the mode_valid function. Signed-off-by: Tian Tao --- drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c index c76f996..c74a35b 100644 --- a/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c +++ b/drivers/gpu/drm/hisilicon/hibmc/hibmc_drm_vdac.c @@ -43,12 +43,6 @@ static int hibmc_connector_get_modes(struct drm_connector *connector) return count; } -static enum drm_mode_status hibmc_connector_mode_valid(struct drm_connector *connector, - struct drm_display_mode *mode) -{ - return MODE_OK; -} - static void hibmc_connector_destroy(struct drm_connector *connector) { struct hibmc_connector *hibmc_connector = to_hibmc_connector(connector); @@ -60,7 +54,6 @@ static void hibmc_connector_destroy(struct drm_connector *connector) static const struct drm_connector_helper_funcs hibmc_connector_helper_funcs = { .get_modes = hibmc_connector_get_modes, - .mode_valid = hibmc_connector_mode_valid, }; static const struct drm_connector_funcs hibmc_connector_funcs = { -- 2.7.4