Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <5FF83B02.5000000@gmail.com>
Date:   Fri, 08 Jan 2021 12:59:14 +0200
From:   Eli Billauer <eli.billauer@gmail.com>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.12) Gecko/20100907 Fedora/3.0.7-1.fc12 Thunderbird/3.0.7
MIME-Version: 1.0
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     arnd@arndb.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] char: xillybus: Add driver for XillyUSB (Xillybus variant
 for USB)
References: <20201213170503.59017-1-eli.billauer@gmail.com> <X/Rt+bUJ9Hs2F8nF@kroah.com> <5FF5C31C.6050804@gmail.com> <X/XH5Q6APKKt4kRR@kroah.com> <5FF6EDED.40408@gmail.com> <X/bzBobubF1C5x3Q@kroah.com>
In-Reply-To: <X/bzBobubF1C5x3Q@kroah.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk

Hello, Greg.

On 07/01/21 13:39, Greg KH wrote:
> My point is, do NOT have different file names.  Userspace should not
> care about the backing transport layer of a device.
>    
Regarding sound cards and such -- we agree perfectly. For a driver like 
XillyUSB, it's not necessarily clear what is correct formally. Either 
way, for XillyUSB the choice on this matter was practical.

First thing, this is what users expect. Xillybus is an FPGA project, and 
its users are hardware oriented. They've spent time designing the FPGA 
logic, and the connection with the host has been part of the effort. As 
the connection via PCIe or USB is part of the design, they definitely 
see these as different things, and don't expect them to appear to be the 
same.

Also, the application software is virtually always written specially for 
the project. Even if a specific hardware application is designed with 
both connection options possible (USB or PCIe), it will be very much 
desired to distinguish between them. For example, because odds are that 
the PCIe option will allow a much higher bandwidth capacity.

Another thing is that it's quite possible that some users will connect 
an FPGA board to a host through USB and PCIe simultaneously. For 
example, when developing an FPGA to work with the USB variant, but at 
the same time using the PCIe variant for passing debug data. In this 
case, using the same namespace for both variants will cause confusion.

So yes, calling the new XillyUSB device files xillyusb_* instead of 
xillybus_* may appear awkward. But I'm quite sure that no single user 
will ever thank me or anyone else for merging them. Maybe the formality 
is still important enough to do this anyhow...?

Thanks and regards,
    Eli