Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp232788pxb; Fri, 8 Jan 2021 03:36:28 -0800 (PST) X-Google-Smtp-Source: ABdhPJzbg7vLlvtDsW3PaEEp9Exa0EC8/LjR3HAz8HkTwHEKZzLWBtrUlOado2PI8kR3eEK2ED92 X-Received: by 2002:a17:907:2506:: with SMTP id y6mr2364646ejl.53.1610105788678; Fri, 08 Jan 2021 03:36:28 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610105788; cv=none; d=google.com; s=arc-20160816; b=rGaQDf47PtGlO12tGcB0/WDggV4iivdqzEB92ZTAQTmSFSMZeT3T7Ur4lkIN2dWX4J 3KmudX4iHfVMuIk09Yl9jytDxprVGhl6jmN2i2z+8jAJEJ4dMItQxXZemzu4kwv2aBay sUQUawf+Q4xjDDOebqdtOIjG5NmEsu45h+TYpSx44W81u+x3Pku5vrAzk1StzY7LPH8L xVPc6nd9KzO+P3K/Gzo6Lk6DOfDnzmkploa9Peh3g+EVAE8JIkM2hajOhtgaZyBbwy9y s8eXqrTIh1YfMrB6SZbdirDAT6eRwocc4SQq2vGoj7cxS57sanF8O35MyPt0yFYQiqIl LmIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:dkim-signature:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:references:cc:to:from:subject; bh=E2T06x4spWYNF2pWJ3DV1KaBnD+2MtnlPvmF7IoJDAA=; b=n6zSXQAxqssvV2/Ug2dQ/OvwTzQOQg5i0SXh2FKzK8vTttmb1PWe9DPfHyHvW2VuL5 DUAIwBoFIBqKKmNNeMNpV9tTIWv6n/E540ixtTBcKfjicb5QQTaxwFwc2d8U/7UiTx2L pOFtrOPJfEa1HBHbUV8p7PA011MFwgiF+RtC7PwaIfjgfLwB2g9tT5h6QWoscllY3RqJ w5nk+32v/8WmVHSk/2iRCXHN+WxTK2xQOxEzP3esZefgypzZkVfAN6p3wqWI7jBSm/GP TR6t90dW+5hkkEAm8Zl1UOkfF/HJa0ntqO4l+n07Y5vymFY5AkYQ/huwRlZGlE15ecOZ qpmQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=HNx7oyBT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a12si3626936edk.285.2021.01.08.03.36.05; Fri, 08 Jan 2021 03:36:28 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=HNx7oyBT; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727090AbhAHLeY (ORCPT + 99 others); Fri, 8 Jan 2021 06:34:24 -0500 Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:16493 "EHLO hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725817AbhAHLeT (ORCPT ); Fri, 8 Jan 2021 06:34:19 -0500 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Fri, 08 Jan 2021 03:33:38 -0800 Received: from [10.26.72.150] (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 8 Jan 2021 11:33:33 +0000 Subject: Re: [PATCH 2/2] ALSA: hda/tegra: fix tegra-hda on tegra30 soc From: Jon Hunter To: Sameer Pujar , Peter Geis CC: Michael Turquette , Stephen Boyd , Peter De Schrijver , "Prashant Gaikwad" , Thierry Reding , Jaroslav Kysela , Takashi Iwai , Mohan Kumar , , , , , Ion Agorria References: <20201225012025.507803-1-pgwipeout@gmail.com> <20201225012025.507803-3-pgwipeout@gmail.com> <0c3665b2-bac6-546a-bdd4-0ab7a90adf7c@nvidia.com>

Message-ID: <18f44f67-ba81-98d6-67d9-c6ddbb3c9302@nvidia.com> Date: Fri, 8 Jan 2021 11:33:31 +0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL105.nvidia.com (172.20.187.12) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1610105618; bh=E2T06x4spWYNF2pWJ3DV1KaBnD+2MtnlPvmF7IoJDAA=; h=Subject:From:To:CC:References:Message-ID:Date:User-Agent: MIME-Version:In-Reply-To:Content-Type:Content-Language: Content-Transfer-Encoding:X-Originating-IP:X-ClientProxiedBy; b=HNx7oyBTuCOKaDcKlAYfoNqMi3K8AqdYOh13qQ9jY66wuomGM+ECLZq2pay8AJMQI AndHThEOXUqONBPEAA2+DjPOln6xTxqGn/h6BkIzvzgLxy4MKET6EnPfNU3DOdkuoO /g4sJbjPNAaAbJbD344Ozu0iLSK0w+OFyORjbhhuuKLZU5NMtOly2Y49hjhJGwuUWn eKWVMlM9gl4pOCDMlalNnuOJPTx0PP1CCpwNtaxkTyf1yzXHCLRHqpxue1S35rvyss uzP6eN73+n+Hn5r65yXlv3+uXmM/K5ziyK1g03/DS+lPZuN5CPxObUxcP2lhk55oPj L5VHv/U7u0lYA== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/01/2021 10:54, Jon Hunter wrote: >=20 > On 08/01/2021 08:00, Sameer Pujar wrote: >=20 > ... >=20 >>>>> Signed-off-by: Peter Geis >>>>> Tested-by: Ion Agorria >>>>> --- >>>>> =C2=A0=C2=A0 sound/pci/hda/hda_tegra.c | 3 +-- >>>>> =C2=A0=C2=A0 1 file changed, 1 insertion(+), 2 deletions(-) >>>>> >>>>> diff --git a/sound/pci/hda/hda_tegra.c b/sound/pci/hda/hda_tegra.c >>>>> index 70164d1428d4..f8d61e677a09 100644 >>>>> --- a/sound/pci/hda/hda_tegra.c >>>>> +++ b/sound/pci/hda/hda_tegra.c >>>>> @@ -388,8 +388,7 @@ static int hda_tegra_first_init(struct azx >>>>> *chip, struct platform_device *pdev) >>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * in pow= ers of 2, next available ratio is 16 which can be >>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 * used a= s a limiting factor here. >>>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 */ >>>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (of_device_is_compatible(np,= "nvidia,tegra194-hda")) >>>>> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0 chip->bus.core.sdo_limit =3D 16; >>>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 chip->bus.core.sdo_limit =3D 16= ; >>>> Future Tegra chips address this problem and hence cannot be enforced b= y >>>> default. May be we can have like below: >>>> >>>> if (of_device_is_compatible(np, "nvidia,tegra30-hda")) >>>> chip->bus.core.sdo_limit =3D 16; >>>> >>> It will need to be a bit more complicated than that, since the >>> tegra186 and tegra210 device trees have "nvidia,tegra30-hda" as a >>> fallback. >>> Looking at the generation map, tegra30-hda can be the fallback for the >>> broken implementation and tegra210-hda can be the fallback for the >>> working implementation. >>> Does that work for you? >> >> As per above explanation, it is fine to apply the workaround for >> Tegra210/186 as well. So it simplifies things for all existing chips. >=20 >=20 > FYI ... we now have minimal support for Tegra234 in upstream that should > not require this. Given that the Tegra234 device-tree does not include > support for HDA yet, I think it is fine to apply this as-is. However, > once we do add support for Tegra234 HDA, then we should ensure that this > is not applied. So that said ... >=20 > Reviewed-by: Jon Hunter Sorry I was chatting with Sameer offline and we think if we just switch the test to the following then this will take care of Tegra234 when we add it ... if (of_device_is_compatible(np, "nvidia,tegra30-hda")) Peter, would you be able to send a V2 with this? Thanks! Jon --=20 nvpublic