Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp320365pxb; Fri, 8 Jan 2021 06:02:37 -0800 (PST) X-Google-Smtp-Source: ABdhPJz+28FbbvoAdSCoWG0gf+0uyQ3ugghGdBJL1GWNqbt1lc2OFfk8BkBuYs5qFNpZSKqaQveT X-Received: by 2002:a17:906:1197:: with SMTP id n23mr2735530eja.359.1610114556884; Fri, 08 Jan 2021 06:02:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610114556; cv=none; d=google.com; s=arc-20160816; b=A9eXj9R0rtNMIlET6GNcsUXmUJukmaWlFLwbkbq06QWp744WdFL9fnz8zpm0GB0OB6 4BVuvVG6X72uvkgp92cpv7CjZtsDLjsK7BghVq0ZfiGcJrJhSZLJuh8dtkQ+YECCsw1Q JQdPSLAWZv/F/ah+Z9hPI9IJIciQzYy9NSXkgwdFBNagjmpJUNPx8Z8SfflTXmSyd7eJ 82fi5N7Qc5pKOL426J5vy/6/2MVUHRUaq0jme6A3xkKKUJKNuEHnd0wpjw492YSA1Rc3 6a7pRmU+cxQFaYI+BePjW5l5kHhlFgQZS9yD97oZv+Dv6ccFQ/wTYAYNVQUOQ5vFu9lz zKGQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=nyp1Y2onEbcYwJTPNCdZdClbb6AQgC+DkZVAjw0ozR8=; b=QFseiNED7S/jE7y/cX9fdN/YdZ8KXf3FazDK5G8hPzQAQGXcG/rnR8oucYOSOd5PhI yip2FsKT7GQK9Cpf8oSU3mAnGd2Fnjj85x2sbPsrR1BimQ32Z+bGYgez6x7Hgg7dwWui BeJQpDWyCYz0tsqRYyaf131N6KH4gStL/hLGcCyWMAr1biZVx6//0p5B60nycOOcgCCz QqJKB0wuvTL+/A5+t1EoJ8hIg5avxoDVzRlUVDC3RvMBOGM28Vs2p5gKIimCgjuPkJcj HgJnAjiN7OZ5DFUryxaXt3X29QS+69wDgPNw9FsBbjHwxbBldKqbLSdgIhS3eTIbJAh7 TvQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=LXeMOQn4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id de28si3521685edb.166.2021.01.08.06.02.09; Fri, 08 Jan 2021 06:02:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=LXeMOQn4; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726862AbhAHOAN (ORCPT + 99 others); Fri, 8 Jan 2021 09:00:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50240 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725793AbhAHOAM (ORCPT ); Fri, 8 Jan 2021 09:00:12 -0500 Received: from mail-io1-xd2c.google.com (mail-io1-xd2c.google.com [IPv6:2607:f8b0:4864:20::d2c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 02F3AC0612F4; Fri, 8 Jan 2021 05:59:32 -0800 (PST) Received: by mail-io1-xd2c.google.com with SMTP id i18so9866166ioa.1; Fri, 08 Jan 2021 05:59:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=nyp1Y2onEbcYwJTPNCdZdClbb6AQgC+DkZVAjw0ozR8=; b=LXeMOQn4g3/tfRh8x7CMKYz8CPTI1+pP7Llcf5XajSz8CM2P25BkqFKLzEDSkbA0zg F1xAys9s6bb0NieajV86osEicFx5J4wlI2pyMeCcXL59rz3qxzETm1ICIPpa/OS04Tvy vxff9M/U2V4E1qQlKWysLYEXk4c31AuwqI0I1yLfAK/KjSbKsEK7L22iODrxXGNLkcKL fy9nARZQBZyNUnicJ7YGKFBerNvjNaVYMYCZjVG0/xjFcutSnvZsuCD05yaE9+I/y6bh 9S7ojgF+VzIrg2x4aaAgdq1/uzZV8lO4st6BHZEV4eaZjrwJRbbe1TJx751WervSroEF T5/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=nyp1Y2onEbcYwJTPNCdZdClbb6AQgC+DkZVAjw0ozR8=; b=fZvi968KWSXXC5Qwc9J8cdOtU4XEhuFsx0RoiCLP2ZdfzbwbLEoD/lTtd+d2Edd7jC jo69iKClLol4ThQCSpgod17+5nB4XCTwcvu3dWUgDfyhRW1/qQ+7U/JbEqlDNfPkT6dP EXMRxlcsKxKaB84LZrRNhThp8/sbZT9ANsQZ6n4X5BobSBLXAgEr90zg2BJtcqGHLwQQ fmaP2bnDdxtMim3S0Enz10YSlrnLREmXBBYo/izREx8GN75+RUMo5MMsj0CWWrwuu6lx 4UJK1EA0wd8IXS9yGSEstuWAOM5AL5r+tzqMHa0S4dKiO2pjPsNkO0jdGUlYYM6dJaGR X4FQ== X-Gm-Message-State: AOAM532GUpsdRyTSw524Uvt+PTLLJ5mWeJP9h4Pz8Hr2IsOXp06fBR/3 rnEjdiQ9+oygQHuesf3p8XvanzdpZTZYCpvQ X-Received: by 2002:a05:6602:2c4e:: with SMTP id x14mr5390290iov.58.1610114371325; Fri, 08 Jan 2021 05:59:31 -0800 (PST) Received: from rockpro64.hsd1.md.comcast.net ([2601:153:900:7730::20]) by smtp.gmail.com with ESMTPSA id l6sm7570063ili.78.2021.01.08.05.59.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Jan 2021 05:59:30 -0800 (PST) From: Peter Geis To: Michael Turquette , Stephen Boyd , Peter De Schrijver , Prashant Gaikwad , Thierry Reding , Jonathan Hunter , Jaroslav Kysela , Takashi Iwai , Sameer Pujar , Mohan Kumar Cc: linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Peter Geis Subject: [PATCH v2 0/2] fix tegra-hda on tegra30 devices Date: Fri, 8 Jan 2021 13:59:11 +0000 Message-Id: <20210108135913.2421585-1-pgwipeout@gmail.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The following patches fix tegra-hda on legacy tegra devices. Two issues were discovered preventing tegra-hda from functioning: -The hda clocks on tegra30 were assigned to clk_m and running at too low of a rate to function. -The tegra-hda encounters an input/output error when opening a stream. Since the only mainline device that used tegra-hda until recently was the t124, it is unknown exactly when this was broken. Fortunately a recent patch was submitted that fixed the issue only on t194 devices. We can apply it to the tegra30-hda device to resolve the issue across the board. Note that downstream devices used the spdif device instead of hda for hdmi audio. The spdif device lacks a driver on mainline. -Checkpatch seems to have issues finding [1], but git show has no issue. [1] commit 60019d8c650d ("ALSA: hda/tegra: workaround playback failure on Tegra194") Changelog: v2: -Added ack and reviewed-by from Jon -Updated fix to apply to tegra30-hda vice universally (Thanks Jon) -Updated commit to include comments from hardware team (Thanks Sameer) -Cleaned up commit messages Peter Geis (2): clk: tegra30: Add hda clock default rates to clock driver ALSA: hda/tegra: fix tegra-hda on tegra30 soc drivers/clk/tegra/clk-tegra30.c | 2 ++ sound/pci/hda/hda_tegra.c | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) -- 2.25.1