Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210108152447.116871-1-f.suligoi@asem.it>
In-Reply-To: <20210108152447.116871-1-f.suligoi@asem.it>
From:   Andy Shevchenko <andy.shevchenko@gmail.com>
Date:   Fri, 8 Jan 2021 18:02:58 +0200
Message-ID: <CAHp75Vf54TTXr4HH6TxMo0QRTBa5V3=La1LCDxSizaYZjJM9Qg@mail.gmail.com>
Subject: Re: [PATCH v1] Documentation: ACPI: add new rule for gpio-line-names
To:     Flavio Suligoi <f.suligoi@asem.it>
Cc:     Mika Westerberg <mika.westerberg@linux.intel.com>,
        Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
        "Rafael J . Wysocki" <rjw@rjwysocki.net>,
        Len Brown <lenb@kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
        ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, Jan 8, 2021 at 5:28 PM Flavio Suligoi <f.suligoi@asem.it> wrote:
>
> The gpio-line-names lists must respect some rules.
>
> This patch adds a new rule in documentation, to avoid
> the use of duplicate names in the same gpiochip.

Thanks!
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>

> Signed-off-by: Flavio Suligoi <f.suligoi@asem.it>
> ---
>  Documentation/firmware-guide/acpi/gpio-properties.rst | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/Documentation/firmware-guide/acpi/gpio-properties.rst b/Documentation/firmware-guide/acpi/gpio-properties.rst
> index b36aa3e743d8..4e264c16ddff 100644
> --- a/Documentation/firmware-guide/acpi/gpio-properties.rst
> +++ b/Documentation/firmware-guide/acpi/gpio-properties.rst
> @@ -146,6 +146,7 @@ following rules (see also the examples):
>      other words, it is not mandatory to fill all the GPIO lines
>    - empty names are allowed (two quotation marks ``""`` correspond to an empty
>      name)
> +  - names inside one GPIO controller/expander must be unique
>
>  Example of a GPIO controller of 16 lines, with an incomplete list with two
>  empty names::
> --
> 2.25.1
>


-- 
With Best Regards,
Andy Shevchenko