Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210108201457.3078600-1-lee.jones@linaro.org> <20210108201457.3078600-11-lee.jones@linaro.org>
In-Reply-To: <20210108201457.3078600-11-lee.jones@linaro.org>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Fri, 8 Jan 2021 15:35:34 -0500
Message-ID: <CADnq5_NHXUy4s962i2bNTJFjOahGLakuS29vxziKApPkMOo1Uw@mail.gmail.com>
Subject: Re: [PATCH 10/40] drm/amd/pm/powerplay/hwmgr/smu7_hwmgr: Fix
 formatting and spelling issues
To:     Lee Jones <lee.jones@linaro.org>
Cc:     David Airlie <airlied@linux.ie>,
        LKML <linux-kernel@vger.kernel.org>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        Alex Deucher <alexander.deucher@amd.com>,
        Evan Quan <evan.quan@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Jan 8, 2021 at 3:15 PM Lee Jones <lee.jones@linaro.org> wrote:
>
> Fixes the following W=3D1 kernel build warning(s):
>
>  drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/smu7_hwmgr.c:242: warni=
ng: Function parameter or member 'hwmgr' not described in 'smu7_enable_smc_=
voltage_controller'
>  drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/smu7_hwmgr.c:4508: warn=
ing: Function parameter or member 'us_max_fan_rpm' not described in 'smu7_s=
et_max_fan_rpm_output'
>  drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/smu7_hwmgr.c:4508: warn=
ing: Excess function parameter 'usMaxFanRpm' description in 'smu7_set_max_f=
an_rpm_output'
>
> Cc: Evan Quan <evan.quan@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian K=C3=B6nig" <christian.koenig@amd.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Applied.  Thanks!

Alex


> ---
>  drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c b/driver=
s/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c
> index 82676c086ce46..c57dc9ae81f2f 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/smu7_hwmgr.c
> @@ -235,7 +235,7 @@ static int smu7_get_current_pcie_lane_number(struct p=
p_hwmgr *hwmgr)
>  /**
>   * smu7_enable_smc_voltage_controller - Enable voltage control
>   *
> - * @hwmgr  the address of the powerplay hardware manager.
> + * @hwmgr:  the address of the powerplay hardware manager.
>   * Return:   always PP_Result_OK
>   */
>  static int smu7_enable_smc_voltage_controller(struct pp_hwmgr *hwmgr)
> @@ -4501,7 +4501,7 @@ static int smu7_display_configuration_changed_task(=
struct pp_hwmgr *hwmgr)
>   * smu7_set_max_fan_rpm_output - Set maximum target operating fan output=
 RPM
>   *
>   * @hwmgr:  the address of the powerplay hardware manager.
> - * @usMaxFanRpm:  max operating fan RPM value.
> + * @us_max_fan_rpm:  max operating fan RPM value.
>   * Return:   The response that came from the SMC.
>   */
>  static int smu7_set_max_fan_rpm_output(struct pp_hwmgr *hwmgr, uint16_t =
us_max_fan_rpm)
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel