Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp591333pxb; Fri, 8 Jan 2021 12:42:34 -0800 (PST) X-Google-Smtp-Source: ABdhPJxmmgQglmG0cZzMa5TXMw6s0DiviRZ0hB5up/y0WWODvEEwJz6FD6Lr4m8rsCg893Y86+em X-Received: by 2002:a17:906:8301:: with SMTP id j1mr3763118ejx.397.1610138554488; Fri, 08 Jan 2021 12:42:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610138554; cv=none; d=google.com; s=arc-20160816; b=VAJ6XupfqxIqorl7jzxF9LKL+0AtHXHz7mm+ihdlXU+2wBlnxFPobhJmoS4QF+4gKB RlTI9Ih3MzO9CBkvIQzSNRgfiUPp4MSX1AD/DxXD7A4xumBjO5JAyBzFMLSnEcJn1S0i wMEYHLylu2fyMl1nEQVc9ca3x08+L8AcBtAKwfov5N/SXtGG0b+HdICzWwdfmub+Y3em bF0SxeSTfEoKCOF9KCvGJDx+6pJviRKmzqf+BtDiPOS70Y4HtOI71nhaJH8rmSr93Z2U Zn3hzv2AIcjbptphTnBuHpqorXgeJmTLAdRl2kMlC1OeNPpJ6YomOxwOmg374XWb1RFi EbMA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:cc:to:subject :message-id:date:from:in-reply-to:references:mime-version :dkim-signature; bh=7USUfBSYNoXr//1ygkSq10RDo/1Zyym1BvRpYGLGfmo=; b=b6sX16PvC3+S4Pua1EjhG+TCUDm0kWW2SonWaJ1/RTmJAQnVJQ6SOVbH4Xwl5B4RhR GtPW5jDPb/xtVsDSM/cW7YI0fnt5wsqWv9wQErOfQKfQv1TcveqoU3yUKuoz51phi5QN vj/4PW0DbNHSMAiFYDpDouFbdSCqxWQZhzayTRz57huqPODvunIW9UR3+uFw/bIeIej9 fwDTnEtkyG9NLukZ5A4FL1agFMQ0FThwbTCkNqz4PBy36xUlYTIuBxkQC+/EIYsVpmbX duthLdieL0+/mIhreWHuqQLRwj99p7HktNCo+2Aax9WbRNMmcLbywZnzGDpbD/EcCroK u0HQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="hL+zB/53"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 7si3875585edw.324.2021.01.08.12.42.09; Fri, 08 Jan 2021 12:42:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="hL+zB/53"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729634AbhAHUlP (ORCPT + 99 others); Fri, 8 Jan 2021 15:41:15 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729612AbhAHUlM (ORCPT ); Fri, 8 Jan 2021 15:41:12 -0500 Received: from mail-ot1-x32f.google.com (mail-ot1-x32f.google.com [IPv6:2607:f8b0:4864:20::32f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F3DAC061380 for ; Fri, 8 Jan 2021 12:40:32 -0800 (PST) Received: by mail-ot1-x32f.google.com with SMTP id n42so10916487ota.12 for ; Fri, 08 Jan 2021 12:40:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=7USUfBSYNoXr//1ygkSq10RDo/1Zyym1BvRpYGLGfmo=; b=hL+zB/53a3D7/Dz2T4csFfGInwbU0EN94DemgSD+CYJUk4LwRrIxAUDKhrABpKUbGY m73J7++gpKyfHAsEbvUyYwh28HajKGoSgwjGFfO+jenIvmQU4x1ayaAzkKYRVFBklZDs bHGS3vYQoxgGVnnfDOz1kLPjV7R65V1dl/uqTG0zVuCid7sIRuZ0JZYb81dDFdUOYq1a n60oBvCd01ZadjpahratJ8mtq/hpKYMOcSk15QARypFtOdnfwHVVZSzxRBmykP0JcLx6 UnCWIrRbQv0RZn8dNYvDgefi7gBdbAsn9QL1jNQiiX1CSnOvktcmUUipb2cmh9puhJml Zsfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=7USUfBSYNoXr//1ygkSq10RDo/1Zyym1BvRpYGLGfmo=; b=XVDA2OY924269O7jpYZX2dUr2khO72TbK/aUtCypEmsgfAMzcISk5AH7B1FnGiOBSW c1Rh9PW84qWT5sfD9c1LPp/k4mm4Ga3/547Mxjyr0uJs5J2SqYD+vJPlpPgK2By66XGA ls1YuU+UARtDLfhoqefivXBwUAclBmJJLNpTtQuLJUSg5Ei3Ox+UiWZ4pSI+lB+9uW/F KWpCYyI33YRykJTNFQyr1USv2BfOI1o6zFdwsudu4xacp6LKG0XrzSwZqvy7p0lfrora 3giXO7rPFeeWou47F/PdwQVowh5xwDhYHjF0wh6Ye6gwFfehLjxzSc/losSkC11Kgk9Y fJEQ== X-Gm-Message-State: AOAM531TaDQ5JbG097TXo/M9v8SjBWokLpYzzwBDRsuv9XYSp+treoEV PuvSMhJZcq/m8y2+4pETLSFEugt21Tzhp30FbcU= X-Received: by 2002:a05:6830:1b7b:: with SMTP id d27mr3997488ote.132.1610138430197; Fri, 08 Jan 2021 12:40:30 -0800 (PST) MIME-Version: 1.0 References: <20210108201457.3078600-1-lee.jones@linaro.org> <20210108201457.3078600-17-lee.jones@linaro.org> In-Reply-To: <20210108201457.3078600-17-lee.jones@linaro.org> From: Alex Deucher Date: Fri, 8 Jan 2021 15:40:18 -0500 Message-ID: Subject: Re: [PATCH 16/40] drm/amd/display/dc/bios/command_table_helper2: Fix legacy formatting problems To: Lee Jones Cc: Leo Li , LKML , amd-gfx list , David Airlie , Maling list - DRI developers , Alex Deucher , =?UTF-8?Q?Christian_K=C3=B6nig?= Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Applied. Thanks! Alex On Fri, Jan 8, 2021 at 3:15 PM Lee Jones wrote: > > Fixes the following W=3D1 kernel build warning(s): > > drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table_helper2.c:14= 5: warning: Function parameter or member 't' not described in 'dal_cmd_tabl= e_helper_transmitter_bp_to_atom2' > > Cc: Harry Wentland > Cc: Leo Li > Cc: Alex Deucher > Cc: "Christian K=C3=B6nig" > Cc: David Airlie > Cc: Daniel Vetter > Cc: amd-gfx@lists.freedesktop.org > Cc: dri-devel@lists.freedesktop.org > Signed-off-by: Lee Jones > --- > .../display/dc/bios/command_table_helper2.c | 20 ++++++++----------- > 1 file changed, 8 insertions(+), 12 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/bios/command_table_helper2.c = b/drivers/gpu/drm/amd/display/dc/bios/command_table_helper2.c > index 7736c92d55c40..455ee2be15a36 100644 > --- a/drivers/gpu/drm/amd/display/dc/bios/command_table_helper2.c > +++ b/drivers/gpu/drm/amd/display/dc/bios/command_table_helper2.c > @@ -128,18 +128,14 @@ bool dal_cmd_table_helper_controller_id_to_atom2( > } > > /** > -* translate_transmitter_bp_to_atom > -* > -* @brief > -* Translate the Transmitter to the corresponding ATOM BIOS value > -* > -* @param > -* input transmitter > -* output digitalTransmitter > -* // =3D00: Digital Transmitter1 ( UNIPHY linkAB ) > -* // =3D01: Digital Transmitter2 ( UNIPHY linkCD ) > -* // =3D02: Digital Transmitter3 ( UNIPHY linkEF ) > -*/ > + * translate_transmitter_bp_to_atom2 - Translate the Transmitter to the > + * corresponding ATOM BIOS value > + * @t: transmitter > + * returns: digitalTransmitter > + * // =3D00: Digital Transmitter1 ( UNIPHY linkAB ) > + * // =3D01: Digital Transmitter2 ( UNIPHY linkCD ) > + * // =3D02: Digital Transmitter3 ( UNIPHY linkEF ) > + */ > uint8_t dal_cmd_table_helper_transmitter_bp_to_atom2( > enum transmitter t) > { > -- > 2.25.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel