Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210108201457.3078600-1-lee.jones@linaro.org> <20210108201457.3078600-20-lee.jones@linaro.org>
In-Reply-To: <20210108201457.3078600-20-lee.jones@linaro.org>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Fri, 8 Jan 2021 16:00:04 -0500
Message-ID: <CADnq5_NVvzzUKMdFwMoEN97AxgkEY=PCHtiKZACiCQHary2KUg@mail.gmail.com>
Subject: Re: [PATCH 19/40] drm/amd/display/dc/bios/command_table: Remove
 unused variable
To:     Lee Jones <lee.jones@linaro.org>
Cc:     Leo Li <sunpeng.li@amd.com>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        LKML <linux-kernel@vger.kernel.org>,
        Qinglang Miao <miaoqinglang@huawei.com>,
        David Airlie <airlied@linux.ie>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Jan 8, 2021 at 3:15 PM Lee Jones <lee.jones@linaro.org> wrote:
>
> None of the surrounding code was removed just in case even a small
> fraction of it was functional.
>
> Fixes the following W=3D1 kernel build warning(s):
>
>  drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c: In functi=
on =E2=80=98adjust_display_pll_v2=E2=80=99:
>  drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c:1459:35: w=
arning: variable =E2=80=98params=E2=80=99 set but not used [-Wunused-but-se=
t-variable]
>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Leo Li <sunpeng.li@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian K=C3=B6nig" <christian.koenig@amd.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Qinglang Miao <miaoqinglang@huawei.com>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>
> ---
>  drivers/gpu/drm/amd/display/dc/bios/command_table.c | 12 +++---------
>  1 file changed, 3 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/bios/command_table.c b/driver=
s/gpu/drm/amd/display/dc/bios/command_table.c
> index 070459e3e4070..dd893a1176979 100644
> --- a/drivers/gpu/drm/amd/display/dc/bios/command_table.c
> +++ b/drivers/gpu/drm/amd/display/dc/bios/command_table.c
> @@ -1456,20 +1456,14 @@ static enum bp_result adjust_display_pll_v2(
>         struct bp_adjust_pixel_clock_parameters *bp_params)
>  {

@Harry Wentland, this function looks like it's missing the call to
EXEC_BIOS_CMD_TABLE().  I just sent a patch to fix that up, although
I'm not sure if this function every gets used on any asics supported
by amdgpu, so maybe we can just drop it.

Alex


>         enum bp_result result =3D BP_RESULT_FAILURE;
> -       ADJUST_DISPLAY_PLL_PS_ALLOCATION params =3D { 0 };
>
>         /* We need to convert from KHz units into 10KHz units and then co=
nvert
>          * output pixel clock back 10KHz-->KHz */
>         uint32_t pixel_clock_10KHz_in =3D bp_params->pixel_clock / 10;
>
> -       params.usPixelClock =3D cpu_to_le16((uint16_t)(pixel_clock_10KHz_=
in));
> -       params.ucTransmitterID =3D
> -                       bp->cmd_helper->encoder_id_to_atom(
> -                                       dal_graphics_object_id_get_encode=
r_id(
> -                                                       bp_params->encode=
r_object_id));
> -       params.ucEncodeMode =3D
> -                       (uint8_t)bp->cmd_helper->encoder_mode_bp_to_atom(
> -                                       bp_params->signal_type, false);
> +       bp->cmd_helper->encoder_id_to_atom(
> +               dal_graphics_object_id_get_encoder_id(bp_params->encoder_=
object_id));
> +       bp->cmd_helper->encoder_mode_bp_to_atom(bp_params->signal_type, f=
alse);
>         return result;
>  }
>
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel