Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210108201457.3078600-1-lee.jones@linaro.org> <20210108201457.3078600-22-lee.jones@linaro.org>
In-Reply-To: <20210108201457.3078600-22-lee.jones@linaro.org>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Fri, 8 Jan 2021 16:07:15 -0500
Message-ID: <CADnq5_MO9YN--+TZsYM6j12LhBO4JjbiNhUQULBZY2YOBGzV3g@mail.gmail.com>
Subject: Re: [PATCH 21/40] drm/amd/display/dc/calcs/dce_calcs: Remove unused
 variables 'v_filter_init_mode' and 'sclk_lvl'
To:     Lee Jones <lee.jones@linaro.org>,
        Harry Wentland <hwentlan@amd.com>,
        "Leo (Sunpeng) Li" <Sunpeng.Li@amd.com>
Cc:     LKML <linux-kernel@vger.kernel.org>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        David Airlie <airlied@linux.ie>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Jan 8, 2021 at 3:15 PM Lee Jones <lee.jones@linaro.org> wrote:
>
> Fixes the following W=3D1 kernel build warning(s):
>
>  drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c: In function =
=E2=80=98calculate_bandwidth=E2=80=99:
>  drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:109:18: warni=
ng: variable =E2=80=98v_filter_init_mode=E2=80=99 set but not used [-Wunuse=
d-but-set-variable]
>  drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c: In function =
=E2=80=98bw_calcs=E2=80=99:
>  drivers/gpu/drm/amd/amdgpu/../display/dc/calcs/dce_calcs.c:3031:21: warn=
ing: variable =E2=80=98sclk_lvl=E2=80=99 set but not used [-Wunused-but-set=
-variable]
>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Leo Li <sunpeng.li@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian K=C3=B6nig" <christian.koenig@amd.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

@Harry Wentland
, @Leo (Sunpeng) Li I think this file is generated from a script or
something.  Wanted to get your take on how to properly integrate a
change like this.

Alex


> ---
>  drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c b/drivers/g=
pu/drm/amd/display/dc/calcs/dce_calcs.c
> index ef41b287cbe23..158d927c03e55 100644
> --- a/drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c
> +++ b/drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c
> @@ -106,7 +106,6 @@ static void calculate_bandwidth(
>         bool lpt_enabled;
>         enum bw_defines sclk_message;
>         enum bw_defines yclk_message;
> -       enum bw_defines v_filter_init_mode[maximum_number_of_surfaces];
>         enum bw_defines tiling_mode[maximum_number_of_surfaces];
>         enum bw_defines surface_type[maximum_number_of_surfaces];
>         enum bw_defines voltage;
> @@ -792,12 +791,8 @@ static void calculate_bandwidth(
>                                 data->v_filter_init[i] =3D bw_add(data->v=
_filter_init[i], bw_int_to_fixed(1));
>                         }
>                         if (data->stereo_mode[i] =3D=3D bw_def_top_bottom=
) {
> -                               v_filter_init_mode[i] =3D bw_def_manual;
>                                 data->v_filter_init[i] =3D bw_min2(data->=
v_filter_init[i], bw_int_to_fixed(4));
>                         }
> -                       else {
> -                               v_filter_init_mode[i] =3D bw_def_auto;
> -                       }
>                         if (data->stereo_mode[i] =3D=3D bw_def_top_bottom=
) {
>                                 data->num_lines_at_frame_start =3D bw_int=
_to_fixed(1);
>                         }
> @@ -3028,7 +3023,7 @@ bool bw_calcs(struct dc_context *ctx,
>                 calcs_output->all_displays_in_sync =3D false;
>
>         if (data->number_of_displays !=3D 0) {
> -               uint8_t yclk_lvl, sclk_lvl;
> +               uint8_t yclk_lvl;
>                 struct bw_fixed high_sclk =3D vbios->high_sclk;
>                 struct bw_fixed mid1_sclk =3D vbios->mid1_sclk;
>                 struct bw_fixed mid2_sclk =3D vbios->mid2_sclk;
> @@ -3049,7 +3044,6 @@ bool bw_calcs(struct dc_context *ctx,
>                 calculate_bandwidth(dceip, vbios, data);
>
>                 yclk_lvl =3D data->y_clk_level;
> -               sclk_lvl =3D data->sclk_level;
>
>                 calcs_output->nbp_state_change_enable =3D
>                         data->nbp_state_change_enable;
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel