Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210108201457.3078600-1-lee.jones@linaro.org> <20210108201457.3078600-25-lee.jones@linaro.org>
In-Reply-To: <20210108201457.3078600-25-lee.jones@linaro.org>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Fri, 8 Jan 2021 16:12:39 -0500
Message-ID: <CADnq5_NMmop3fFb3vy1QS_wEjNCmwkzjn+aTMd0S45GkKpiCpw@mail.gmail.com>
Subject: Re: [PATCH 24/40] drm/amd/display/dc/dce/dce_stream_encoder: Remove
 unused variable 'regval'
To:     Lee Jones <lee.jones@linaro.org>
Cc:     Leo Li <sunpeng.li@amd.com>, LKML <linux-kernel@vger.kernel.org>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        David Airlie <airlied@linux.ie>,
        Eric Bernstein <eric.bernstein@amd.com>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        George Shen <george.shen@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Jan 8, 2021 at 3:15 PM Lee Jones <lee.jones@linaro.org> wrote:
>
> Fixes the following W=3D1 kernel build warning(s):
>
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_stream_encoder.c: In fu=
nction =E2=80=98dce110_update_generic_info_packet=E2=80=99:
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_stream_encoder.c:70:11:=
 warning: variable =E2=80=98regval=E2=80=99 set but not used [-Wunused-but-=
set-variable]
>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Leo Li <sunpeng.li@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian K=C3=B6nig" <christian.koenig@amd.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: George Shen <george.shen@amd.com>
> Cc: Eric Bernstein <eric.bernstein@amd.com>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Applied.  Thanks!

Alex

> ---
>  drivers/gpu/drm/amd/display/dc/dce/dce_stream_encoder.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_stream_encoder.c b/dr=
ivers/gpu/drm/amd/display/dc/dce/dce_stream_encoder.c
> index ada57f745fd76..265eaef30a519 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dce_stream_encoder.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_stream_encoder.c
> @@ -67,7 +67,6 @@ static void dce110_update_generic_info_packet(
>         uint32_t packet_index,
>         const struct dc_info_packet *info_packet)
>  {
> -       uint32_t regval;
>         /* TODOFPGA Figure out a proper number for max_retries polling fo=
r lock
>          * use 50 for now.
>          */
> @@ -99,7 +98,7 @@ static void dce110_update_generic_info_packet(
>         }
>         /* choose which generic packet to use */
>         {
> -               regval =3D REG_READ(AFMT_VBI_PACKET_CONTROL);
> +               REG_READ(AFMT_VBI_PACKET_CONTROL);
>                 REG_UPDATE(AFMT_VBI_PACKET_CONTROL,
>                                 AFMT_GENERIC_INDEX, packet_index);
>         }
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel