Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210108201457.3078600-1-lee.jones@linaro.org> <20210108201457.3078600-28-lee.jones@linaro.org>
In-Reply-To: <20210108201457.3078600-28-lee.jones@linaro.org>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Fri, 8 Jan 2021 16:15:33 -0500
Message-ID: <CADnq5_P=6PbbOLYE6PiXP1_J9weqZgrKRwGU3Q7ZsRnx7BX2eA@mail.gmail.com>
Subject: Re: [PATCH 27/40] drm/amd/pm/powerplay/hwmgr/vega10_hwmgr: Fix worthy
 function headers, demote barely documented one
To:     Lee Jones <lee.jones@linaro.org>
Cc:     David Airlie <airlied@linux.ie>,
        LKML <linux-kernel@vger.kernel.org>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        Alex Deucher <alexander.deucher@amd.com>,
        Evan Quan <evan.quan@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Jan 8, 2021 at 3:15 PM Lee Jones <lee.jones@linaro.org> wrote:
>
> Fixes the following W=3D1 kernel build warning(s):
>
>  drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1556: wa=
rning: Function parameter or member 'acg_freq' not described in 'vega10_pop=
ulate_single_gfx_level'
>  drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1621: wa=
rning: Function parameter or member 'current_soc_did' not described in 'veg=
a10_populate_single_soc_level'
>  drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1621: wa=
rning: Function parameter or member 'current_vol_index' not described in 'v=
ega10_populate_single_soc_level'
>  drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1621: wa=
rning: Excess function parameter 'current_socclk_level' description in 'veg=
a10_populate_single_soc_level'
>  drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1757: wa=
rning: Function parameter or member 'current_mem_vid' not described in 'veg=
a10_populate_single_memory_level'
>  drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1757: wa=
rning: Function parameter or member 'current_memclk_level' not described in=
 'vega10_populate_single_memory_level'
>  drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:1757: wa=
rning: Function parameter or member 'current_mem_soc_vind' not described in=
 'vega10_populate_single_memory_level'
>  drivers/gpu/drm/amd/amdgpu/../pm/powerplay/hwmgr/vega10_hwmgr.c:2871: wa=
rning: Function parameter or member 'bitmap' not described in 'vega10_start=
_dpm'
>
> Cc: Evan Quan <evan.quan@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian K=C3=B6nig" <christian.koenig@amd.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Applied.  Thanks!

Alex


> ---
>  drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c b/driv=
ers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c
> index da470462d6e2c..29c99642d22d4 100644
> --- a/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c
> +++ b/drivers/gpu/drm/amd/pm/powerplay/hwmgr/vega10_hwmgr.c
> @@ -1549,6 +1549,7 @@ static int vega10_populate_smc_link_levels(struct p=
p_hwmgr *hwmgr)
>   * @hwmgr:      the address of the hardware manager
>   * @gfx_clock:  the GFX clock to use to populate the structure.
>   * @current_gfxclk_level:  location in PPTable for the SMC GFXCLK struct=
ure.
> + * @acg_freq:   ACG frequenty to return (MHz)
>   */
>  static int vega10_populate_single_gfx_level(struct pp_hwmgr *hwmgr,
>                 uint32_t gfx_clock, PllSetting_t *current_gfxclk_level,
> @@ -1612,7 +1613,8 @@ static int vega10_populate_single_gfx_level(struct =
pp_hwmgr *hwmgr,
>   *
>   * @hwmgr:     the address of the hardware manager.
>   * @soc_clock: the SOC clock to use to populate the structure.
> - * @current_socclk_level: location in PPTable for the SMC SOCCLK structu=
re.
> + * @current_soc_did:   DFS divider to pass back to caller
> + * @current_vol_index: index of current VDD to pass back to caller
>   * return:      0 on success
>   */
>  static int vega10_populate_single_soc_level(struct pp_hwmgr *hwmgr,
> @@ -1744,7 +1746,7 @@ static void vega10_populate_vddc_soc_levels(struct =
pp_hwmgr *hwmgr)
>         }
>  }
>
> -/**
> +/*
>   * Populates single SMC GFXCLK structure using the provided clock.
>   *
>   * @hwmgr:     the address of the hardware manager.
> @@ -2863,8 +2865,8 @@ static int vega10_stop_dpm(struct pp_hwmgr *hwmgr, =
uint32_t bitmap)
>  /**
>   * Tell SMC to enabled the supported DPMs.
>   *
> - * @hwmgr:  the address of the powerplay hardware manager.
> - * @bitmap  bitmap for the features to enabled.
> + * @hwmgr:   the address of the powerplay hardware manager.
> + * @bitmap:  bitmap for the features to enabled.
>   * return:  0 on at least one DPM is successfully enabled.
>   */
>  static int vega10_start_dpm(struct pp_hwmgr *hwmgr, uint32_t bitmap)
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel