Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210108201457.3078600-1-lee.jones@linaro.org> <20210108201457.3078600-29-lee.jones@linaro.org>
In-Reply-To: <20210108201457.3078600-29-lee.jones@linaro.org>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Fri, 8 Jan 2021 16:17:01 -0500
Message-ID: <CADnq5_NtvngjE2UUL9MEeBXrb_XJz-3FjAK6D1bcEtOyHbDD7w@mail.gmail.com>
Subject: Re: [PATCH 28/40] drm/amd/display/dc/dce/dce_transform: Remove 3
 unused/legacy variables
To:     Lee Jones <lee.jones@linaro.org>
Cc:     Leo Li <sunpeng.li@amd.com>, Mauro Rossi <issor.oruam@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        David Airlie <airlied@linux.ie>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Jan 8, 2021 at 3:15 PM Lee Jones <lee.jones@linaro.org> wrote:
>
> Fixes the following W=3D1 kernel build warning(s):
>
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_transform.c: In functio=
n =E2=80=98dce60_transform_set_scaler=E2=80=99:
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_transform.c:496:7: warn=
ing: variable =E2=80=98filter_updated=E2=80=99 set but not used [-Wunused-b=
ut-set-variable]
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_transform.c: In functio=
n =E2=80=98dce60_transform_set_pixel_storage_depth=E2=80=99:
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_transform.c:1040:19: wa=
rning: variable =E2=80=98expan_mode=E2=80=99 set but not used [-Wunused-but=
-set-variable]
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_transform.c:1040:6: war=
ning: variable =E2=80=98pixel_depth=E2=80=99 set but not used [-Wunused-but=
-set-variable]
>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Leo Li <sunpeng.li@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian K=C3=B6nig" <christian.koenig@amd.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Mauro Rossi <issor.oruam@gmail.com>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Applied.  Thanks!

Alex

> ---
>  drivers/gpu/drm/amd/display/dc/dce/dce_transform.c | 13 -------------
>  1 file changed, 13 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c b/drivers=
/gpu/drm/amd/display/dc/dce/dce_transform.c
> index 130a0a0c83329..6121bb7b009b8 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_transform.c
> @@ -493,7 +493,6 @@ static void dce60_transform_set_scaler(
>  {
>         struct dce_transform *xfm_dce =3D TO_DCE_TRANSFORM(xfm);
>         bool is_scaling_required;
> -       bool filter_updated =3D false;
>         const uint16_t *coeffs_v, *coeffs_h;
>
>         /*Use whole line buffer memory always*/
> @@ -558,7 +557,6 @@ static void dce60_transform_set_scaler(
>
>                         xfm_dce->filter_v =3D coeffs_v;
>                         xfm_dce->filter_h =3D coeffs_h;
> -                       filter_updated =3D true;
>                 }
>         }
>
> @@ -1037,34 +1035,23 @@ static void dce60_transform_set_pixel_storage_dep=
th(
>         const struct bit_depth_reduction_params *bit_depth_params)
>  {
>         struct dce_transform *xfm_dce =3D TO_DCE_TRANSFORM(xfm);
> -       int pixel_depth, expan_mode;
>         enum dc_color_depth color_depth;
>
>         switch (depth) {
>         case LB_PIXEL_DEPTH_18BPP:
>                 color_depth =3D COLOR_DEPTH_666;
> -               pixel_depth =3D 2;
> -               expan_mode  =3D 1;
>                 break;
>         case LB_PIXEL_DEPTH_24BPP:
>                 color_depth =3D COLOR_DEPTH_888;
> -               pixel_depth =3D 1;
> -               expan_mode  =3D 1;
>                 break;
>         case LB_PIXEL_DEPTH_30BPP:
>                 color_depth =3D COLOR_DEPTH_101010;
> -               pixel_depth =3D 0;
> -               expan_mode  =3D 1;
>                 break;
>         case LB_PIXEL_DEPTH_36BPP:
>                 color_depth =3D COLOR_DEPTH_121212;
> -               pixel_depth =3D 3;
> -               expan_mode  =3D 0;
>                 break;
>         default:
>                 color_depth =3D COLOR_DEPTH_101010;
> -               pixel_depth =3D 0;
> -               expan_mode  =3D 1;
>                 BREAK_TO_DEBUGGER();
>                 break;
>         }
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel