Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210108201457.3078600-1-lee.jones@linaro.org> <20210108201457.3078600-31-lee.jones@linaro.org>
In-Reply-To: <20210108201457.3078600-31-lee.jones@linaro.org>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Fri, 8 Jan 2021 16:18:56 -0500
Message-ID: <CADnq5_PcfiXEc=dpOVM+xttj91tnPsw0UT4T-arzxZhvdusiqw@mail.gmail.com>
Subject: Re: [PATCH 30/40] drm/amd/display/dc/dce/dce_dmcu: Move
 'abm_gain_stepsize' to only source file it's used in
To:     Lee Jones <lee.jones@linaro.org>
Cc:     Leo Li <sunpeng.li@amd.com>, Mauro Rossi <issor.oruam@gmail.com>,
        LKML <linux-kernel@vger.kernel.org>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        David Airlie <airlied@linux.ie>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Jan 8, 2021 at 3:15 PM Lee Jones <lee.jones@linaro.org> wrote:
>
> And only declare it if it's to be used.
>
> Fixes the following W=3D1 kernel build warning(s):
>
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_dmcu.h:320:23: warning:=
 =E2=80=98abm_gain_stepsize=E2=80=99 defined but not used [-Wunused-const-v=
ariable=3D]
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_dmcu.h:320:23: warning:=
 =E2=80=98abm_gain_stepsize=E2=80=99 defined but not used [-Wunused-const-v=
ariable=3D]
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_dmcu.h:320:23: warning:=
 =E2=80=98abm_gain_stepsize=E2=80=99 defined but not used [-Wunused-const-v=
ariable=3D]
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_dmcu.h:320:23: warning:=
 =E2=80=98abm_gain_stepsize=E2=80=99 defined but not used [-Wunused-const-v=
ariable=3D]
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_dmcu.h:320:23: warning:=
 =E2=80=98abm_gain_stepsize=E2=80=99 defined but not used [-Wunused-const-v=
ariable=3D]
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_dmcu.h:320:23: warning:=
 =E2=80=98abm_gain_stepsize=E2=80=99 defined but not used [-Wunused-const-v=
ariable=3D]
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_dmcu.h:320:23: warning:=
 =E2=80=98abm_gain_stepsize=E2=80=99 defined but not used [-Wunused-const-v=
ariable=3D]
>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Leo Li <sunpeng.li@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian K=C3=B6nig" <christian.koenig@amd.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Mauro Rossi <issor.oruam@gmail.com>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Applied.  Thanks!

Alex

> ---
>  drivers/gpu/drm/amd/display/dc/dce/dce_dmcu.c | 4 ++++
>  drivers/gpu/drm/amd/display/dc/dce/dce_dmcu.h | 2 --
>  2 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_dmcu.c b/drivers/gpu/=
drm/amd/display/dc/dce/dce_dmcu.c
> index fa2b47d41ee2f..30264fc151a2b 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dce_dmcu.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_dmcu.c
> @@ -65,6 +65,10 @@
>  //Register access policy version
>  #define mmMP0_SMN_C2PMSG_91                            0x1609B
>
> +#if defined(CONFIG_DRM_AMD_DC_DCN)
> +static const uint32_t abm_gain_stepsize =3D 0x0060;
> +#endif
> +
>  static bool dce_dmcu_init(struct dmcu *dmcu)
>  {
>         // Do nothing
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_dmcu.h b/drivers/gpu/=
drm/amd/display/dc/dce/dce_dmcu.h
> index 93e7f34d4775e..cefb7f5bf42cc 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dce_dmcu.h
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_dmcu.h
> @@ -317,6 +317,4 @@ struct dmcu *dcn21_dmcu_create(
>
>  void dce_dmcu_destroy(struct dmcu **dmcu);
>
> -static const uint32_t abm_gain_stepsize =3D 0x0060;
> -
>  #endif /* _DCE_ABM_H_ */
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel