Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210108201457.3078600-1-lee.jones@linaro.org> <20210108201457.3078600-36-lee.jones@linaro.org>
In-Reply-To: <20210108201457.3078600-36-lee.jones@linaro.org>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Fri, 8 Jan 2021 16:22:42 -0500
Message-ID: <CADnq5_MmsvvxTMTWZn0EPeFn54=JBq3q1UbbPC91VGfbXQTFGQ@mail.gmail.com>
Subject: Re: [PATCH 35/40] drm/amd/display/dc/bios/command_table: Remove
 unused variable and associated comment
To:     Lee Jones <lee.jones@linaro.org>
Cc:     Leo Li <sunpeng.li@amd.com>, LKML <linux-kernel@vger.kernel.org>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        David Airlie <airlied@linux.ie>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Jan 8, 2021 at 3:16 PM Lee Jones <lee.jones@linaro.org> wrote:
>
> Fixes the following W=3D1 kernel build warning(s):
>
>  drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c: In functi=
on =E2=80=98adjust_display_pll_v2=E2=80=99:
>  drivers/gpu/drm/amd/amdgpu/../display/dc/bios/command_table.c:1462:11: w=
arning: unused variable =E2=80=98pixel_clock_10KHz_in=E2=80=99 [-Wunused-va=
riable]
>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Leo Li <sunpeng.li@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian K=C3=B6nig" <christian.koenig@amd.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Lee Jones <lee.jones@linaro.org>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

See my comment on the other patch for this function.

Alex

> ---
>  drivers/gpu/drm/amd/display/dc/bios/command_table.c | 4 ----
>  1 file changed, 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/bios/command_table.c b/driver=
s/gpu/drm/amd/display/dc/bios/command_table.c
> index dd893a1176979..66fe1d1810789 100644
> --- a/drivers/gpu/drm/amd/display/dc/bios/command_table.c
> +++ b/drivers/gpu/drm/amd/display/dc/bios/command_table.c
> @@ -1457,10 +1457,6 @@ static enum bp_result adjust_display_pll_v2(
>  {
>         enum bp_result result =3D BP_RESULT_FAILURE;
>
> -       /* We need to convert from KHz units into 10KHz units and then co=
nvert
> -        * output pixel clock back 10KHz-->KHz */
> -       uint32_t pixel_clock_10KHz_in =3D bp_params->pixel_clock / 10;
> -
>         bp->cmd_helper->encoder_id_to_atom(
>                 dal_graphics_object_id_get_encoder_id(bp_params->encoder_=
object_id));
>         bp->cmd_helper->encoder_mode_bp_to_atom(bp_params->signal_type, f=
alse);
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel