Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210108201457.3078600-1-lee.jones@linaro.org> <20210108201457.3078600-37-lee.jones@linaro.org>
In-Reply-To: <20210108201457.3078600-37-lee.jones@linaro.org>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Fri, 8 Jan 2021 16:23:33 -0500
Message-ID: <CADnq5_PDo2XRMkrhwz52+01r3StpuP7TJHUE=W-8E__kuMtd3A@mail.gmail.com>
Subject: Re: [PATCH 36/40] drm/amd/display/dc/dce/dce_i2c_hw: Make functions
 called by reference static
To:     Lee Jones <lee.jones@linaro.org>
Cc:     Lewis Huang <Lewis.Huang@amd.com>, Leo Li <sunpeng.li@amd.com>,
        LKML <linux-kernel@vger.kernel.org>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        David Airlie <airlied@linux.ie>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Jan 8, 2021 at 3:16 PM Lee Jones <lee.jones@linaro.org> wrote:
>
> Fixes the following W=3D1 kernel build warning(s):
>
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_i2c_hw.c:438:35: warnin=
g: no previous prototype for =E2=80=98dce_i2c_hw_engine_wait_on_operation_r=
esult=E2=80=99 [-Wmissing-prototypes]
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_i2c_hw.c:505:6: warning=
: no previous prototype for =E2=80=98dce_i2c_hw_engine_submit_payload=E2=80=
=99 [-Wmissing-prototypes]
>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Leo Li <sunpeng.li@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian K=C3=B6nig" <christian.koenig@amd.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Lewis Huang <Lewis.Huang@amd.com>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Applied.  Thanks!

Alex

> ---
>  drivers/gpu/drm/amd/display/dc/dce/dce_i2c_hw.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_i2c_hw.c b/drivers/gp=
u/drm/amd/display/dc/dce/dce_i2c_hw.c
> index 7fbd92fbc63a9..a524f471e0d75 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dce_i2c_hw.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_i2c_hw.c
> @@ -435,7 +435,7 @@ struct dce_i2c_hw *acquire_i2c_hw_engine(
>         return dce_i2c_hw;
>  }
>
> -enum i2c_channel_operation_result dce_i2c_hw_engine_wait_on_operation_re=
sult(
> +static enum i2c_channel_operation_result dce_i2c_hw_engine_wait_on_opera=
tion_result(
>         struct dce_i2c_hw *dce_i2c_hw,
>         uint32_t timeout,
>         enum i2c_channel_operation_result expected_result)
> @@ -502,7 +502,7 @@ static uint32_t get_transaction_timeout_hw(
>         return period_timeout * num_of_clock_stretches;
>  }
>
> -bool dce_i2c_hw_engine_submit_payload(
> +static bool dce_i2c_hw_engine_submit_payload(
>         struct dce_i2c_hw *dce_i2c_hw,
>         struct i2c_payload *payload,
>         bool middle_of_transaction,
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel