Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210108201457.3078600-1-lee.jones@linaro.org> <20210108201457.3078600-38-lee.jones@linaro.org>
In-Reply-To: <20210108201457.3078600-38-lee.jones@linaro.org>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Fri, 8 Jan 2021 16:24:38 -0500
Message-ID: <CADnq5_NHZ6V9R3P22vWNBmWtn0Xz840K-r8kxV-1dv=0UPSECQ@mail.gmail.com>
Subject: Re: [PATCH 37/40] drm/amd/display/dc/dce/dce_i2c_sw: Make a bunch of
 local functions static
To:     Lee Jones <lee.jones@linaro.org>
Cc:     Leo Li <sunpeng.li@amd.com>, LKML <linux-kernel@vger.kernel.org>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        David Airlie <airlied@linux.ie>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Jan 8, 2021 at 3:16 PM Lee Jones <lee.jones@linaro.org> wrote:
>
> Fixes the following W=3D1 kernel build warning(s):
>
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_i2c_sw.c:342:6: warning=
: no previous prototype for =E2=80=98dce_i2c_sw_engine_set_speed=E2=80=99 [=
-Wmissing-prototypes]
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_i2c_sw.c:356:6: warning=
: no previous prototype for =E2=80=98dce_i2c_sw_engine_acquire_engine=E2=80=
=99 [-Wmissing-prototypes]
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_i2c_sw.c:400:6: warning=
: no previous prototype for =E2=80=98dce_i2c_sw_engine_submit_channel_reque=
st=E2=80=99 [-Wmissing-prototypes]
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_i2c_sw.c:443:6: warning=
: no previous prototype for =E2=80=98dce_i2c_sw_engine_submit_payload=E2=80=
=99 [-Wmissing-prototypes]
>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Leo Li <sunpeng.li@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian K=C3=B6nig" <christian.koenig@amd.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Applied.  Thanks!

Alex


> ---
>  drivers/gpu/drm/amd/display/dc/dce/dce_i2c_sw.c | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_i2c_sw.c b/drivers/gp=
u/drm/amd/display/dc/dce/dce_i2c_sw.c
> index 87d8428df6c46..6846afd83701b 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dce_i2c_sw.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_i2c_sw.c
> @@ -339,7 +339,7 @@ static bool start_sync_sw(
>         return false;
>  }
>
> -void dce_i2c_sw_engine_set_speed(
> +static void dce_i2c_sw_engine_set_speed(
>         struct dce_i2c_sw *engine,
>         uint32_t speed)
>  {
> @@ -353,7 +353,7 @@ void dce_i2c_sw_engine_set_speed(
>                 engine->clock_delay =3D 12;
>  }
>
> -bool dce_i2c_sw_engine_acquire_engine(
> +static bool dce_i2c_sw_engine_acquire_engine(
>         struct dce_i2c_sw *engine,
>         struct ddc *ddc)
>  {
> @@ -397,7 +397,7 @@ bool dce_i2c_engine_acquire_sw(
>
>
>
> -void dce_i2c_sw_engine_submit_channel_request(
> +static void dce_i2c_sw_engine_submit_channel_request(
>         struct dce_i2c_sw *engine,
>         struct i2c_request_transaction_data *req)
>  {
> @@ -440,7 +440,8 @@ void dce_i2c_sw_engine_submit_channel_request(
>                 I2C_CHANNEL_OPERATION_SUCCEEDED :
>                 I2C_CHANNEL_OPERATION_FAILED;
>  }
> -bool dce_i2c_sw_engine_submit_payload(
> +
> +static bool dce_i2c_sw_engine_submit_payload(
>         struct dce_i2c_sw *engine,
>         struct i2c_payload *payload,
>         bool middle_of_transaction)
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel