Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210108201457.3078600-1-lee.jones@linaro.org> <20210108201457.3078600-39-lee.jones@linaro.org>
In-Reply-To: <20210108201457.3078600-39-lee.jones@linaro.org>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Fri, 8 Jan 2021 16:25:42 -0500
Message-ID: <CADnq5_OMbx2RnpYXhprGUXNQAxwKjB3eEiWgFjwDW3+hurQVsQ@mail.gmail.com>
Subject: Re: [PATCH 38/40] drm/amd/display/dc/dce/dce_panel_cntl: Remove
 unused variables 'bl_pwm_cntl' and 'pwm_period_cntl'
To:     Lee Jones <lee.jones@linaro.org>
Cc:     Leo Li <sunpeng.li@amd.com>, Anthony Koo <Anthony.Koo@amd.com>,
        LKML <linux-kernel@vger.kernel.org>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        David Airlie <airlied@linux.ie>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        Alex Deucher <alexander.deucher@amd.com>,
        =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Fri, Jan 8, 2021 at 3:16 PM Lee Jones <lee.jones@linaro.org> wrote:
>
> Fixes the following W=3D1 kernel build warning(s):
>
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_panel_cntl.c: In functi=
on =E2=80=98dce_get_16_bit_backlight_from_pwm=E2=80=99:
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_panel_cntl.c:54:11: war=
ning: variable =E2=80=98bl_pwm_cntl=E2=80=99 set but not used [-Wunused-but=
-set-variable]
>  drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dce_panel_cntl.c:53:11: war=
ning: variable =E2=80=98pwm_period_cntl=E2=80=99 set but not used [-Wunused=
-but-set-variable]
>
> Cc: Harry Wentland <harry.wentland@amd.com>
> Cc: Leo Li <sunpeng.li@amd.com>
> Cc: Alex Deucher <alexander.deucher@amd.com>
> Cc: "Christian K=C3=B6nig" <christian.koenig@amd.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: Daniel Vetter <daniel@ffwll.ch>
> Cc: Anthony Koo <Anthony.Koo@amd.com>
> Cc: amd-gfx@lists.freedesktop.org
> Cc: dri-devel@lists.freedesktop.org
> Signed-off-by: Lee Jones <lee.jones@linaro.org>

Applied.  Thanks!

Alex

> ---
>  drivers/gpu/drm/amd/display/dc/dce/dce_panel_cntl.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dce_panel_cntl.c b/driver=
s/gpu/drm/amd/display/dc/dce/dce_panel_cntl.c
> index 761fdfc1f5bd0..e923392358631 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dce_panel_cntl.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dce_panel_cntl.c
> @@ -50,16 +50,16 @@ static unsigned int dce_get_16_bit_backlight_from_pwm=
(struct panel_cntl *panel_c
>  {
>         uint64_t current_backlight;
>         uint32_t round_result;
> -       uint32_t pwm_period_cntl, bl_period, bl_int_count;
> -       uint32_t bl_pwm_cntl, bl_pwm, fractional_duty_cycle_en;
> +       uint32_t bl_period, bl_int_count;
> +       uint32_t bl_pwm, fractional_duty_cycle_en;
>         uint32_t bl_period_mask, bl_pwm_mask;
>         struct dce_panel_cntl *dce_panel_cntl =3D TO_DCE_PANEL_CNTL(panel=
_cntl);
>
> -       pwm_period_cntl =3D REG_READ(BL_PWM_PERIOD_CNTL);
> +       REG_READ(BL_PWM_PERIOD_CNTL);
>         REG_GET(BL_PWM_PERIOD_CNTL, BL_PWM_PERIOD, &bl_period);
>         REG_GET(BL_PWM_PERIOD_CNTL, BL_PWM_PERIOD_BITCNT, &bl_int_count);
>
> -       bl_pwm_cntl =3D REG_READ(BL_PWM_CNTL);
> +       REG_READ(BL_PWM_CNTL);
>         REG_GET(BL_PWM_CNTL, BL_ACTIVE_INT_FRAC_CNT, (uint32_t *)(&bl_pwm=
));
>         REG_GET(BL_PWM_CNTL, BL_PWM_FRACTIONAL_EN, &fractional_duty_cycle=
_en);
>
> --
> 2.25.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel