Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Asmaa Mnebhi <asmaa@nvidia.com>
To:     Corey Minyard <minyard@acm.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: ipmi_msghandler.c question
Thread-Topic: ipmi_msghandler.c question
Thread-Index: Adbl4rhW61oYiA8oSfGIt0aDhmZBeg==
Date:   Fri, 8 Jan 2021 23:37:04 +0000
Message-ID: <CH2PR12MB38958D50FDBA94E2127CA993D7AE0@CH2PR12MB3895.namprd12.prod.outlook.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: c5d1d08e-76c8-4a1f-e5e0-08d8b42e4e25
X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jan 2021 23:37:04.4787
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: pLiwBb692tUIzKri1nr2ADrSzh4netwaMHJQBBixgUvEvIQJh334Bo68a8fefVs5rm+cWaxuz6J9/NbXrJ0QnA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4213
X-OriginatorOrg: Nvidia.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1;
        t=1610149026; bh=5B71/ITEBGKHtwczG/L3WwTtEosWgDj9T6EFjjg9mCc=;
        h=ARC-Seal:ARC-Message-Signature:ARC-Authentication-Results:From:To:
         Subject:Thread-Topic:Thread-Index:Date:Message-ID:Accept-Language:
         Content-Language:X-MS-Has-Attach:X-MS-TNEF-Correlator:
         authentication-results:x-originating-ip:x-ms-publictraffictype:
         x-ms-office365-filtering-correlation-id:x-ms-traffictypediagnostic:
         x-microsoft-antispam-prvs:x-ms-oob-tlc-oobclassifiers:
         x-ms-exchange-senderadcheck:x-microsoft-antispam:
         x-microsoft-antispam-message-info:x-forefront-antispam-report:
         x-ms-exchange-antispam-messagedata:x-ms-exchange-transport-forked:
         Content-Type:Content-Transfer-Encoding:MIME-Version:
         X-MS-Exchange-CrossTenant-AuthAs:
         X-MS-Exchange-CrossTenant-AuthSource:
         X-MS-Exchange-CrossTenant-Network-Message-Id:
         X-MS-Exchange-CrossTenant-originalarrivaltime:
         X-MS-Exchange-CrossTenant-fromentityheader:
         X-MS-Exchange-CrossTenant-id:X-MS-Exchange-CrossTenant-mailboxtype:
         X-MS-Exchange-CrossTenant-userprincipalname:
         X-MS-Exchange-Transport-CrossTenantHeadersStamped:X-OriginatorOrg;
        b=puZLCha12Fxi31EUJKVn7TxKCTIclljsxbLbJ8w+HIQaB5CGcovjkz6tKsTKGUZDl
         qxlAh0pL28IawrInGTVq6JKmUk9Vvi4nutf+7hpwkXwNIhijKzBWffd23NjggQ/1l8
         n2w27stfzPmanX64P8ugJbSPvXMJaqX18r23Bx8qT1IQNr73E6LZerR/1oQXdZKjmQ
         +dkOkgR1LVQUM0q5T7mMST7TZ1A/s46qpZwKwi1jgYmtt58SnUATC7VxW2/Nc/SF5R
         3WIts1b/mCiGGRB1ylwZSEt6ztM8mWCiQp757htAV+Xl0PGUr2GvLdXbp5b5wC0IAw
         bARucGxFmESCQ==
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Corey,

I have a question for you related to the following function in ipmi_msghand=
ler.c

static void __get_guid(struct ipmi_smi *intf)
{
	int rv;
	struct bmc_device *bmc =3D intf->bmc;

	bmc->dyn_guid_set =3D 2;
	intf->null_user_handler =3D guid_handler;
	rv =3D send_guid_cmd(intf, 0);
	if (rv)
		/* Send failed, no GUID available. */
		bmc->dyn_guid_set =3D 0;
	else
		wait_event(intf->waitq, bmc->dyn_guid_set !=3D 2);

	/* dyn_guid_set makes the guid data available. */
	smp_rmb();

	intf->null_user_handler =3D NULL;
}

Why is wait_event used as opposed to wait_event_timeout? In the context whe=
re the dyn_guid_set value doesn't change from 2, this would run forever. Wo=
uldn't we want to timeout after a certain amount of time?

Thanks.
Asmaa