Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp709857pxb; Fri, 8 Jan 2021 16:39:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJwnXGFmWTUNN2srTdFn4v3+Odi3KTD1UZ7hR4YjnYeJSLDKbkGMt8KxlwGRBTcoDxCV3xAP X-Received: by 2002:a17:906:1a4e:: with SMTP id j14mr4147660ejf.507.1610152784378; Fri, 08 Jan 2021 16:39:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610152784; cv=none; d=google.com; s=arc-20160816; b=PfGBPLdDUDzF0yunZaDNGjDcaYHTBocOP0cw85xan3BUk/Ec4beFRNS7oLF1IYOL69 tepPKHhjOEEN3sCMSCV3YOWo26MEo/L5e+yHo/p20yRczQ8GsSZw34jwOt3+SNZ7x1TD PLZZERIGTdC1PYOkyWcnnqYT2RHDKZLumH7lQQBcLnoZ5mFsHi7AWlBii3iRqDQpBllO je/IwkLj0ch0FLgaDyHvvo9YJegrsaAnvrPxgTIuC+RfTiA4nWtuvNI/BVse902zkQRm xkPpipxvwDgYIUTlhcDDWsNmihTxi92ydTuN34qK0UiIOp1SfcxBvCZNU61QFYDjs8yt +EiQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=LPpBJ/fMnI8yZebGm9hJTyLbUyow2Z4x72tEei+91U4=; b=SndULI1u31foUDvRbKvD9l3co78lrdBHMCw6Ae6FL//jGal+gUZexgdHf37tZpMWNp EXpLpb0WItFwylN7VEfFOZ4WF8tE5YlOUjSDo/LnmVaYHKC7MhNc0GuOuKpzkGwdz2oh Fc18dWDhqqsrlbTw1Nnp9jbrF4FionYkpR/1ZMa69eiz0pgJWiihqPKERZZ22u7DcXqY xjGCRHc8tif4pmSWLWl2a2B9O1Dgr2FH9h/vKtYaDvC84caeK89KrYbbr8KZuYSLugM5 02dnVN2vOhbJWI3RaMS8uIRDt3NTaAyWGMUWihK1Au+r5xxbMwRjHCL2yRyu+mvWrBcP /t2A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="fwx1XaV/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r18si3803295ejs.411.2021.01.08.16.39.19; Fri, 08 Jan 2021 16:39:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="fwx1XaV/"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726375AbhAIAhU (ORCPT + 99 others); Fri, 8 Jan 2021 19:37:20 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726341AbhAIAhU (ORCPT ); Fri, 8 Jan 2021 19:37:20 -0500 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 95DC5C061757 for ; Fri, 8 Jan 2021 16:36:39 -0800 (PST) Received: by mail-lf1-x131.google.com with SMTP id o17so27177220lfg.4 for ; Fri, 08 Jan 2021 16:36:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LPpBJ/fMnI8yZebGm9hJTyLbUyow2Z4x72tEei+91U4=; b=fwx1XaV/wTLLLznyxTbRB9fBBtCC7ZerKopuVgRnrNv4UjYn9rGgPIok1KWef3q7/9 HhFEOfPfad4MD8CunVXnEMYb02XvnxhA+6scxi0a295u7B67Sjmh43ECuKBphmcj7aLc YkjQGjFOO9GHmf9RWRwsrgh5wfb8Z7obFBZyQJPcd3g4sq5Me9jJ0jz6N74wFyEuTaWS Oh+1J24YFbH2T4t5FlrG0t3MuJ6lzVWZAIof7515hWwxMcA0tmZB2BesKHXAAySLjTWA FZlrQZ6Kc73GO6RNjSsfBMpbhxwiAEFZceLAGnQp1t2fZzRw35oBh/efLpwWtOywgbhJ JMTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LPpBJ/fMnI8yZebGm9hJTyLbUyow2Z4x72tEei+91U4=; b=X4FANqERUtyIf+2FIGuNwhZG+c4PBw/YQby7uEwlp9mkIdxgRO+botFc2y7n0vFvm8 Boiu3TsLRJCQmZSKN2M3sRzfQXUL6lVZcX71X3s9X8IHXwNCQ0su1pBUBprCW92+H3Lj FONvhk+Cx8XGsQCA6KXn48Jpu7+Qwqd9JyeyidMgNpXdpQJLbeaaaFtETzTvamE0pE3T FtdcJQiYIyJw91XIEhyacrJPBqXt33dIl69aga86Nsu7iWVvQR69YuVpe9dWrxGf/fxN K/ynPIlD2luwkNp6k+csiMh7lHRfSnrmsQqdUtIgYHPvYi3C2BDqV4pMLz01q6cqY7tZ tpDg== X-Gm-Message-State: AOAM530OSDb0YXLicznudSwt8aZ1MhltHQ4RhPYOPBZ4uLgoKlBFD/ie jvkKEmLiLvzGzHhwKDG50VHhMz6oMv0TZebHhYMzGw== X-Received: by 2002:a2e:85d1:: with SMTP id h17mr2413376ljj.438.1610152598070; Fri, 08 Jan 2021 16:36:38 -0800 (PST) MIME-Version: 1.0 References: <20210108093339.v5.1.I3ad184e3423d8e479bc3e86f5b393abb1704a1d1@changeid> <20210108093339.v5.4.I7cf3019783720feb57b958c95c2b684940264cd1@changeid> In-Reply-To: <20210108093339.v5.4.I7cf3019783720feb57b958c95c2b684940264cd1@changeid> From: Linus Walleij Date: Sat, 9 Jan 2021 01:36:27 +0100 Message-ID: Subject: Re: [PATCH v5 4/4] pinctrl: qcom: Don't clear pending interrupts when enabling To: Douglas Anderson Cc: Marc Zyngier , Thomas Gleixner , Jason Cooper , Bjorn Andersson , Neeraj Upadhyay , Rajendra Nayak , Stephen Boyd , Maulik Shah , "open list:GPIO SUBSYSTEM" , Srinivas Ramana , MSM , Andy Gross , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Doug, this is an impressive patch. We definitely need to touch base with Bjorn on this, preferably also Sboyd. On Fri, Jan 8, 2021 at 6:35 PM Douglas Anderson wrote: > Fixes: 4b7618fdc7e6 ("pinctrl: qcom: Add irq_enable callback for msm gpio") > Fixes: 71266d9d3936 ("pinctrl: qcom: Move clearing pending IRQ to .irq_request_resources callback") > Signed-off-by: Douglas Anderson Some mechanics: 1. Does this need to go into stable? Or is current (non-urgent) fine? Or fixes for v5.10? I.e. required destination. 2. If it does, should patches 1-3 also go into stable? And are they prerequisites? Yours, Linus Walleij