Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp747678pxb; Fri, 8 Jan 2021 18:03:16 -0800 (PST) X-Google-Smtp-Source: ABdhPJyigUNaZ4UBB0aaem/KPUIlHTgX+zeq3ItmwUVkVyqmD3wDd42914PSnbC2DpYLF0j2LbdP X-Received: by 2002:a17:906:400a:: with SMTP id v10mr4349535ejj.302.1610157796527; Fri, 08 Jan 2021 18:03:16 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610157796; cv=none; d=google.com; s=arc-20160816; b=HA96Wji7/Ob9nJD1ZOGhjnRmX4oYnQTyr4scbTK4/6nQhzYwqYx7sImmMbyku0LRKC 51KwTw7TjxXa/jYXPudQzaETVTRUheWfFu09N4GXacjjY9RJbhTJS9G8TB3UHyIddQB9 TXof465YsHZ0qfmQhRZmdFEK+mxX8ZCVS5ii1Q1l0WluhqoYk+C9VwIeLZfz892gDULC d9MLPsR7Czlc7Av8f9LQ4VNWXhWLBSbOZ72y/OXtfl6UNJ9tRmg3IwwzFxBR5fLsFxAM iHQcOETp8eCXoJg81/sFMsLjNYTRoiABtZekG3HrzLBQ2NIan6xZrPPdwniyTyoLBoXd CtMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=6ccZu8PErC3lQg8JbMApWgMtNpIKuGVnDfVVOee7l1A=; b=yVZCDVgdTfFezq3AO7RtZ8TN8229QUgXVnS4LyzsBsMRnAEZxQwN36vzSIEJgCio0B i564+0pLeJzBGbU8AAyA7Wq7aqRORb5BuXxyA7M4PUWylxmPqgvUOiTuEGPp8HD/SZPf ruxK7Ik2foaZpfvmLW8cxUVajKP+tYAifrm4UZE1sTCgt1r/+mWxF2JaDeqw3w6OHGgI lGhEIasSzC2xGWyTkS0OMLVHKZsJrN+KhRao3a7NkrZlDfo/7kZl1Bn+yMB0hCm14+R7 eLqanIWKTalFqXRDAbyCBPsMcm86RVfPxqWv+oUgKwQrzAxTBfMGtPqHfDNY0E6YGmyt A3Jg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=U5QiHG9P; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id c23si4046791ejx.330.2021.01.08.18.02.52; Fri, 08 Jan 2021 18:03:16 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail header.b=U5QiHG9P; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726078AbhAICCC (ORCPT + 99 others); Fri, 8 Jan 2021 21:02:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55694 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725817AbhAICCB (ORCPT ); Fri, 8 Jan 2021 21:02:01 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 489FCC061573; Fri, 8 Jan 2021 18:01:21 -0800 (PST) Received: from pendragon.ideasonboard.com (62-78-145-57.bb.dnainternet.fi [62.78.145.57]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id DD446DA; Sat, 9 Jan 2021 03:01:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1610157679; bh=jsI0Dp9o8mrHP2CblfN6r1QQaTwTWmysU4tURYPgUMo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=U5QiHG9PHSftUYLy4cNy4+FFhCfqaahcrriQXDw5S0GoNFuyDf58VveyPSwEGqhPq XWvP4G1NkoVvO8QloEltriFbRw+f9BdyYsWl8JX+/SCOoJ+18b4avlLmY6iyf+w0JJ oAnqnVPXnkfQaTeSYpJagUn3auT7dgWhn1OE4xT4= Date: Sat, 9 Jan 2021 04:01:05 +0200 From: Laurent Pinchart To: Petr Mladek , Steven Rostedt , Sergey Senozhatsky Cc: Daniel Scally , linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-media@vger.kernel.org, devel@acpica.org, rjw@rjwysocki.net, lenb@kernel.org, gregkh@linuxfoundation.org, mchehab@kernel.org, yong.zhi@intel.com, sakari.ailus@linux.intel.com, bingbu.cao@intel.com, tian.shu.qiu@intel.com, robert.moore@intel.com, erik.kaneda@intel.com, andriy.shevchenko@linux.intel.com, linux@rasmusvillemoes.dk, laurent.pinchart+renesas@ideasonboard.com, jacopo+renesas@jmondi.org, kieran.bingham+renesas@ideasonboard.com, hverkuil-cisco@xs4all.nl, m.felsch@pengutronix.de, niklas.soderlund+renesas@ragnatech.se, prabhakar.mahadev-lad.rj@bp.renesas.com, slongerbeam@gmail.com, heikki.krogerus@linux.intel.com Subject: Re: [PATCH v5 09/15] lib/test_printf.c: Use helper function to unwind array of software_nodes Message-ID: References: <20210107132838.396641-1-djrscally@gmail.com> <20210107132838.396641-10-djrscally@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210107132838.396641-10-djrscally@gmail.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Peter, Steven and Sergey, Could you please let us know if you're fine with this patch getting merged in v5.12 through the linux-media tree ? The cover letter contains additional details (in a nutshell, this is a cross-tree series and we would like to avoid topic branches if possible). On Thu, Jan 07, 2021 at 01:28:32PM +0000, Daniel Scally wrote: > Use the software_node_unregister_nodes() helper function to unwind this > array in a cleaner way. > > Acked-by: Petr Mladek > Reviewed-by: Andy Shevchenko > Reviewed-by: Laurent Pinchart > Reviewed-by: Sergey Senozhatsky > Suggested-by: Andy Shevchenko > Signed-off-by: Daniel Scally > --- > Changes in v5: > > - None > > lib/test_printf.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/lib/test_printf.c b/lib/test_printf.c > index 7ac87f18a10f..7d60f24240a4 100644 > --- a/lib/test_printf.c > +++ b/lib/test_printf.c > @@ -644,9 +644,7 @@ static void __init fwnode_pointer(void) > test(second_name, "%pfwP", software_node_fwnode(&softnodes[1])); > test(third_name, "%pfwP", software_node_fwnode(&softnodes[2])); > > - software_node_unregister(&softnodes[2]); > - software_node_unregister(&softnodes[1]); > - software_node_unregister(&softnodes[0]); > + software_node_unregister_nodes(softnodes); > } > > static void __init -- Regards, Laurent Pinchart