Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp999442pxb; Sat, 9 Jan 2021 04:15:56 -0800 (PST) X-Google-Smtp-Source: ABdhPJxwcSYx3xOtVCKBOYkG9tKUv1a34rfUN9zdxjOCv02W09pjtnSG7na2buqs0fGhs6VKta4M X-Received: by 2002:a17:906:ae43:: with SMTP id lf3mr5003968ejb.130.1610194555995; Sat, 09 Jan 2021 04:15:55 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610194555; cv=none; d=google.com; s=arc-20160816; b=YGYV6p7v9D/lVZdXS/rqVcUROf4A5H3R1ut2eNv5jQ0lHRoZSZO2nCqxUCofCKawgK 1zxdj4V0umiWacIux2ZmxPvnAEaspHk1ml9htKOHZLJw63EyF70WUTqQWzYxDeESkUt7 Cpzibq04gmTlw+ShZrpWU4JqIAolfJod/wQ6lm3t8gnFYsS7XS3DC+rVUV5t8PZS/xOj bFdVO0QzAV0HgrGVvgbR79MKVW7zt/LqsWNPixLFVCeuztoAU9pOM11lua0aoJa6Un50 Zn9wQIMmPuulkqXdAfpE4sOOgCxhT3KS9hYFNno1fHBM5a/XSVeALAp+fqnOG9oLxDi8 AmlQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=EtK9vJ+NWj04MuM5K2n7QnqPICP6IA/yuURCbbbu8MU=; b=toXMv+EVEEA+MB85OxE1sz/HuBYhB9sFmbgnRf3c6Z9g7/M4oZi80YkBFgvLohJF9f nErTGkV0EvE3W8JvDXUhy/YLgbc70pS+x+6cmFBxziUIjIdkyiVuMz30XbC6bD6uHhGS NBNbSVeamqMUyNcs2L0FtcFD7nzQWfwKSxpsmulg+7RsHnPkAGdfWtprVfp+8W+9zJw1 LvnV8MT6oLSq1PplFwCSarbhhrXuC4J8wKScL5gWqFJncU/XpiNZoGM3xLdhwXVzi3Mi kPzc/S3yKXslmSPhxaoh++DZlWszSGblvLJcN2vFwLKWC0sevUktTxYTrfzpUdyDT6M1 vaWQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id y14si4772469edm.451.2021.01.09.04.15.21; Sat, 09 Jan 2021 04:15:55 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726294AbhAIMNT (ORCPT + 99 others); Sat, 9 Jan 2021 07:13:19 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44476 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725896AbhAIMNT (ORCPT ); Sat, 9 Jan 2021 07:13:19 -0500 Received: from Chamillionaire.breakpoint.cc (Chamillionaire.breakpoint.cc [IPv6:2a0a:51c0:0:12e:520::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 49F87C061786; Sat, 9 Jan 2021 04:12:39 -0800 (PST) Received: from fw by Chamillionaire.breakpoint.cc with local (Exim 4.92) (envelope-from ) id 1kyD6M-0005Tk-Dv; Sat, 09 Jan 2021 13:12:14 +0100 Date: Sat, 9 Jan 2021 13:12:14 +0100 From: Florian Westphal To: Dinghao Liu Cc: kjlu@umn.edu, Pablo Neira Ayuso , Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Jakub Kicinski , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netfilter: Fix memleak in nf_nat_init Message-ID: <20210109121214.GD19605@breakpoint.cc> References: <20210109120121.15938-1-dinghao.liu@zju.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210109120121.15938-1-dinghao.liu@zju.edu.cn> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Dinghao Liu wrote: > When register_pernet_subsys() fails, nf_nat_bysource > should be freed just like when nf_ct_extend_register() > fails. Acked-by: Florian Westphal