Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sat, 9 Jan 2021 18:57:31 +0530
From:   B K Karthik <bkkarthik@pesu.pes.edu>
To:     Johan Hovold <johan@kernel.org>, Alex Elder <elder@kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        greybus-dev@lists.linaro.org, devel@driverdev.osuosl.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH] staging: greybus: audio_helper.c: Replace strlcpy() with
 strscpy()
Message-ID: <20210109132731.tczawd5p74xnfz7p@pesu.pes.edu>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="kls55wqpg7fma2yb"
Content-Disposition: inline
User-Agent: NeoMutt/20171215
Precedence: bulk


--kls55wqpg7fma2yb
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

In gbaudio_remove_controls() , replace the usage of strlcpy() with
strscpy() because strlcpy() only limits the *destination*
size, and the source is always read fully.

https://lore.kernel.org/r/CAHk-=3DwgfRnXz0W3D37d01q3JFkr_i_uTL=3DV6A6G1oUZc=
prmknw@mail.gmail.com/
was quoted by checkpatch while showing this warning.

Signed-off-by: B K Karthik <bkkarthik@pesu.pes.edu>
---
 drivers/staging/greybus/audio_helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/audio_helper.c b/drivers/staging/greyb=
us/audio_helper.c
index 3011b8abce38..1ed4772d2771 100644
--- a/drivers/staging/greybus/audio_helper.c
+++ b/drivers/staging/greybus/audio_helper.c
@@ -166,7 +166,7 @@ static int gbaudio_remove_controls(struct snd_card *car=
d, struct device *dev,
 			snprintf(id.name, sizeof(id.name), "%s %s", prefix,
 				 control->name);
 		else
-			strlcpy(id.name, control->name, sizeof(id.name));
+			strscpy(id.name, control->name, sizeof(id.name));
 		id.numid =3D 0;
 		id.iface =3D control->iface;
 		id.device =3D control->device;
--=20
2.17.1


--kls55wqpg7fma2yb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQGzBAEBCgAdFiEE88CpXiCXh4Qs88cHZmzYLLde5wcFAl/5r0MACgkQZmzYLLde
5wc1MQwAxhSWhwtY2mD97K2T1quipOm7mKH5OHygx9T/aAr8t5k92DznAVswiHV1
KE/jBYTfu1P0MYp/74rWvcb8fm5+fKoICSu5WIn6XIbiuIw010CY48QJilmcyDp5
Kq2UNpmGtCrE2eI8ePFnkiRgK7Y3KVS/OlMoVLd+msLevI+Rf/Is/RsV1UARHb9t
uQed1rw//LB8qM2FV+MpoY5z9a8kcohX10TPTbsepXr0TRqpkdvAFcDNbg2+kdHr
UIXCinZXW6vpN9+YoxfMndrFHqUjj0mAEW42pNhA4Kd61+kXW4BJgEWhch/naERx
SdSxQDaU547U0vqoaYsbIiAEF5M0nVmcsSaqFO33GHSDYy11QmyIGYbh9mHhe/u5
KYaVd/geKHpFk014AmdBnKlSZ9zc7GkxSF56AU0S2Uwu+mcic0lTLUfMkLIpxxNL
oxZO2c0bxUNVDQutoTsF4idVSc5rFwBAKD+iby3x7smxeZpSQ/GhVchG4FWTGxgc
eSfg+mBK
=6954
-----END PGP SIGNATURE-----

--kls55wqpg7fma2yb--