Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp1115731pxb; Sat, 9 Jan 2021 07:56:19 -0800 (PST) X-Google-Smtp-Source: ABdhPJxQTui9xUF1ayrRWGzuYGpmRAsMzOjzkOYVeEwu0WU2oB4cCpzjoauLVVJnEtm9Y/gbSFi+ X-Received: by 2002:a05:6402:b42:: with SMTP id bx2mr8760726edb.117.1610207779781; Sat, 09 Jan 2021 07:56:19 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610207779; cv=none; d=google.com; s=arc-20160816; b=cflcq3V71dJ1593ky5cZI8iwYcV42f6eAYM1tbsPeErx1g3SyFtA8OfAi+eUTdgQA/ DkIIKBeleTduSwjbQfQCF19KQcmYm0FU+ZxVxxDLF80DLDlPqV5DACvjx4K06mctdV7e Rh7VBR98U1sS4M0rADQIy7xp7ee1nC4jM8q3eZtgZqrNKmybaDXBAslkkU+cMq2CJTD6 UUyOF0tAcyOggyKCR30KPR1vdckQ3OXCFWi1w/5Ww5pVPRUqqRg/lLFjPcnzX8NOMOiQ Y996Q6HODQPFJJQ4dT212KieMwrjYd57x7UcXaRBgBuWy+T+n3x4ZT+rnslWQe8CcC/C IRIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=09yRiKQ1/sbgcP3NlT1oqiUvgg4xs1rBBhbFtGX/1lQ=; b=GP3QR/gDs1hK6smFTuB9zmIUvFaSs/SLFJBztLsExXvoXpZz7qSuWjjdz7Gj0sULDi Q+8gZnsGCxQKUpK5x2r+d05I9oIPpYFQZQsiVikNZ5NCuRtcCVG0lBJ44TRkPExawSBC YNW95EvwD0vdhBkWCpNDe/Yw3v5Fl0qM9WMcetzujJwcTwzMKisV8tEAqvvBQtuioUO0 H9LbDCHpnV+aidcZJ8AfJeujtB9Qkm/g7MyxFmSQmBkrCNqCC5GjODl8cZkXdnogw11X Tk8kSXsm54rn9a2SFeyXEzqUaFtih6mx/DUXcg0lC9cUbj6d/vFqd4lsG+quhyx6ZdDB 0qeQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a1si4909606ede.520.2021.01.09.07.55.55; Sat, 09 Jan 2021 07:56:19 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726267AbhAIPzP (ORCPT + 99 others); Sat, 9 Jan 2021 10:55:15 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:58824 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726090AbhAIPzP (ORCPT ); Sat, 9 Jan 2021 10:55:15 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kyGZK-00H7jv-Vb; Sat, 09 Jan 2021 16:54:22 +0100 Date: Sat, 9 Jan 2021 16:54:22 +0100 From: Andrew Lunn To: Russell King - ARM Linux admin Cc: Pali =?iso-8859-1?Q?Roh=E1r?= , "David S. Miller" , Jakub Kicinski , Thomas Schreiber , Heiner Kallweit , Marek =?iso-8859-1?Q?Beh=FAn?= , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] net: sfp: assume that LOS is not implemented if both LOS normal and inverted is set Message-ID: References: <20201230154755.14746-1-pali@kernel.org> <20210106153749.6748-1-pali@kernel.org> <20210106153749.6748-3-pali@kernel.org> <20210109154601.GZ1551@shell.armlinux.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210109154601.GZ1551@shell.armlinux.org.uk> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 09, 2021 at 03:46:01PM +0000, Russell King - ARM Linux admin wrote: > On Thu, Jan 07, 2021 at 05:54:28PM +0100, Andrew Lunn wrote: > > On Wed, Jan 06, 2021 at 04:37:48PM +0100, Pali Roh?r wrote: > > > From: Russell King > > > > > > Some GPON SFP modules (e.g. Ubiquiti U-Fiber Instant) have set both > > > SFP_OPTIONS_LOS_INVERTED and SFP_OPTIONS_LOS_NORMAL bits in their EEPROM. > > > > > > Such combination of bits is meaningless so assume that LOS signal is not > > > implemented. > > > > > > This patch fixes link carrier for GPON SFP module Ubiquiti U-Fiber Instant. > > > > > > Signed-off-by: Russell King > > > Signed-off-by: Pali Roh?r > > > > Reviewed-by: Andrew Lunn > > I'd like to send this patch irrespective of discussion on the other > patches - I already have it committed in my repository with a different > description, but the patch content is the same. > > Are you happy if I transfer Andrew's r-b tag Hi Russell If it is the same contest, no problem. I can always NACK it later... Andrew