Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
Message-ID: <trinity-5d8f37cd-9d0e-4790-baf9-30b8ea4bc743-1610210692928@3c-app-gmx-bap17>
From:   Frank Wunderlich <frank-w@public-files.de>
To:     matthias.bgg@kernel.org
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Gene Chen <gene_chen@richtek.com>,
        Matthias Brugger <mbrugger@suse.com>,
        Axel Lin <axel.lin@ingics.com>,
        Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
        linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org,
        John Crispin <john@phrozen.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Chen Zhong <chen.zhong@mediatek.com>,
        Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>
Subject: Aw: [PATCH v2 3/3] regulator: mt6323: Add OF match table
Content-Type: text/plain; charset=UTF-8
Date:   Sat, 9 Jan 2021 17:44:52 +0100
Importance: normal
Sensitivity: Normal
In-Reply-To: <20210109112612.1221-3-matthias.bgg@kernel.org>
References: <20210109112612.1221-1-matthias.bgg@kernel.org>
 <20210109112612.1221-3-matthias.bgg@kernel.org>
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi

> Gesendet: Samstag, 09. Januar 2021 um 12:26 Uhr
> Von: matthias.bgg@kernel.org

> Changes in v2:
> - check for CONFIG_OF
> - add Fixes tag

> --- a/drivers/regulator/mt6323-regulator.c
> +++ b/drivers/regulator/mt6323-regulator.c
> @@ -406,9 +406,18 @@ static const struct platform_device_id mt6323_platf=
orm_ids[] =3D {
>  };
>  MODULE_DEVICE_TABLE(platform, mt6323_platform_ids);
>
> +#ifdef CONFIG_OF
> +static const struct of_device_id mt6323_of_match[] =3D {
> +	{ .compatible =3D "mediatek,mt6323-regulator", },
> +	{ /* sentinel */ },
> +};
> +MODULE_DEVICE_TABLE(of, mt6323_of_match);
> +#endif
> +
>  static struct platform_driver mt6323_regulator_driver =3D {
>  	.driver =3D {
>  		.name =3D "mt6323-regulator",
> +		.of_match_table =3D of_match_ptr(mt6323_of_match),

imho check for CONFIG_OF is here needed too, else mt6323_of_match is refer=
enced but undefined

>  	},
>  	.probe =3D mt6323_regulator_probe,
>  	.id_table =3D mt6323_platform_ids,

regards Frank