Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210109163916.1247431-1-aford173@gmail.com> <8B45575E-A50B-407C-8920-D2A7E295DBE9@goldelico.com>
In-Reply-To: <8B45575E-A50B-407C-8920-D2A7E295DBE9@goldelico.com>
From:   Adam Ford <aford173@gmail.com>
Date:   Sat, 9 Jan 2021 11:03:06 -0600
Message-ID: <CAHCN7x+j0N6rop616UDhSx_qgkWLyUmRV2MVN74qT17z-ktaAw@mail.gmail.com>
Subject: Re: [PATCH] ARM: dts: omap36xx: Remove turbo mode for 1GHz variants
To:     "H. Nikolaus Schaller" <hns@goldelico.com>
Cc:     Linux-OMAP <linux-omap@vger.kernel.org>,
        Adam Ford-BE <aford@beaconembedded.com>,
        =?UTF-8?Q?Beno=C3=AEt_Cousson?= <bcousson@baylibre.com>,
        Tony Lindgren <tony@atomide.com>,
        Rob Herring <robh+dt@kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Andreas Kemnade <andreas@kemnade.info>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sat, Jan 9, 2021 at 10:58 AM H. Nikolaus Schaller <hns@goldelico.com> wrote:
>
> Hi Adam,
>
> > Am 09.01.2021 um 17:39 schrieb Adam Ford <aford173@gmail.com>:
> >
> > Previously, the 1GHz variants were marked as a turbo,
> > because that variant has reduced thermal operating range.
> >
> > Now that the thermal throttling is in place, it should be
> > safe to remove the turbo-mode from the 1GHz variants, because
> > the CPU will automatically slow if the thermal limit is reached.
>
> Subject and description may be misunderstood in a way that 1GHz
> is now disabled.
>
> Rather the 1GHz OPP is now permanently enabled and does no longer
> need to be manuall enabled through something like
> /sys/devices/system/cpu/cpufreq/boost.

I just sent a V2, before I saw this. I can send a V3 with your
feedback.  I just want to give Tony and/or others a chance to chime
in.

>
> >
> > Signed-off-by: Adam Ford <aford173@gmail.com>
> >
> > diff --git a/arch/arm/boot/dts/logicpd-torpedo-som.dtsi b/arch/arm/boot/dts/logicpd-torpedo-som.dtsi
> > index 3a5228562b0d..3451f9be104e 100644
> > --- a/arch/arm/boot/dts/logicpd-torpedo-som.dtsi
> > +++ b/arch/arm/boot/dts/logicpd-torpedo-som.dtsi
> > @@ -70,6 +70,7 @@ nand@0,0 {
> >               gpmc,device-width = <2>;
> >               #address-cells = <1>;
> >               #size-cells = <1>;
> > +             status = "disabled";
>
> this does not seem to match the description?

I just sent an apology e-mail because I realized I grabbed the wrong file.

>
> >       };
> > };
> >
> > --
> > 2.25.1
> >
>
> BR,
> Nikolaus
>