Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp1514393pxb; Sun, 10 Jan 2021 00:43:32 -0800 (PST) X-Google-Smtp-Source: ABdhPJyTAZi+JPWx0rqL6I6nC3xAXeanHokutXB83HOLR989wDSqffpr87mChhjFIf+7F+3F70Vt X-Received: by 2002:a17:906:adcb:: with SMTP id lb11mr7232661ejb.346.1610268212196; Sun, 10 Jan 2021 00:43:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610268212; cv=none; d=google.com; s=arc-20160816; b=fT1Y+vDlYNIOZf7UXhW4qh2Swy3XZn7AbcMWThFool1QG5VjLngloL85zZpScSqwT3 0JBSt5ZM1MEJ1KpxcYpN7LQ/c5Ni8Au83zVFqiRm/sd7nlV78BD8J6DvYyhH6yVAOHTN 78CNa8XvpyrfmrxWV6RrEZlbWcyDgBJds+ROr9/Klqm1MGIe4J+6mQAxSJDd9efv1u+p C3L9o6DX5uHgiq7nUTATCQElc6kXyhU1yhXriQsmSHUnkM86VnUTNiFTK8fgIr/cKrfd EuuG/1KnDW1Zi0Bkqert7Qpod2nIgSwRnPU506XSi/3PfsHe0k0T/yn5VIuZVtvN56O5 Bsuw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=GJrDk0k4TbxrcYcpjOlx7f1+sPaKvzxdH3mdJ7cBoMo=; b=0vYDJEIao7J9evQdrKfrlV7Dg3XRI7Sz7gikNDd2tSe/YLM9Jfr1QX8PvfOYQMe0xP RefJm/qtIW62081AfFJktHr1cp4UKSRWB4vbR/2uCrB0qV+RWBxYcEQSUgxtedOjUHyr oWZXVF8IE4VuL6JfWxXJ5P9USVIPpC3KgvBPG7OTU+PuR6HFEAQsEAJcQZjqbhm65yfj eq4a5p/ijz4Yzk7hom0p0CEnevXVQiA4Wl9lwNkwkNc2qVylA9T1CJO6rX8aaRGlhm0E P20vytWWFgaB4CrES2L/Yo6Ojz18KY/s5LoyYKcHMz/8HeyHFbdYTAmfKZisOZrmqkfk 6Ouw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k11si5758846edq.414.2021.01.10.00.43.08; Sun, 10 Jan 2021 00:43:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726228AbhAJIkm (ORCPT + 99 others); Sun, 10 Jan 2021 03:40:42 -0500 Received: from correo.us.es ([193.147.175.20]:38936 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726663AbhAJIkl (ORCPT ); Sun, 10 Jan 2021 03:40:41 -0500 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id BA40DD2B00 for ; Sun, 10 Jan 2021 09:39:18 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id AE8C3DA73D for ; Sun, 10 Jan 2021 09:39:18 +0100 (CET) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 9A0C8DA791; Sun, 10 Jan 2021 09:39:18 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-108.2 required=7.5 tests=ALL_TRUSTED,BAYES_50, SMTPAUTH_US2,USER_IN_WELCOMELIST,USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 71790DA73D; Sun, 10 Jan 2021 09:39:16 +0100 (CET) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Sun, 10 Jan 2021 09:39:16 +0100 (CET) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (unknown [90.77.255.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 3F65F426CC84; Sun, 10 Jan 2021 09:39:16 +0100 (CET) Date: Sun, 10 Jan 2021 09:39:57 +0100 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Dinghao Liu Cc: kjlu@umn.edu, Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , Jakub Kicinski , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netfilter: Fix memleak in nf_nat_init Message-ID: <20210110083957.GA28820@salvia> References: <20210109120121.15938-1-dinghao.liu@zju.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20210109120121.15938-1-dinghao.liu@zju.edu.cn> User-Agent: Mutt/1.10.1 (2018-07-13) X-Virus-Scanned: ClamAV using ClamSMTP Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Jan 09, 2021 at 08:01:21PM +0800, Dinghao Liu wrote: > When register_pernet_subsys() fails, nf_nat_bysource > should be freed just like when nf_ct_extend_register() > fails. Applied, thanks.