Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: 0qt1cDYIdK3sbvmQza598FykmCVbJxM0w6Qbv3kt+YALDD5xWA3/9kcwVgMNa2jRNIfOBN71hp
 Kocjr7YMtwiw==
IronPort-SDR: Zp///lTGph+mZNIzoTZA8d78SxbDa5siDNh+0CYoXQB8DXs0S/fho4dDtUnniMigeQt49Fig/n
 wxivcfJDVStw==
From:   "Chen, Mike Ximing" <mike.ximing.chen@intel.com>
To:     Greg KH <gregkh@linuxfoundation.org>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "arnd@arndb.de" <arnd@arndb.de>,
        "Williams, Dan J" <dan.j.williams@intel.com>,
        "pierre-louis.bossart@linux.intel.com" 
        <pierre-louis.bossart@linux.intel.com>
Subject: RE: [PATCH v8 03/20] dlb: add resource and device initialization
Thread-Topic: [PATCH v8 03/20] dlb: add resource and device initialization
Thread-Index: AQHW4w7I7403thdBpUePoKfbt2GH26ock8QAgASJHIA=
Date:   Sun, 10 Jan 2021 17:22:32 +0000
Message-ID: <SA2PR11MB5018D896774B86B57354D32ED9AC0@SA2PR11MB5018.namprd11.prod.outlook.com>
References: <20210105025839.23169-1-mike.ximing.chen@intel.com>
 <20210105025839.23169-4-mike.ximing.chen@intel.com>
 <X/djqGBzpYg+B6dF@kroah.com>
In-Reply-To: <X/djqGBzpYg+B6dF@kroah.com>
Accept-Language: en-US
Content-Language: en-US
dlp-version: 11.5.1.3
dlp-reaction: no-action
dlp-product: dlpe-windows
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: c5a471a6-d34b-48e4-f797-08d8b58c5077
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2021 17:22:32.1729
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: +7IbBQcNVcMrqkPGRjPH3V3+WE9CnLa4a//ydZCmXkQq92U7Nea9oQl2V2h3+5ENaZiSFfoMMgJu6WQTASZrDLO5sZxj0BR8b0z/4ZP2K/c=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN6PR11MB3230
X-OriginatorOrg: intel.com
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Thursday, January 7, 2021 2:40 PM
> To: Chen, Mike Ximing <mike.ximing.chen@intel.com>
> Cc: linux-kernel@vger.kernel.org; arnd@arndb.de; Williams, Dan J
> <dan.j.williams@intel.com>; pierre-louis.bossart@linux.intel.com; Gage Ea=
ds
> <gage.eads@intel.com>
> Subject: Re: [PATCH v8 03/20] dlb: add resource and device initialization
>=20
> On Mon, Jan 04, 2021 at 08:58:22PM -0600, Mike Ximing Chen wrote:
> > Introduce dlb_bitmap_* functions, a thin convenience layer wrapping the
> > Linux bitmap interfaces, used by the bitmaps in the dlb hardware types.
>=20
> No, you created custom #defines:
>=20
> > --- a/drivers/misc/dlb/dlb_hw_types.h
> > +++ b/drivers/misc/dlb/dlb_hw_types.h
> > @@ -5,6 +5,15 @@
> >  #define __DLB_HW_TYPES_H
> >
> >  #include <linux/io.h>
> > +#include <linux/types.h>
> > +
> > +#include "dlb_bitmap.h"
> > +
> > +#define BITS_SET(x, val, mask)	(x =3D ((x) & ~(mask))     \
> > +				 | (((val) << (mask##_LOC)) & (mask)))
> > +#define BITS_CLR(x, mask)	((x) &=3D ~(mask))
> > +#define BIT_SET(x, mask)        ((x) |=3D (mask))
> > +#define BITS_GET(x, mask)       (((x) & (mask)) >> (mask##_LOC))
>=20
> We have functions for this, use them, don't create custom macros for
> them.  Use the Linux functions please.
>=20
> thanks,
>=20
> greg k-h

FIELD_GET(_mask, _val) and FIELD_PREP(_mask, _val) in include/linux/bitfiel=
d.h are similar to our BITS_GET() and BITS_SET().  However in our case, mas=
k##_LOC is a known constant defined in dlb_regs.h.  So we don't need to use=
 _buildin_ffs(mask) to calculate the location of mask as FIELD_GET() and FI=
ELD_PREP() do.  We can still use FIELD_GET and FIELD_PREP, but our macros a=
re a little more efficient. Would it be OK to use them?=20

Thanks
Mike