Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: Aw: [PATCH v2 3/3] regulator: mt6323: Add OF match table
To:     Frank Wunderlich <frank-w@public-files.de>, matthias.bgg@kernel.org
Cc:     Liam Girdwood <lgirdwood@gmail.com>,
        Mark Brown <broonie@kernel.org>,
        Gene Chen <gene_chen@richtek.com>,
        Axel Lin <axel.lin@ingics.com>,
        Matti Vaittinen <matti.vaittinen@fi.rohmeurope.com>,
        linux-kernel@vger.kernel.org, linux-mediatek@lists.infradead.org,
        linux-arm-kernel@lists.infradead.org,
        John Crispin <john@phrozen.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Chen Zhong <chen.zhong@mediatek.com>,
        Hsin-Hsiung Wang <hsin-hsiung.wang@mediatek.com>
References: <20210109112612.1221-1-matthias.bgg@kernel.org>
 <20210109112612.1221-3-matthias.bgg@kernel.org>
 <trinity-5d8f37cd-9d0e-4790-baf9-30b8ea4bc743-1610210692928@3c-app-gmx-bap17>
From:   Matthias Brugger <mbrugger@suse.com>
Message-ID: <f0be4573-685a-33ae-16a0-d483272571b7@suse.com>
Date:   Sun, 10 Jan 2021 19:48:01 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.0
In-Reply-To: <trinity-5d8f37cd-9d0e-4790-baf9-30b8ea4bc743-1610210692928@3c-app-gmx-bap17>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from ziggy.stardust (213.195.126.134) by VI1PR0901CA0103.eurprd09.prod.outlook.com (2603:10a6:800:7e::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3742.6 via Frontend Transport; Sun, 10 Jan 2021 18:48:03 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-Correlation-Id: 833a1757-7520-4d60-b579-08d8b59843ec
X-MS-TrafficTypeDiagnostic: AM5PR0401MB2481:
X-Microsoft-Antispam-PRVS: <AM5PR0401MB24810D72A00AD449DDB65242BAAC0@AM5PR0401MB2481.eurprd04.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:972;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: RYojoK0xJ3L7eCyCS1HVBe2Wbl+yqGW4sWFBsv6PfUXnFhzLqBw6w1Hss8y03dBVWndb1W+VhrVOGCQ1t6djFhe2l9UBK2uTjgyJxvm/mXfAAQ0IoxWxQ7gnPUwMC0Q/m/pwhlkE58kr3v2bX7nnEfkihbrN4Gsb/jSQIx3gQf4DWLYTaeUb6COEjgQnkSbkJNdz0smyQui9NNfcjhshhmH7U2SJVfWwvME6gAn0IAlD/k1GMxdc6BJSAdFsnH5G2rqu+otPqXZWlNF8QE9s1PvZ1Fszkn4oVUKNt/WtJVmPNhB6eLWuhZVbgmbDX5srlct8tjRC7/XR8BjZfpWt6oq29iJA1N/gpBPG7LQlVTYDj9hW2uNOdi02OSJgLY+qb9xPSQlmCAzPHDxsO55sW3wgtjDp+XMdhrW5rTbPXUn2erQ+wKQRUwM8L0OqlewP7Tm1sYvQWbuHBvYZY0Ndk22NsLSj9YquHuWffS3LymJhhatqsNKljusJh8XcKElmBA1ZBUGBAI2AVqWFWbIRxUsvWw/H7QvaLH/wB8RSdDg=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AM6PR04MB5366.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(136003)(366004)(346002)(396003)(39850400004)(376002)(8936002)(16526019)(186003)(4326008)(6512007)(31686004)(8676002)(6506007)(956004)(2616005)(53546011)(966005)(66556008)(478600001)(36756003)(66476007)(7416002)(66946007)(52116002)(316002)(6486002)(2906002)(31696002)(5660300002)(26005)(86362001)(54906003)(45980500001)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?OUlFd1pPQTBPNXJSMVhxVmdmbHVUeWVXRjVOdVEyTWxpMUZMZHdjVkd3NlBP?=
 =?utf-8?B?VmhhdnpRREtjSW5Vd0RnQWdCMVdOSFlHQmhBNG8yZWYxR1ViVVBtdWtiNEx3?=
 =?utf-8?B?YUtaS3l5WW1QWkV2anRqNFVqQktlSzNZbEpDSEdZKzhETTBGU0lzOUpnUFhE?=
 =?utf-8?B?a2FKMHBKaVlFa2dwMDRvV2lWZzRWTmg2WTBLMjZ0akpGTzVSZ1Y4UGZDaGxI?=
 =?utf-8?B?SWFkUkp5SWx0dlJXcFg3aG5BSW56cmkxSVNxQ3dPZTU1eWF3K3F0NDhPWFJ3?=
 =?utf-8?B?REJkdFI4NHZFSk8vZ2ZqVFRHdS9ROWhycXJxTFZIYmlHSkZJWnltcmc1bGV2?=
 =?utf-8?B?MFcrTXA0QmxQT0JVVFoxWiszZXY2YXAyVGQ0YXl0NnlEOGsyQ0VTYzdEeFZi?=
 =?utf-8?B?WE1HL1NiSCtvVGlud0J0RE5vdm9Id2VJa3VqUDdaNDhHWnF5aGg0T3NoN24y?=
 =?utf-8?B?cWk4cE1CUng5T2VvODExT2lmdEVTY2NMcVBST3BVVTN3UjZpZlh1SjgwbTZv?=
 =?utf-8?B?L3hGSlZvdmI4SHNoUXNqUW4xRlp4d25LRlFWbENwSnlKT01BQS9WZHhtV3V4?=
 =?utf-8?B?U2J5TmRMeGh1VWVJTW4wbVRaOHdITzVJZG9yVW1aeUxjQ0ZPaGprQitWbXk5?=
 =?utf-8?B?b3JrT2NqVlR6bVRzZkZmeTJCL0pzUmMzaHd4Q1czVjQxRVJFUG9sOGN4YTJF?=
 =?utf-8?B?WmJEWWh0a1cwc1BveEtnUklrdTRXMzRGaEZISjNLZEorZDQ5Y3BoSVo5aWNT?=
 =?utf-8?B?Q1NFamtDWVZjSXJFM2VHVEU4b0V0WXF3WDdlc3ZFRXpIYURDNEc5QU16cWYw?=
 =?utf-8?B?UEVXbVl2eHBMR0d6SWYyR01HVUIyZ2hIZzgvY3JncFM3YVRvWTFJM2FUS3Rn?=
 =?utf-8?B?aE9rbnJZUXlEdytrOXpWVW5kakNQWndTMXphSEZhVXE3cERxM25VVHRCVk9j?=
 =?utf-8?B?T0RidVpGb2EyVnhWelpvNGkyQ2xpN0toY0xKM0NUY2swLzBuSjlWWDA2VFpn?=
 =?utf-8?B?YU5Na2V4dzlyMHNWWkpQQmltUkJXKzd0VmlIKzlTbzk1NHdTdzBORGVBaC9y?=
 =?utf-8?B?TzBzY2tnZ2NNYTY1M0pVVFRlbHhPcDNKWjRJN2cxSm4va3I4VE9hVHZEdWRX?=
 =?utf-8?B?TjRWb1B6U0gxK0xYNzlnNC9QeW9YMnQ1QzNuMEw3bUUyY0NOSEM5Z0lDYXdC?=
 =?utf-8?B?WVdVdUs3SUJkK0hwUU1xWlZnMkQwMGVjQ2RYcEpQeW5NM29TbjV6RlNpNHY1?=
 =?utf-8?B?cCtuckRpYmpmVUpFMEdXbW9VMHJ6cjZVZ3VBeDE5T2kyc1Q3ZGI3d1Z4cVFp?=
 =?utf-8?Q?bPrStPhXlsJFnnw4LX6UCIRHL9P1QV/y0X?=
X-OriginatorOrg: suse.com
X-MS-Exchange-CrossTenant-AuthSource: AM6PR04MB5366.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Jan 2021 18:48:05.1648
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: f7a17af6-1c5c-4a36-aa8b-f5be247aa4ba
X-MS-Exchange-CrossTenant-Network-Message-Id: 833a1757-7520-4d60-b579-08d8b59843ec
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: zZliIjZ6WWnyjg0VtK4cPvbZtz0zvR21U8FB4x2w6IGdfE+OGwdDuONgJ8jm9eSCztd/E1kiYRaOneG8/D2t1g==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM5PR0401MB2481
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 09/01/2021 17:44, Frank Wunderlich wrote:
> Hi
> 
>> Gesendet: Samstag, 09. Januar 2021 um 12:26 Uhr
>> Von: matthias.bgg@kernel.org
> 
>> Changes in v2:
>> - check for CONFIG_OF
>> - add Fixes tag
> 
>> --- a/drivers/regulator/mt6323-regulator.c
>> +++ b/drivers/regulator/mt6323-regulator.c
>> @@ -406,9 +406,18 @@ static const struct platform_device_id mt6323_platform_ids[] = {
>>  };
>>  MODULE_DEVICE_TABLE(platform, mt6323_platform_ids);
>>
>> +#ifdef CONFIG_OF
>> +static const struct of_device_id mt6323_of_match[] = {
>> +	{ .compatible = "mediatek,mt6323-regulator", },
>> +	{ /* sentinel */ },
>> +};
>> +MODULE_DEVICE_TABLE(of, mt6323_of_match);
>> +#endif
>> +
>>  static struct platform_driver mt6323_regulator_driver = {
>>  	.driver = {
>>  		.name = "mt6323-regulator",
>> +		.of_match_table = of_match_ptr(mt6323_of_match),
> 
> imho check for CONFIG_OF is here needed too, else mt6323_of_match is referenced but undefined
> 

No, of_match_ptr already takes care of this:
https://elixir.bootlin.com/linux/latest/source/include/linux/of.h#L998

Regards,
Matthias