Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: FXfhJkaIeYMZa7KXYDrNeYJpzyS4uyJeesMHeZAi3M/EW0LQFQDH7KNlUQOLgDh4YQ0C8nTTCo
 I0g6KkEHJIKQ==
IronPort-SDR: bNOGErMi/2oX0P5qyLbFMfEqnfOmG6KeUyGVi9zIq6DugpGOBw8wq1FPjODf21q9QbrCOiQ+zo
 Hbs6PfMUoC0Q==
Date:   Mon, 11 Jan 2021 12:03:21 +0800
From:   Shuo A Liu <shuo.a.liu@intel.com>
To:     Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc:     linux-kernel@vger.kernel.org, x86@kernel.org,
        "H . Peter Anvin" <hpa@zytor.com>,
        Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
        Yu Wang <yu1.wang@intel.com>,
        Reinette Chatre <reinette.chatre@intel.com>,
        Zhi Wang <zhi.a.wang@intel.com>,
        Zhenyu Wang <zhenyuw@linux.intel.com>
Subject: Re: [PATCH v7 08/18] virt: acrn: Introduce EPT mapping management
Message-ID: <20210111040321.GE22447@shuo-intel.sh.intel.com>
References: <20210106075055.47226-1-shuo.a.liu@intel.com>
 <20210106075055.47226-9-shuo.a.liu@intel.com>
 <X/h7bhf9RRGjnJ+a@kroah.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Disposition: inline
In-Reply-To: <X/h7bhf9RRGjnJ+a@kroah.com>
User-Agent: Mutt/1.8.3 (2017-05-23)
Precedence: bulk

On Fri  8.Jan'21 at 16:34:06 +0100, Greg Kroah-Hartman wrote:
>On Wed, Jan 06, 2021 at 03:50:45PM +0800, shuo.a.liu@intel.com wrote:
>> +/**
>> + * struct acrn_vm_memmap - A EPT memory mapping info for a User VM.
>> + * @type:		Type of the memory mapping (ACRM_MEMMAP_*).
>> + *			Pass to hypervisor directly.
>> + * @attr:		Attribute of the memory mapping.
>> + *			Pass to hypervisor directly.
>> + * @user_vm_pa:		Physical address of User VM.
>> + *			Pass to hypervisor directly.
>> + * @service_vm_pa:	Physical address of Service VM.
>> + *			Pass to hypervisor directly.
>> + * @vma_base:		VMA address of Service VM. Pass to hypervisor directly.
>> + * @len:		Length of the memory mapping.
>> + *			Pass to hypervisor directly.
>> + */
>> +struct acrn_vm_memmap {
>> +	__u32	type;
>> +	__u32	attr;
>> +	__u64	user_vm_pa;
>> +	union {
>> +		__u64	service_vm_pa;
>> +		__u64	vma_base;
>> +	};
>> +	__u64	len;
>> +};
>
>Endianness?

Same consideration within patch 06/18. Need i specify these values? They
are more like ioctls' paramter values.

Thanks
shuo
>