Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Felipe Balbi <balbi@kernel.org>
To:     Davidlohr Bueso <dave@stgolabs.net>
Cc:     gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
        linux-kernel@vger.kernel.org, dave@stgolabs.net,
        Takashi Iwai <tiwai@suse.de>, Davidlohr Bueso <dbueso@suse.de>
Subject: Re: [PATCH] usb/gadget: f_midi: Replace tasklet with work
In-Reply-To: <20210111042855.73289-1-dave@stgolabs.net>
References: <20210111042855.73289-1-dave@stgolabs.net>
Date:   Mon, 11 Jan 2021 09:28:29 +0200
Message-ID: <87r1ms0w6a.fsf@kernel.org>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
        micalg=pgp-sha256; protocol="application/pgp-signature"
Precedence: bulk

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Hi,

Davidlohr Bueso <dave@stgolabs.net> writes:
> Currently a tasklet is used to transmit input substream buffer
> data. However, tasklets have long been deprecated as being too
> heavy on the system by running in irq context - and this is not
> a performance critical path. If a higher priority process wants
> to run, it must wait for the tasklet to finish before doing so.
>
> Deferring work to a workqueue and executing in process context
> should be fine considering the callback already does
> f_midi_do_transmit() under the transmit_lock and thus changes in
> semantics are ok regarding concurrency - tasklets being serialized
> against itself.
>
> Cc: Takashi Iwai <tiwai@suse.de>
> Signed-off-by: Davidlohr Bueso <dbueso@suse.de>

Acked-by: Felipe Balbi <balbi@kernel.org>

=2D-=20
balbi

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQJFBAEBCAAvFiEElLzh7wn96CXwjh2IzL64meEamQYFAl/7/h0RHGJhbGJpQGtl
cm5lbC5vcmcACgkQzL64meEamQaP+w/+J5qh4pBcJtfTxO/pDGQ7dXVkNNtlPg6G
pshmJZJ/ZN4Zf49eVgMoL8YlJoWWvqOQ9OfPo+yba1/+Dw38X2Yyw6LlYDgL7Grj
m7tL/nxNTn5hYjOWSE7VXLrk3lz4m3JkOjyMoWiWNjHLf5HDT14vX3cVxUBxx8Md
zHNekHTMc4j0PjZjFf7cb5w6QqBxqFi6Hy41KtJZY85XTwm3dVxRksLISTBw7u2i
SHK5kLu0gAuiGRwPj9RCz2bbeGEAjLjzC/nefu3Dk5MbvH7X29VKBDzXAU2kGbCF
WPrLMoGn/8ls9phfqY9x0Fh0jkdG0wufBVAYZRqxJYWp7b0HuOLBGGa7c6BrEWLG
0Yguw9WOvT3Wa37Vwp3saKQUnB6IlBEA774ex3gzVButJ8cclf5ZRHAxEgocTU4a
GSdwTEkpuNUusbFpXARNDgIzlcVY7JWl8oRxYag3AYw1y05jsAK40kvOKAKmno0n
WaNkoBM9UnsQeN1sYa7C3VBUKg+uJI5J3DiXP0zVaJX/EWIHH9ZhbRiaWlXQrFc/
PVh4Soyb0rg+3+OIRpa71nZ6S+4dtHF2uJMd6JPSDOVMAzmOiCruC2q03fHWn8Zh
eEdCDW2emiowat3OXebB9tLaO9/blYN2F5ijf2yKbu8Dblj8G+ZQxP5WJuPZRMWD
SezH8MDE/5U=
=Cnux
-----END PGP SIGNATURE-----
--=-=-=--