Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp2085380pxb; Sun, 10 Jan 2021 23:47:43 -0800 (PST) X-Google-Smtp-Source: ABdhPJy3Y3zfZc1asEz47/eW+ozfGIqp6ixrTSqvN/b9nZ+FQAol2sfIoQhCc1zROkX9t9Xg2HTE X-Received: by 2002:a50:f299:: with SMTP id f25mr13093427edm.133.1610351263788; Sun, 10 Jan 2021 23:47:43 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610351263; cv=none; d=google.com; s=arc-20160816; b=dXZRojHepJ3lDyQ8ifdzZDbAOALMpkzFlQPVX3GknXh6pMiL36qs2eldr/RFfAknAl OuQ80x/JgQ2TfbtoTjL5BrKOj7yr5Y6dVOlBigVM+9rk4VO9oTyDF8S2+UK65eg/JKmP Kwa4o6Kh1ILWRn3PGFBXu6HqAA3vuDYWlRHJJWpdK1HrJrGQdVc66lT4hZcP9aMbXIME /F+bYSSWsz+saG4pmkWPggwPXAfs6/u9/u2djcZ6IOHTp3wDEoYZ9DS/wNlKeLfbUvKb GrQ9qJEUEGdLYExsfXsEBZcbN/g6aFbXwupeWBU+dFidcFpQUOslwCGyu6qM+qlyvyjI o3ww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:cc:to:from; bh=XlVNT4okYllCV2FMByBjrPFkjAuCsiCAn8mQH83Vm/E=; b=EWNVzxauAN7KniRQaZ20UQowFfG40xOfaUWS4IcLLNjZaTQT/KzIiWuzemjjIYSaoE YKdK9U8FE02EC8Qw34II1HZqhhu4J0IpUBBX+vDtf+1YrSDNRLXpaXWiJxHNTxa73zbD q12tTFA+O7Og/RtXfUlk3HJFqKgB67Ix6j7TCEDkGsu2tyatdhQ20yVde+QZByE9JmX/ OJw0AT+IkbAoGw7yLiIUyIfqNhmSiypOF9uXHP9OdPSdrworr7cEzIQrQbSi7ruFyjOY x5filFofp0zexnGOW/73hj11ajAxSkzdGqY0oaexv1CTYXLJOle8V9Hmjb6xAHHlS/YP kGXA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id v1si6420356ejf.162.2021.01.10.23.47.20; Sun, 10 Jan 2021 23:47:43 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=mediatek.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727812AbhAKHpP (ORCPT + 99 others); Mon, 11 Jan 2021 02:45:15 -0500 Received: from mailgw02.mediatek.com ([210.61.82.184]:51743 "EHLO mailgw02.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1727741AbhAKHpO (ORCPT ); Mon, 11 Jan 2021 02:45:14 -0500 X-UUID: 584956d696384058bac1e0c94be1a941-20210111 X-UUID: 584956d696384058bac1e0c94be1a941-20210111 Received: from mtkexhb01.mediatek.inc [(172.21.101.102)] by mailgw02.mediatek.com (envelope-from ) (Cellopoint E-mail Firewall v4.1.14 Build 0819 with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1045679818; Mon, 11 Jan 2021 15:44:07 +0800 Received: from mtkcas11.mediatek.inc (172.21.101.40) by mtkmbs05n1.mediatek.inc (172.21.101.15) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 11 Jan 2021 15:44:05 +0800 Received: from localhost.localdomain (10.17.3.153) by mtkcas11.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 11 Jan 2021 15:44:05 +0800 From: Yongqiang Niu To: CK Hu , Philipp Zabel , Rob Herring , Matthias Brugger CC: David Airlie , Daniel Vetter , Mark Rutland , , , , , , , Hsin-Yi Wang , Yongqiang Niu Subject: [PATCH v3, 11/15] drm/mediatek: fix aal size config Date: Mon, 11 Jan 2021 15:43:47 +0800 Message-ID: <1610351031-21133-12-git-send-email-yongqiang.niu@mediatek.com> X-Mailer: git-send-email 1.8.1.1.dirty In-Reply-To: <1610351031-21133-1-git-send-email-yongqiang.niu@mediatek.com> References: <1610351031-21133-1-git-send-email-yongqiang.niu@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org the orginal setting is not correct, fix it follow hardware data sheet. if keep this error setting, mt8173/mt8183 display ok but mt8192 display abnormal. Fixes: 0664d1392c26 (drm/mediatek: Add AAL engine basic function) Signed-off-by: Yongqiang Niu --- drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c index fc01fea..6081800 100644 --- a/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_ddp_comp.c @@ -174,7 +174,7 @@ static void mtk_aal_config(struct mtk_ddp_comp *comp, unsigned int w, unsigned int h, unsigned int vrefresh, unsigned int bpc, struct cmdq_pkt *cmdq_pkt) { - mtk_ddp_write(cmdq_pkt, h << 16 | w, comp, DISP_AAL_SIZE); + mtk_ddp_write(cmdq_pkt, w << 16 | h, comp, DISP_AAL_SIZE); } static void mtk_aal_start(struct mtk_ddp_comp *comp) -- 1.8.1.1.dirty