Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 11 Jan 2021 09:28:29 +0100
Message-ID: <s5hh7nnvpw2.wl-tiwai@suse.de>
From:   Takashi Iwai <tiwai@suse.de>
To:     Davidlohr Bueso <dave@stgolabs.net>
Cc:     balbi@kernel.org, gregkh@linuxfoundation.org,
        linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        Davidlohr Bueso <dbueso@suse.de>
Subject: Re: [PATCH] usb/gadget: f_midi: Replace tasklet with work
In-Reply-To: <20210111042855.73289-1-dave@stgolabs.net>
References: <20210111042855.73289-1-dave@stgolabs.net>
User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI/1.14.6 (Maruoka)
 FLIM/1.14.9 (=?UTF-8?B?R29qxY0=?=) APEL/10.8 Emacs/25.3
 (x86_64-suse-linux-gnu) MULE/6.0 (HANACHIRUSATO)
MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka")
Content-Type: text/plain; charset=US-ASCII
Precedence: bulk

On Mon, 11 Jan 2021 05:28:55 +0100,
Davidlohr Bueso wrote:
> 
> Currently a tasklet is used to transmit input substream buffer
> data. However, tasklets have long been deprecated as being too
> heavy on the system by running in irq context - and this is not
> a performance critical path. If a higher priority process wants
> to run, it must wait for the tasklet to finish before doing so.
> 
> Deferring work to a workqueue and executing in process context
> should be fine considering the callback already does
> f_midi_do_transmit() under the transmit_lock and thus changes in
> semantics are ok regarding concurrency - tasklets being serialized
> against itself.
> 
> Cc: Takashi Iwai <tiwai@suse.de>
> Signed-off-by: Davidlohr Bueso <dbueso@suse.de>

The patch looks good to me.
Reviewed-by: Takashi Iwai <tiwai@suse.de>


BTW, now I found that the driver doesn't have the cancel call for
tasklet or work at the unbind.  Practically seen it's no big problem,
but its lack is a bait for syzbot.  We may need to just call
cancel_work_sync() somewhere, probably at f_midi_drop_out_substreams()
or f_midi_disable(), but it can be in another patch.


thanks,

Takashi