Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: T/kk4JeuL1+HU2yQysOGf3fwTRK1nDvsWmUL4sOxawzqh2mUesTFTB5E0e8PTzy/SPmHFqe+aF
 wpcRTzN+0MDEX71ml9UWQ3hLyT2VNh1F3j9fObXLGiE8rTptlXNY8WHW08DV3IFVODKGoxqNSn
 2cbDdw9oiI+0Me27o6opUq+60scChxVwUfPOY8u1DvoFoUhUA1r62F1OCfykArDCiVGLDi7Q2C
 57bhw/g/FGXkkQ456RyZ0iGfJ3j58+1Gn8ZJGN6B+Fkpy/6gG9Pqb7d997P4rvfp7kYrW02SN7
 Qoo=
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Jaegeuk Kim <jaegeuk@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "kernel-team@android.com" <kernel-team@android.com>
CC:     "cang@codeaurora.org" <cang@codeaurora.org>,
        "alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        Jaegeuk Kim <jaegeuk@google.com>
Subject: RE: [PATCH v2] scsi: ufs: WB is not allowed in RPMB_LUN
Thread-Topic: [PATCH v2] scsi: ufs: WB is not allowed in RPMB_LUN
Thread-Index: AQHW5/Z6dZTrRwC4TUaHBZ6S2NGpXaoiI5hA
Date:   Mon, 11 Jan 2021 09:20:32 +0000
Message-ID: <DM6PR04MB657566F1BB8C808EFBF9FBB9FCAB0@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <20210111084756.1810924-1-jaegeuk@kernel.org>
In-Reply-To: <20210111084756.1810924-1-jaegeuk@kernel.org>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: f24eb6b3-62b3-4b92-7e29-08d8b6122549
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jan 2021 09:20:32.3050
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: kRXCal/gMW39/q+D/moqbOmYzGgi4thazTHqvu6xTIy4Y8zIK+YA998Bpvx7SqK++5Uz6ADigX/gliKRNUAfcg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR04MB1258
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>  static inline bool ufs_is_valid_unit_desc_lun(struct ufs_dev_info *dev_i=
nfo,
> -               u8 lun)
> +               u8 lun, u8 param_offset)
>  {
>         if (!dev_info || !dev_info->max_lu_supported) {
>                 pr_err("Max General LU supported by UFS isn't initialized=
\n");
>                 return false;
>         }
> -
> +       /* WB is not allowed in RPMB_WLUN */
/* wb is only allowed to either a sha*/
> +       if (param_offset =3D=3D UNIT_DESC_PARAM_WB_BUF_ALLOC_UNITS)
> +               return lun < dev_info->max_lu_supported;
I think here you should use UFS_UPIU_MAX_WB_LUN_ID and not dev_info->max_lu=
_supported.

Thanks,
Avri