Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Pawel Laszczak <pawell@cadence.com>
To:     "peter.chen@nxp.com" <peter.chen@nxp.com>
CC:     "rogerq@ti.com" <rogerq@ti.com>,
        "a-govindraju@ti.com" <a-govindraju@ti.com>,
        "nsekhar@ti.com" <nsekhar@ti.com>,
        "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Rahul Kumar <kurahul@cadence.com>
Subject: RE: [PATCH] usb: cdns3: Adds missing __iomem markers
Thread-Topic: [PATCH] usb: cdns3: Adds missing __iomem markers
Thread-Index: AQHW0hfCdxF+FADJ7kiWsaLMH3xpo6oiUKOg
Date:   Mon, 11 Jan 2021 09:20:31 +0000
Message-ID: <BYAPR07MB53815F102C9C56CBC7AAD89FDDAB0@BYAPR07MB5381.namprd07.prod.outlook.com>
References: <20201214125043.29710-1-pawell@cadence.com>
In-Reply-To: <20201214125043.29710-1-pawell@cadence.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 992e1c40-50ec-43d3-e770-08d8b61224f4
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jan 2021 09:20:31.7762
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: d36035c5-6ce6-4662-a3dc-e762e61ae4c9
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: WHMw2CKLvfQSOOfGMx21+x7me0RFEl0DO7CglAYVwSGACT2TUdkmeeGxVAL+KXgKExFty6rvmd16Zqom3G/yEFPBKbRhEISs0GipV1gRABQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR07MB7927
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343,18.0.737
 definitions=2021-01-09_13:2021-01-07,2021-01-09 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_check_notspam policy=outbound_check score=0 spamscore=0
 phishscore=0 clxscore=1015 mlxscore=0 malwarescore=0 bulkscore=0
 suspectscore=0 adultscore=0 priorityscore=1501 impostorscore=0
 lowpriorityscore=0 mlxlogscore=690 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.12.0-2009150000 definitions=main-2101110056
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Peter,

What about this patch, can you apply it into for-usb-next ?

Thanks
Pawel

>
>Patch adds missing __iomem markers in core.h file
>and makes some changes in drd.c file related with
>these markers.
>
>The lack of __iomem has reported by sparse checker
>on parsic architecture.
>
>Signed-off-by: Pawel Laszczak <pawell@cadence.com>
>Reported-by: kernel test robot <lkp@intel.com>
>---
> drivers/usb/cdns3/core.h | 12 ++++++------
> drivers/usb/cdns3/drd.c  | 12 ++++++------
> 2 files changed, 12 insertions(+), 12 deletions(-)
>
>diff --git a/drivers/usb/cdns3/core.h b/drivers/usb/cdns3/core.h
>index f8e350cef699..bfa39795208e 100644
>--- a/drivers/usb/cdns3/core.h
>+++ b/drivers/usb/cdns3/core.h
>@@ -86,12 +86,12 @@ struct cdns {
> 	struct resource			xhci_res[CDNS_XHCI_RESOURCES_NUM];
> 	struct cdns3_usb_regs __iomem	*dev_regs;
>
>-	struct resource			otg_res;
>-	struct cdns3_otg_legacy_regs	*otg_v0_regs;
>-	struct cdns3_otg_regs		*otg_v1_regs;
>-	struct cdnsp_otg_regs		*otg_cdnsp_regs;
>-	struct cdns_otg_common_regs	*otg_regs;
>-	struct cdns_otg_irq_regs	*otg_irq_regs;
>+	struct resource				otg_res;
>+	struct cdns3_otg_legacy_regs __iomem	*otg_v0_regs;
>+	struct cdns3_otg_regs __iomem		*otg_v1_regs;
>+	struct cdnsp_otg_regs __iomem		*otg_cdnsp_regs;
>+	struct cdns_otg_common_regs __iomem	*otg_regs;
>+	struct cdns_otg_irq_reg __iomem		*otg_irq_regs;
> #define CDNS3_CONTROLLER_V0	0
> #define CDNS3_CONTROLLER_V1	1
> #define CDNSP_CONTROLLER_V2	2
>diff --git a/drivers/usb/cdns3/drd.c b/drivers/usb/cdns3/drd.c
>index 605a413db727..0701853b501c 100644
>--- a/drivers/usb/cdns3/drd.c
>+++ b/drivers/usb/cdns3/drd.c
>@@ -27,7 +27,7 @@
>  */
> static int cdns_set_mode(struct cdns *cdns, enum usb_dr_mode mode)
> {
>-	u32 __iomem *override_reg;
>+	void __iomem  *override_reg;
> 	u32 reg;
>
> 	switch (mode) {
>@@ -406,7 +406,7 @@ int cdns_drd_init(struct cdns *cdns)
> 		cdns->otg_v1_regs =3D NULL;
> 		cdns->otg_cdnsp_regs =3D NULL;
> 		cdns->otg_regs =3D regs;
>-		cdns->otg_irq_regs =3D (struct cdns_otg_irq_regs *)
>+		cdns->otg_irq_regs =3D (struct cdns_otg_irq_regs __iomem  *)
> 				     &cdns->otg_v0_regs->ien;
> 		writel(1, &cdns->otg_v0_regs->simulate);
> 		dev_dbg(cdns->dev, "DRD version v0 (%08x)\n",
>@@ -416,14 +416,14 @@ int cdns_drd_init(struct cdns *cdns)
> 		cdns->otg_v1_regs =3D regs;
> 		cdns->otg_cdnsp_regs =3D regs;
>
>-		cdns->otg_regs =3D (void *)&cdns->otg_v1_regs->cmd;
>+		cdns->otg_regs =3D (void __iomem *)&cdns->otg_v1_regs->cmd;
>
>-		if (cdns->otg_cdnsp_regs->did =3D=3D OTG_CDNSP_DID) {
>-			cdns->otg_irq_regs =3D (struct cdns_otg_irq_regs *)
>+		if (readl(cdns->otg_cdnsp_regs->did) =3D=3D OTG_CDNSP_DID) {
>+			cdns->otg_irq_regs =3D (struct cdns_otg_irq_regs __iomem *)
> 					      &cdns->otg_cdnsp_regs->ien;
> 			cdns->version  =3D CDNSP_CONTROLLER_V2;
> 		} else {
>-			cdns->otg_irq_regs =3D (struct cdns_otg_irq_regs *)
>+			cdns->otg_irq_regs =3D (struct cdns_otg_irq_regs __iomem *)
> 					      &cdns->otg_v1_regs->ien;
> 			writel(1, &cdns->otg_v1_regs->simulate);
> 			cdns->version  =3D CDNS3_CONTROLLER_V1;
>--
>2.17.1