Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp2144077pxb; Mon, 11 Jan 2021 01:58:36 -0800 (PST) X-Google-Smtp-Source: ABdhPJwXOE7a3Qj11adSX4QqdYEMie6abcZuIfdmYQRtoaT5jP+xhKd/o/FHax55ac3U5Brln8kk X-Received: by 2002:a17:906:4950:: with SMTP id f16mr10813764ejt.453.1610359116142; Mon, 11 Jan 2021 01:58:36 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610359116; cv=none; d=google.com; s=arc-20160816; b=oYViiASWTZ1j4l36E6fQEePnGZmsuzP2gzU8/xmgOxCSlnei1dQHmH/yikQPd49DOO 2ooMtr4KCsuHZIffTYPY2ouVktitA5+xljBh37MrQtfoQpx2K9HY6Ls5AyJNlQYyMopd lSdKMvpRzbJmgUrnjcA/kX4gPrcWQBSrGhRkAz2sJiSUa+/ynAFz7ZVX1uT5EZ9Edx/K ebSlTflS7XYs+CInHg0OFX13xthtoXi2ukOvqV8vWjHvQtxht+SyaDSIs8toDW6YW0jm dRLsx2WJeoPT2ZUOIEHqN82NaiwQnAdrXmcOxCZBkSYJWDv/wvayrXToRjT+lPi+pcLu 5fug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=bXbYb9uKpH6JIc9vtO0B4fv1+r4EsdWRffb8ZRrau8Q=; b=X49zHf9oxsPK5spn5Y6GMPYm2b5ScRmTuNPL/pbPwXA2o13OyV6WEPRGk/4j8x65Cm uCTroxjfOFOYPRpz36uwYw+GDZz7rq0b/GwqH8Trk601iNBYoitoJPpZFTz4ur2vO7kd OuNHWw1UwljWUHwWqUuX0nKe1EvqVTFQyxzyCrOq8zcJ1BJwD/RihCUtrAbrc9ymnFep lrXp+EpgWeJoWB5IWTp3Q2pMnSrk7Qkz9LTSxfbYY9dMiPs55Yl0lgVHsyIhzFthusRZ V763XTS0lX19sp50aTb+zzwnEhPbb3GoWVlqNn8jHZ/04KqNo2cqazZvKPm1HjwKr3vB k7Vw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id p22si5665571edt.391.2021.01.11.01.58.11; Mon, 11 Jan 2021 01:58:36 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728691AbhAKJzl (ORCPT + 99 others); Mon, 11 Jan 2021 04:55:41 -0500 Received: from out30-57.freemail.mail.aliyun.com ([115.124.30.57]:33284 "EHLO out30-57.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725843AbhAKJzl (ORCPT ); Mon, 11 Jan 2021 04:55:41 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R211e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04420;MF=abaci-bugfix@linux.alibaba.com;NM=1;PH=DS;RN=6;SR=0;TI=SMTPD_---0ULL6orQ_1610358890; Received: from j63c13417.sqa.eu95.tbsite.net(mailfrom:abaci-bugfix@linux.alibaba.com fp:SMTPD_---0ULL6orQ_1610358890) by smtp.aliyun-inc.com(127.0.0.1); Mon, 11 Jan 2021 17:54:55 +0800 From: YANG LI To: kdasu.kdev@gmail.com Cc: bcm-kernel-feedback-list@broadcom.com, broonie@kernel.org, linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, YANG LI Subject: [PATCH] spi: spi-bcm-qspi: style: Simplify bool comparison Date: Mon, 11 Jan 2021 17:54:48 +0800 Message-Id: <1610358888-88876-1-git-send-email-abaci-bugfix@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fix the following coccicheck warning: ./drivers/spi/spi-bcm-qspi.c:884:5-34: WARNING: Comparison to bool Signed-off-by: YANG LI Reported-by: Abaci Robot --- drivers/spi/spi-bcm-qspi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-bcm-qspi.c b/drivers/spi/spi-bcm-qspi.c index c028446..d28d7bd 100644 --- a/drivers/spi/spi-bcm-qspi.c +++ b/drivers/spi/spi-bcm-qspi.c @@ -881,7 +881,7 @@ static int bcm_qspi_bspi_exec_mem_op(struct spi_device *spi, * when using flex mode we need to send * the upper address byte to bspi */ - if (bcm_qspi_bspi_ver_three(qspi) == false) { + if (!bcm_qspi_bspi_ver_three(qspi)) { addr = from & 0xff000000; bcm_qspi_write(qspi, BSPI, BSPI_BSPI_FLASH_UPPER_ADDR_BYTE, addr); @@ -892,7 +892,7 @@ static int bcm_qspi_bspi_exec_mem_op(struct spi_device *spi, else addr = from & 0x00ffffff; - if (bcm_qspi_bspi_ver_three(qspi) == true) + if (bcm_qspi_bspi_ver_three(qspi)) addr = (addr + 0xc00000) & 0xffffff; /* -- 1.8.3.1