Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 11 Jan 2021 01:59:01 -0800
From:   Jaegeuk Kim <jaegeuk@kernel.org>
To:     Avri Altman <Avri.Altman@wdc.com>
Cc:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "kernel-team@android.com" <kernel-team@android.com>,
        "cang@codeaurora.org" <cang@codeaurora.org>,
        "alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>
Subject: Re: [PATCH v2] scsi: ufs: WB is not allowed in RPMB_LUN
Message-ID: <X/whZfoRQvEncfUS@google.com>
References: <20210111084756.1810924-1-jaegeuk@kernel.org>
 <DM6PR04MB657566F1BB8C808EFBF9FBB9FCAB0@DM6PR04MB6575.namprd04.prod.outlook.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <DM6PR04MB657566F1BB8C808EFBF9FBB9FCAB0@DM6PR04MB6575.namprd04.prod.outlook.com>
Precedence: bulk

On 01/11, Avri Altman wrote:
> >  static inline bool ufs_is_valid_unit_desc_lun(struct ufs_dev_info *dev_info,
> > -               u8 lun)
> > +               u8 lun, u8 param_offset)
> >  {
> >         if (!dev_info || !dev_info->max_lu_supported) {
> >                 pr_err("Max General LU supported by UFS isn't initialized\n");
> >                 return false;
> >         }
> > -
> > +       /* WB is not allowed in RPMB_WLUN */
> /* wb is only allowed to either a sha*/
> > +       if (param_offset == UNIT_DESC_PARAM_WB_BUF_ALLOC_UNITS)
> > +               return lun < dev_info->max_lu_supported;
> I think here you should use UFS_UPIU_MAX_WB_LUN_ID and not dev_info->max_lu_supported.

Ok, sending v3.

> 
> Thanks,
> Avri