Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
IronPort-SDR: EdK7O3AQaCp97eYmyrOzC0MQe21E1hSlL6FqnVaUV6Z4nnsqSSzkouty+c0Akk3r4rEqVfYrQu
 Go93onDnDmPc58Bu33BcpxwefnfpIO89YzKJnR99IeDGmxfvffQG1cBtmpLYdkz5amGawn6U1K
 aDHHvQIYgwqUUxYiHcTbd0fDQ3zpFBlfLMs9CifZwqz9xa5sEboxBXVyeiFuWD1Pxib04kijZ0
 OMF1caHUtfEqbRa8pF66nrgpymVRXSk099cMKel3GR13eRa7T+TMGQOiZT5BBPIGpU3YG9yEND
 AU8=
From:   Avri Altman <Avri.Altman@wdc.com>
To:     Jaegeuk Kim <jaegeuk@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "kernel-team@android.com" <kernel-team@android.com>
CC:     "cang@codeaurora.org" <cang@codeaurora.org>,
        "alim.akhtar@samsung.com" <alim.akhtar@samsung.com>,
        "bvanassche@acm.org" <bvanassche@acm.org>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>,
        "stanley.chu@mediatek.com" <stanley.chu@mediatek.com>,
        Jaegeuk Kim <jaegeuk@google.com>
Subject: RE: [PATCH v3] scsi: ufs: WB is only available on LUN #0 to #7
Thread-Topic: [PATCH v3] scsi: ufs: WB is only available on LUN #0 to #7
Thread-Index: AQHW6AB4DC+JktXf6kWECxPVufZm26oiMutw
Date:   Mon, 11 Jan 2021 10:07:50 +0000
Message-ID: <DM6PR04MB6575AE5E44E55342A7A66F4AFCAB0@DM6PR04MB6575.namprd04.prod.outlook.com>
References: <20210111095927.1830311-1-jaegeuk@kernel.org>
In-Reply-To: <20210111095927.1830311-1-jaegeuk@kernel.org>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 4ca61204-3379-4744-6be3-08d8b618c0db
X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jan 2021 10:07:50.2676
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: BCrCWFSwnZXzHyGM5FdVnV6u2VreZKPkdCQt70xH9irb3MA4tkXd47Fj1CUbT/bi3H4pSK1J+GwG8EbQewcEVQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR04MB4155
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

>=20
>=20
> From: Jaegeuk Kim <jaegeuk@google.com>
>=20
> Kernel stack violation when getting unit_descriptor/wb_buf_alloc_units fr=
om
> rpmb lun. The reason is the unit descriptor length is different per LU.
>=20
> The lengh of Normal LU is 45, while the one of rpmb LU is 35.
>=20
> int ufshcd_read_desc_param(struct ufs_hba *hba, ...)
> {
>         param_offset=3D41;
>         param_size=3D4;
>         buff_len=3D45;
>         ...
>         buff_len=3D35 by rpmb LU;
>=20
>         if (is_kmalloc) {
>                 /* Make sure we don't copy more data than available */
>                 if (param_offset + param_size > buff_len)
>                         param_size =3D buff_len - param_offset;
>                         --> param_size =3D 250;
>                 memcpy(param_read_buf, &desc_buf[param_offset], param_siz=
e);
>                 --> memcpy(param_read_buf, desc_buf+41, 250);
>=20
> [  141.868974][ T9174] Kernel panic - not syncing: stack-protector: Kerne=
l
> stack is corrupted in: wb_buf_alloc_units_show+0x11c/0x11c
>         }
> }
>=20
> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Reviewed-by: Avri Altman <avri.altman@wdc.com>