Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2 2/8] serial: stm32: fix code cleaning warnings and
 checks
To:     Erwan Le Ray <erwan.leray@foss.st.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Rob Herring <robh+dt@kernel.org>,
        Maxime Coquelin <mcoquelin.stm32@gmail.com>,
        Alexandre Torgue <alexandre.torgue@foss.st.com>
Cc:     linux-serial@vger.kernel.org, devicetree@vger.kernel.org,
        linux-stm32@st-md-mailman.stormreply.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        Fabrice Gasnier <fabrice.gasnier@foss.st.com>,
        Valentin Caron <valentin.caron@foss.st.com>
References: <20210106162203.28854-1-erwan.leray@foss.st.com>
 <20210106162203.28854-3-erwan.leray@foss.st.com>
From:   Jiri Slaby <jirislaby@kernel.org>
Message-ID: <72c81157-4bd1-6a3e-2415-92a2fb29ab6d@kernel.org>
Date:   Mon, 11 Jan 2021 10:58:12 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.6.0
MIME-Version: 1.0
In-Reply-To: <20210106162203.28854-3-erwan.leray@foss.st.com>
Content-Type: text/plain; charset=iso-8859-2; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 06. 01. 21, 17:21, Erwan Le Ray wrote:
> --- a/drivers/tty/serial/stm32-usart.c
> +++ b/drivers/tty/serial/stm32-usart.c
...
> @@ -973,18 +971,17 @@ static int stm32_init_port(struct stm32_port *stm32port,
>   	struct resource *res;
>   	int ret;
>   
> +	ret = platform_get_irq(pdev, 0);
> +	if (ret <= 0)
> +		return ret ? : -ENODEV;
> +
>   	port->iotype	= UPIO_MEM;
>   	port->flags	= UPF_BOOT_AUTOCONF;
>   	port->ops	= &stm32_uart_ops;
>   	port->dev	= &pdev->dev;
>   	port->fifosize	= stm32port->info->cfg.fifosize;
>   	port->has_sysrq = IS_ENABLED(CONFIG_SERIAL_STM32_CONSOLE);
> -
> -	ret = platform_get_irq(pdev, 0);
> -	if (ret <= 0)
> -		return ret ? : -ENODEV;
>   	port->irq = ret;

I would move this set from ret above too. Or introduce a new variable, 
e.g. "irq".

thanks,
-- 
js
suse labs