Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1608779989-9641-1-git-send-email-gene.chen.richtek@gmail.com> <04b06a6a4020212c4ae65bea9685afccc90c6dee.camel@fi.rohmeurope.com>
In-Reply-To: <04b06a6a4020212c4ae65bea9685afccc90c6dee.camel@fi.rohmeurope.com>
From:   Gene Chen <gene.chen.richtek@gmail.com>
Date:   Mon, 11 Jan 2021 18:46:01 +0800
Message-ID: <CAE+NS373aYm9T_mJd23PXvGRqUB9QaEC-T8=zku_OmawQRpGFw@mail.gmail.com>
Subject: Re: [PATCH resend] dt-bindings: mfd: mediatek: Add bindings for
 MT6360 PMIC
To:     "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>
Cc:     "matthias.bgg@gmail.com" <matthias.bgg@gmail.com>,
        "robh+dt@kernel.org" <robh+dt@kernel.org>,
        "shufan_lee@richtek.com" <shufan_lee@richtek.com>,
        "cy_huang@richtek.com" <cy_huang@richtek.com>,
        "gene_chen@richtek.com" <gene_chen@richtek.com>,
        "lee.jones@linaro.org" <lee.jones@linaro.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "Wilma.Wu@mediatek.com" <Wilma.Wu@mediatek.com>,
        "linux-mediatek@lists.infradead.org" 
        <linux-mediatek@lists.infradead.org>,
        "benjamin.chao@mediatek.com" <benjamin.chao@mediatek.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Vaittinen, Matti <Matti.Vaittinen@fi.rohmeurope.com> =E6=96=BC 2021=E5=B9=
=B41=E6=9C=8811=E6=97=A5 =E9=80=B1=E4=B8=80 =E4=B8=8B=E5=8D=885:13=E5=AF=AB=
=E9=81=93=EF=BC=9A
>
> Hello Peeps,
>
> On Thu, 2020-12-24 at 11:19 +0800, Gene Chen wrote:
> > From: Gene Chen <gene_chen@richtek.com>
> >
> > Add bindings for MT6360 PMIC
> >
> > Signed-off-by: Gene Chen <gene_chen@richtek.com>
> > ---
> >  Documentation/devicetree/bindings/mfd/mt6360.yaml | 69
> > +++++++++++++++++++++++
> >  1 file changed, 69 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/mfd/mt6360.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/mt6360.yaml
> > b/Documentation/devicetree/bindings/mfd/mt6360.yaml
> > new file mode 100644
> > index 0000000..2781c31
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mfd/mt6360.yaml
> > @@ -0,0 +1,69 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/mfd/mt6360.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: MT6360 PMIC from MediaTek Integrated
> > +
> > +maintainers:
> > +  - Gene Chen <gene_chen@richtek.com>
> > +
> > +description: |
> > +  MT6360 is a PMIC device with the following sub modules.
> > +  It is interfaced to host controller using I2C interface.
> > +
> > +  This document describes the binding for PMIC device and its sub
> > module.
> > +
> > +properties:
> > +  compatible:
> > +    const: mediatek,mt6360
> > +
> > +  reg:
> > +    description:
> > +      I2C device address.
> > +    maxItems: 1
> > +
> > +  wakeup-source: true
> > +
> > +  interrupts:
> > +    maxItems: 1
> > +
> > +  interrupt-names:
> > +      enum:
> > +        - IRQB
> > +
> > +  interrupt-controller: true
> > +
> > +  "#interrupt-cells":
> > +    const: 1
> > +    description:
> > +      The first cell is the IRQ number.
> > +
> > +required:
> > +  - compatible
> > +  - reg
> > +  - interrupts
> > +  - interrupt-controller
> > +  - "#interrupt-cells"
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    #include <dt-bindings/interrupt-controller/irq.h>
> > +    #include <dt-bindings/regulator/mediatek,mt6360-regulator.h>
> > +    i2c {
> > +        #address-cells =3D <1>;
> > +        #size-cells =3D <0>;
> > +
> > +        mt6360@34 {
> > +            compatible =3D "mediatek,mt6360";
> > +            reg =3D <0x34>;
> > +            wakeup-source;
> > +            interrupts-extended =3D <&gpio26 0 IRQ_TYPE_LEVEL_LOW>;
> > +            interrupt-names =3D "IRQB";
> > +            interrupt-controller;
> > +            #interrupt-cells =3D <1>;
>
> Out of the curiosity - is this the complete node? I would assume some
> sub-devices like regulators here?
>

After all sub-devices module review done, I will add new patch to add
reference description.
e.g. max77650.yaml
leds:
  $ref: ../leds/leds-max77650.yaml

> > +        };
> > +    };
>