Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932113AbWIJWYx (ORCPT ); Sun, 10 Sep 2006 18:24:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932137AbWIJWYw (ORCPT ); Sun, 10 Sep 2006 18:24:52 -0400 Received: from electric-eye.fr.zoreil.com ([213.41.134.224]:15325 "EHLO fr.zoreil.com") by vger.kernel.org with ESMTP id S932113AbWIJWYv (ORCPT ); Sun, 10 Sep 2006 18:24:51 -0400 Date: Mon, 11 Sep 2006 00:21:09 +0200 From: Francois Romieu To: Arnd Bergmann Cc: Misha Tomushev , jgarzik@pobox.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] VIOC: New Network Device Driver Message-ID: <20060910222109.GA22386@electric-eye.fr.zoreil.com> References: <000501c6d85c$08a352f0$8301a8c0@calvados> <200609102339.25621.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200609102339.25621.arnd@arndb.de> User-Agent: Mutt/1.4.2.1i X-Organisation: Land of Sunshine Inc. Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 440 Lines: 16 Arnd Bergmann : [...] > A few comments on coding style: Add: - use netdev_priv() - use DMA_{32/64}_BIT_MASK in place of private #define - turn some define into enum ? -- Ueimor - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/