Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20210111123518.30438-1-matthias.bgg@kernel.org>
In-Reply-To: <20210111123518.30438-1-matthias.bgg@kernel.org>
From:   Gene Chen <gene.chen.richtek@gmail.com>
Date:   Mon, 11 Jan 2021 21:05:41 +0800
Message-ID: <CAE+NS35Br8jgLfii=VPjFx+m+9=a=EQKYyoQMAyd7Zdo0K6n+A@mail.gmail.com>
Subject: Re: [PATCH] mfd: mt6360: Fix MFD cell names and compatibles
To:     matthias.bgg@kernel.org
Cc:     Lee Jones <lee.jones@linaro.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Gene Chen <gene_chen@richtek.com>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-arm Mailing List <linux-arm-kernel@lists.infradead.org>,
        Matthias Brugger <mbrugger@suse.com>,
        ChiYuan Huang <cy_huang@richtek.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Heikki Krogerus <heikki.krogerus@linux.intel.com>,
        Jonathan Cameron <Jonathan.Cameron@huawei.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

Hi Lee,

This change exists in [PATCH v7 03/11] mfd: mt6360: Indicate sub-dev
compatible name by using "-".
Does patch v7 also merge together to mfd-next?

<matthias.bgg@kernel.org> =E6=96=BC 2021=E5=B9=B41=E6=9C=8811=E6=97=A5 =E9=
=80=B1=E4=B8=80 =E4=B8=8B=E5=8D=888:35=E5=AF=AB=E9=81=93=EF=BC=9A
>
> From: Matthias Brugger <mbrugger@suse.com>
>
> MFD cell names and compatibles use '_' instead of '-', which is common
> practice for names and the standard for DT compatibles.
> This will also fix the probing for the drivers already implemented
> (mt6360-adc and mt6360-tcpc).
>
> Fixes: 7edd363421da ("mfd: Add support for PMIC MT6360")
> Fixes: 1f4877218f7e ("iio: adc: mt6360: Add ADC driver for MT6360")
> Fixes: e1aefcdd394f ("usb typec: mt6360: Add support for mt6360 Type-C dr=
iver")
> Signed-off-by: Matthias Brugger <mbrugger@suse.com>
>
> ---
>
>  drivers/mfd/mt6360-core.c | 24 ++++++++++++------------
>  1 file changed, 12 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/mfd/mt6360-core.c b/drivers/mfd/mt6360-core.c
> index 4661c1b29a72..14e649ffe50f 100644
> --- a/drivers/mfd/mt6360-core.c
> +++ b/drivers/mfd/mt6360-core.c
> @@ -292,18 +292,18 @@ static const struct resource mt6360_ldo_resources[]=
 =3D {
>  };
>
>  static const struct mfd_cell mt6360_devs[] =3D {
> -       OF_MFD_CELL("mt6360_adc", mt6360_adc_resources,
> -                   NULL, 0, 0, "mediatek,mt6360_adc"),
> -       OF_MFD_CELL("mt6360_chg", mt6360_chg_resources,
> -                   NULL, 0, 0, "mediatek,mt6360_chg"),
> -       OF_MFD_CELL("mt6360_led", mt6360_led_resources,
> -                   NULL, 0, 0, "mediatek,mt6360_led"),
> -       OF_MFD_CELL("mt6360_pmic", mt6360_pmic_resources,
> -                   NULL, 0, 0, "mediatek,mt6360_pmic"),
> -       OF_MFD_CELL("mt6360_ldo", mt6360_ldo_resources,
> -                   NULL, 0, 0, "mediatek,mt6360_ldo"),
> -       OF_MFD_CELL("mt6360_tcpc", NULL,
> -                   NULL, 0, 0, "mediatek,mt6360_tcpc"),
> +       OF_MFD_CELL("mt6360-adc", mt6360_adc_resources,
> +                   NULL, 0, 0, "mediatek,mt6360-adc"),
> +       OF_MFD_CELL("mt6360-chg", mt6360_chg_resources,
> +                   NULL, 0, 0, "mediatek,mt6360-chg"),
> +       OF_MFD_CELL("mt6360-led", mt6360_led_resources,
> +                   NULL, 0, 0, "mediatek,mt6360-led"),
> +       OF_MFD_CELL("mt6360-pmic", mt6360_pmic_resources,
> +                   NULL, 0, 0, "mediatek,mt6360-pmic"),
> +       OF_MFD_CELL("mt6360-ldo", mt6360_ldo_resources,
> +                   NULL, 0, 0, "mediatek,mt6360-ldo"),
> +       OF_MFD_CELL("mt6360-tcpc", NULL,
> +                   NULL, 0, 0, "mediatek,mt6360-tcpc"),
>  };
>
>  static const unsigned short mt6360_slave_addr[MT6360_SLAVE_MAX] =3D {
> --
> 2.29.2
>