Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp2260397pxb; Mon, 11 Jan 2021 05:25:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJxV835c1O9wrYb7dXQLX+WQfoviezBasNzsBfggwYFmSowlh73Yp5vajn9KZvUWXMOJUmJR X-Received: by 2002:a50:9354:: with SMTP id n20mr14518779eda.231.1610371559254; Mon, 11 Jan 2021 05:25:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610371559; cv=none; d=google.com; s=arc-20160816; b=j+/q9LkwKjX8x/nQKlmB9AJJCARicqdbrN2E93nSjSYeAzZqhF/TpVj9ZW0V+Ar5NZ r46VGCOyp+DFUGCbu6XF1jC3ZfDk8rxobnTha+UrmJi0Rvu2WaXDSalBVYaiqtaj0Ln7 HJVF1TKIW1+6RhDXc9rL/n3K5Cgs1xpm+YBn7nhNK/LdRI11wk78gizryPOZbK0W+SB/ Bq2OmnyN1OSakQcLuVesNEVaeAlZL0chKBMZjE+Ow9m+Rznz1uMiec6y+Ix+El/XeLFD L70YFWBdnqKiX8kO8oUXB9YyI2jz7xEpLKDceDrFbQODjNhNlFSZ3z33dVG0tzSfiYe2 wcTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=qEeRNPaxfsAvh9/22RCdKNf0t6bJH57FFquCVlygeQU=; b=1C7+XVVRO3agD2Fc+234ARcl95iEPRSvxtz56jf7MDOnrnm+8uSqn0uf0fjCg24m2G ZDNHyE6bu/ZEPoNqdW6KFvenzfDud4oZq8DY6nAinC9X9nKj98me/TRRtXHolTELeNGk ZmiIJiOFdAkNzMCeLX3lIrP6CymrFTelFI3gzMMINYcq9htJIcQQTSBIyoWAbatZtnJW kVJaUBWrU4Q5V8UusNFBtpbvtO0gFWNA3jkLRy2R20338SlVLrXaiG0dFFKwh5g1DB0x q6j0rLJhhEYJOpWrf++XQd68X+NUoTtCdhQd8LU21K9q534x6/Hc4RlDQ3D4q4G37Oxz EVXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=xVa2B2ay; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l2si6929695ede.232.2021.01.11.05.25.35; Mon, 11 Jan 2021 05:25:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=xVa2B2ay; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731366AbhAKNLS (ORCPT + 99 others); Mon, 11 Jan 2021 08:11:18 -0500 Received: from mail.kernel.org ([198.145.29.99]:57186 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731189AbhAKNK3 (ORCPT ); Mon, 11 Jan 2021 08:10:29 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id E7E1621534; Mon, 11 Jan 2021 13:10:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1610370613; bh=M8TOvm/1aI6Vfwo95DF783lJLCnR4hOJfYcFuxNG9Ow=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=xVa2B2aygcEKBS11EkjurYVKvnSuP/sQow0HucNPEgZ1LA7ND5dXLDmocSkZD30HI R9w0D428pvI/nOF3v4GYWDlODImaPjp5uIZ6sN7VHe2G55e9oob8AjycXiLTFuuooW 3POjGT9rWZmccuDL2lI/ljoZmZprSaF9Kd+4E/qI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Manish Chopra , Sudarsana Kalluru , Igor Russkikh , Jakub Kicinski Subject: [PATCH 5.4 21/92] qede: fix offload for IPIP tunnel packets Date: Mon, 11 Jan 2021 14:01:25 +0100 Message-Id: <20210111130040.167867195@linuxfoundation.org> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210111130039.165470698@linuxfoundation.org> References: <20210111130039.165470698@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Manish Chopra [ Upstream commit 5d5647dad259bb416fd5d3d87012760386d97530 ] IPIP tunnels packets are unknown to device, hence these packets are incorrectly parsed and caused the packet corruption, so disable offlods for such packets at run time. Signed-off-by: Manish Chopra Signed-off-by: Sudarsana Kalluru Signed-off-by: Igor Russkikh Link: https://lore.kernel.org/r/20201221145530.7771-1-manishc@marvell.com Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/qlogic/qede/qede_fp.c | 5 +++++ 1 file changed, 5 insertions(+) --- a/drivers/net/ethernet/qlogic/qede/qede_fp.c +++ b/drivers/net/ethernet/qlogic/qede/qede_fp.c @@ -1737,6 +1737,11 @@ netdev_features_t qede_features_check(st ntohs(udp_hdr(skb)->dest) != gnv_port)) return features & ~(NETIF_F_CSUM_MASK | NETIF_F_GSO_MASK); + } else if (l4_proto == IPPROTO_IPIP) { + /* IPIP tunnels are unknown to the device or at least unsupported natively, + * offloads for them can't be done trivially, so disable them for such skb. + */ + return features & ~(NETIF_F_CSUM_MASK | NETIF_F_GSO_MASK); } }