Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp2280191pxb; Mon, 11 Jan 2021 05:57:57 -0800 (PST) X-Google-Smtp-Source: ABdhPJyHSJ5zx+IF3MZ4nL77ddEqX4Q1GmfUn/YlUo/ponf7dVUy1wuUPyvhBtKM/o+FkyiYMv// X-Received: by 2002:aa7:d915:: with SMTP id a21mr14030542edr.251.1610373476751; Mon, 11 Jan 2021 05:57:56 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610373476; cv=none; d=google.com; s=arc-20160816; b=YbdQsl3COqYGUO09KPpHvaAxd3f5Sr/gDjfJ+m60ohBojLM7xPDAMSLfCCsSJYMuLU fijBLA7NU/GfxdmmLzeNx5rdjfZnLOYHtvE9KIdWlCSrJO9ptKvlA92hE2ignSxrz22H QP74dCN+ZLjehscEL9Q/foJlbJX3ZvJJmBZpJSg7SrQnwAiMLzeR3QDi138nHpz1tt19 Drfm/wJLhj42xkcLJLAw24qfEZffvxhJYonr7RiUrDxFt6nuSfNh1SC3UysQ49tvuFNY Be9G3fO/J1fDDkKSKWQ3Lu2HEeJpaPAHHnmg7beO46S3WZXokwjXmwvZst9B9rmrpRZc 2f/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=oJ4+MRli6WGaZqdOZrV7CB1LOSjzZ2noXgtp2KzLwsg=; b=Hkv/RGqtGJT+x6wxYQq5hy7AXky+LqHHJoCR+TX3VlADgbXBi42Ld2vhawz2ndKHBd eYxgYdccDVIOfL/elspRtr142iOWLwduJCEAomrkNSMjL8w3prfCFXngApetBIClHt75 m9X/Tx57yqoGiE2518PInuDDUqhZTweUQ6C7bTjmMrH+EOBk5wErMY4Jjld0+dVuIhrj E1pDiArd4SqOPRoWh6oegFeAMxn69nHFzRszTkmOVsko7xU1rk0vo9KN0r9bviXLiuO1 9X+pjW/gQKg1STvPCbE3H5lqiEQwg72NH7aJp55H0haGcbmcGCZ0qPS3jF8DSE+P8Xgl gDqQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="AyqD/E4k"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z5si6844897ejj.549.2021.01.11.05.57.31; Mon, 11 Jan 2021 05:57:56 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b="AyqD/E4k"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387907AbhAKNyu (ORCPT + 99 others); Mon, 11 Jan 2021 08:54:50 -0500 Received: from mail.kernel.org ([198.145.29.99]:55224 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730634AbhAKNHt (ORCPT ); Mon, 11 Jan 2021 08:07:49 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 398502253A; Mon, 11 Jan 2021 13:07:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1610370428; bh=0nvH+jL7IPRAQexABc65SOaLnD05z7GjQ7REcua2YbQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AyqD/E4kPr2Szju82Gb7qMWZYu0RfbA2zAkFk1QMP62uHafv3W6PSVUDIcNlax5yn nfFpNBMW0TlW19CQDswCkjfmOal2Jgf/oIty7+SkH1WlchrjgKU3DBN5fH7SDTwS2L b0drqqiv5Tzn7sKu1mDpX4S2Jr4Dubhb4zZ1YwWA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Manish Chopra , Sudarsana Kalluru , Igor Russkikh , Jakub Kicinski Subject: [PATCH 4.19 18/77] qede: fix offload for IPIP tunnel packets Date: Mon, 11 Jan 2021 14:01:27 +0100 Message-Id: <20210111130037.293635778@linuxfoundation.org> X-Mailer: git-send-email 2.30.0 In-Reply-To: <20210111130036.414620026@linuxfoundation.org> References: <20210111130036.414620026@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Manish Chopra [ Upstream commit 5d5647dad259bb416fd5d3d87012760386d97530 ] IPIP tunnels packets are unknown to device, hence these packets are incorrectly parsed and caused the packet corruption, so disable offlods for such packets at run time. Signed-off-by: Manish Chopra Signed-off-by: Sudarsana Kalluru Signed-off-by: Igor Russkikh Link: https://lore.kernel.org/r/20201221145530.7771-1-manishc@marvell.com Signed-off-by: Jakub Kicinski Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/qlogic/qede/qede_fp.c | 5 +++++ 1 file changed, 5 insertions(+) --- a/drivers/net/ethernet/qlogic/qede/qede_fp.c +++ b/drivers/net/ethernet/qlogic/qede/qede_fp.c @@ -1747,6 +1747,11 @@ netdev_features_t qede_features_check(st ntohs(udp_hdr(skb)->dest) != gnv_port)) return features & ~(NETIF_F_CSUM_MASK | NETIF_F_GSO_MASK); + } else if (l4_proto == IPPROTO_IPIP) { + /* IPIP tunnels are unknown to the device or at least unsupported natively, + * offloads for them can't be done trivially, so disable them for such skb. + */ + return features & ~(NETIF_F_CSUM_MASK | NETIF_F_GSO_MASK); } }