Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp2298290pxb; Mon, 11 Jan 2021 06:20:53 -0800 (PST) X-Google-Smtp-Source: ABdhPJyawbF5EZl87H2oG7OfdkteiogorT00lWYGF3IuzTcVAouzjE/fpQ1c1SMGbveDKdaukmpj X-Received: by 2002:a17:906:d8a1:: with SMTP id qc1mr10869229ejb.294.1610374853359; Mon, 11 Jan 2021 06:20:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610374853; cv=none; d=google.com; s=arc-20160816; b=mocAl5LYq2KhcZQ4oDLIEd223xYzAP/MZkuMMSXWZt9zjt8SbrPfcAWLk1vP6eWs8V bqq98aTGnVkhb29LCJ49ER29Q7ukRsmIWM1LlC4gr6F67fTgX/W/UobD8LNPQeWiVEkj khG19hJNaHAAbULBjrc1R2qVLmKo9zUDciSamGf/GpYQpA77xaHSkuvL5onHk+gFPEgm OoaUaO6/Ip9fxWiaJ3YsM6Y3PAydL82SQcWmJkubVfdZwN39t0jfmXLfOdk5LxsYPRyD 6mhkBpRBAWUrr7HH9bpHAZgAwHOsWqQGeLAL0flneescze/qExua54agfWkqJ47andNZ rr7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=VzXAEGCsG1zjU5RIvmK1FPg6zF4lYkZhNyN5dd9A/ac=; b=sY/3TlPz/aEHzDhGi+1vw47HXH7a7z2xpDa6t/BD6RekupYCz9A4dHDvsQqoJk/eXQ 8UTka0pHTFJssshGfujbAjQssfXNzjDDkTdfxtf2hCbm50RjFUn2MYjhHGtv4uJp+YP0 3dDRAd1+ErMp2vl4S1BI7GtAq6+kBa8grb6uKjBd7Yn73jG/nSZIGo9FRo29SDFSKmrn Jt7DZ9qOqPORjjx0Y2YTZQvijiG2wna5nhKjwQPrtKRsa2bM0siaBKTozO57Vk9RhW8b e2twYlPDTkPrsXIGHoZM8OhkvbNxAqoLWEfm9DqXRIOdh4vaTG6ayj1xsz1H00kGEtms tsbQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id u6si7036159edy.204.2021.01.11.06.20.28; Mon, 11 Jan 2021 06:20:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732128AbhAKOR5 (ORCPT + 99 others); Mon, 11 Jan 2021 09:17:57 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:33288 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727304AbhAKOR4 (ORCPT ); Mon, 11 Jan 2021 09:17:56 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kyy0H-00HXVo-Ez; Mon, 11 Jan 2021 15:17:05 +0100 Date: Mon, 11 Jan 2021 15:17:05 +0100 From: Andrew Lunn To: Marco Felsch Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net, kuba@kernel.org, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH] net: phy: smsc: fix clk error handling Message-ID: References: <20210111085932.28680-1-m.felsch@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210111085932.28680-1-m.felsch@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Jan 11, 2021 at 09:59:32AM +0100, Marco Felsch wrote: > Commit bedd8d78aba3 ("net: phy: smsc: LAN8710/20: add phy refclk in > support") added the phy clk support. The commit already checks if > clk_get_optional() throw an error but instead of returning the error it > ignores it. > > Fixes: bedd8d78aba3 ("net: phy: smsc: LAN8710/20: add phy refclk in support") > Suggested-by: Jakub Kicinski > Signed-off-by: Marco Felsch Reviewed-by: Andrew Lunn Andrew