Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp2325576pxb; Mon, 11 Jan 2021 06:59:04 -0800 (PST) X-Google-Smtp-Source: ABdhPJwsOyRc0FyJ39qR06j9EIT+r43uTqYsMLxJuO3yJT0Ox+OhlgH6ebLTVCm7G2gBdyLloupB X-Received: by 2002:a17:906:a106:: with SMTP id t6mr11270922ejy.63.1610377144350; Mon, 11 Jan 2021 06:59:04 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610377144; cv=none; d=google.com; s=arc-20160816; b=FAeO9VeTyy3n1BB4WMPE5h3m8KvMKRpCwV4Tqbsc4Xg494f/ZH58wXK41IIA/EUN7y Ecwc+UgCTVd5l/IBeGcSx/O2X4BwgLCYiLaNIibOCO6sP85EwZWnS7UajeYKSuef/QCg 21prnONML268EYAHrgKFKG1XX8OeMx9dG4wmcUOAk7bUFSvthehqTcT1Lo45npJvgTXb X85Z8NVTbxyCDQ8v1878scG+WvJLBACXUuG8BbXqdvhdVV8l6a/rbCKqZWRPxuQfet/f sGizrKvz/AZ7xIHVORLnn02JukDKOeMu1U3EDnT96dkTvpdXWPXen47q8n2u+hnjmjLp DQgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=QAsmUUEgKueJfUyE+PDxMx4ue7SmU3mq0cNtqhnnYsE=; b=lDZulZXBKRT4Do29dEGU8ig9b2O59l76Jpz3bIQHnRGlPmILPo92dbhnUAwZS+4ufb v9g04NYZhWGrYSirpyLGliy/NiKBs4uShu71mN0050yhAlG6L9REcpBnbYzsFwnLMj11 QdK3d7JvPWIsvnbamil9hmbwOLCnSzL1aumCqLnekgWChVVZ684xidYK4Cep3S44V39v pJdT+iTV9jT421j8n2aVvj06FqT9LQIW8b7nnQVKoLij9hMUM/cUIzzpIjrnZbqK5Ih3 Feqf0IMPzH8Y28ExQ1keYSl31kRPULmBmXNt5M33IcFL8vL5j+9NGt8HNcHFM2OFNehJ HAPg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=cdKRerAv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id b7si9898edq.548.2021.01.11.06.58.40; Mon, 11 Jan 2021 06:59:04 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=cdKRerAv; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388766AbhAKO4L (ORCPT + 99 others); Mon, 11 Jan 2021 09:56:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730240AbhAKO4J (ORCPT ); Mon, 11 Jan 2021 09:56:09 -0500 Received: from mail-wm1-x330.google.com (mail-wm1-x330.google.com [IPv6:2a00:1450:4864:20::330]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 25170C0617A4 for ; Mon, 11 Jan 2021 06:54:51 -0800 (PST) Received: by mail-wm1-x330.google.com with SMTP id c124so87019wma.5 for ; Mon, 11 Jan 2021 06:54:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=QAsmUUEgKueJfUyE+PDxMx4ue7SmU3mq0cNtqhnnYsE=; b=cdKRerAvU1UPYuCV0vCuEM401EAsTCASkDnjlSRj1WBN57Ay7ruzDTalMK6YAH259i jNHa3Ywloylm9orbp/B59KbWqm+d+JrN+QB3raBMkVmxefG/Pf8KzPBSRKe8aicX/C3i vBLTwd6rdHknL3WZygJWlCDfMvLFEPQEqNZr8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=QAsmUUEgKueJfUyE+PDxMx4ue7SmU3mq0cNtqhnnYsE=; b=o15gDFqNjyxjM9TucoCJ7j+yWIiGykQnyahAu/YPFgH2kfp1glaR6+l3NBs8lanyxH fWY58MyORnNWWNJ2i7aTuB2Kq8f9M2rNR5RC2gQlafhqdeO972igB6ufU1Oc+A2Q1HAf YYlQ+KyIgVtf7QW9p0K+o1effa32j5p6l8gqR62xEzUOUnqqy0woqEP8HDcDJOKr5f7R iUPcM6KvZs8GM8LSHazCUszkmUZ/HXtVju/G3Nk5IGx2BwfS8cTTlQPPrA3tbCQq+YST dMohLkv6yRn6s7WCE2qcgQ24ir/1Vz9WmBksS0pbnxxmWep7NEWAfp/7IJvV8rqdr8qI STPQ== X-Gm-Message-State: AOAM531yml1IGGlufLpBVK8CWvPICu/zzzof/F6H+qybmh2e3s4P78jZ 2DmAJ2DV2EZTAH0wjwejt2f+uKZ7QBWRlCXyIyQ= X-Received: by 2002:a1c:6208:: with SMTP id w8mr103281wmb.96.1610376889935; Mon, 11 Jan 2021 06:54:49 -0800 (PST) Received: from alco.lan ([80.71.134.83]) by smtp.gmail.com with ESMTPSA id s133sm17780wmf.38.2021.01.11.06.54.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jan 2021 06:54:49 -0800 (PST) From: Ricardo Ribalda To: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ricardo Ribalda , Matthias Brugger Subject: [PATCH 3/9] media: mtk-vcodec: Do not zero reserved fields Date: Mon, 11 Jan 2021 15:54:39 +0100 Message-Id: <20210111145445.28854-4-ribalda@chromium.org> X-Mailer: git-send-email 2.30.0.284.gd98b1dd5eaa7-goog In-Reply-To: <20210111145445.28854-1-ribalda@chromium.org> References: <20210111145445.28854-1-ribalda@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Core code already clears reserved fields of struct v4l2_pix_format_mplane, check: 4e1e0eb0e074 ("media: v4l2-ioctl: Zero v4l2_plane_pix_format reserved fields"). Cc: Matthias Brugger Signed-off-by: Ricardo Ribalda --- drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c | 5 ----- drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c | 8 -------- 2 files changed, 13 deletions(-) diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c index c768a587a944..d746c41ea805 100644 --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_dec.c @@ -715,12 +715,7 @@ static int vidioc_try_fmt(struct v4l2_format *f, } } - for (i = 0; i < pix_fmt_mp->num_planes; i++) - memset(&(pix_fmt_mp->plane_fmt[i].reserved[0]), 0x0, - sizeof(pix_fmt_mp->plane_fmt[0].reserved)); - pix_fmt_mp->flags = 0; - memset(&pix_fmt_mp->reserved, 0x0, sizeof(pix_fmt_mp->reserved)); return 0; } diff --git a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c index 21de1431cfcb..db1f62cc38b3 100644 --- a/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c +++ b/drivers/media/platform/mtk-vcodec/mtk_vcodec_enc.c @@ -320,13 +320,7 @@ static int vidioc_try_fmt(struct v4l2_format *f, } } - for (i = 0; i < pix_fmt_mp->num_planes; i++) - memset(&(pix_fmt_mp->plane_fmt[i].reserved[0]), 0x0, - sizeof(pix_fmt_mp->plane_fmt[0].reserved)); - pix_fmt_mp->flags = 0; - memset(&pix_fmt_mp->reserved, 0x0, - sizeof(pix_fmt_mp->reserved)); return 0; } @@ -532,8 +526,6 @@ static int vidioc_venc_g_fmt(struct file *file, void *priv, for (i = 0; i < pix->num_planes; i++) { pix->plane_fmt[i].bytesperline = q_data->bytesperline[i]; pix->plane_fmt[i].sizeimage = q_data->sizeimage[i]; - memset(&(pix->plane_fmt[i].reserved[0]), 0x0, - sizeof(pix->plane_fmt[i].reserved)); } pix->flags = 0; -- 2.30.0.284.gd98b1dd5eaa7-goog