Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp2325621pxb; Mon, 11 Jan 2021 06:59:09 -0800 (PST) X-Google-Smtp-Source: ABdhPJz7+8lT8wDBvHCAsbXTz+EyGxFiH1GhAgIHS/8fZqT5x3pm60vc6CLKO7THeIvTKFPazezN X-Received: by 2002:a17:906:6606:: with SMTP id b6mr10729718ejp.151.1610377148867; Mon, 11 Jan 2021 06:59:08 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610377148; cv=none; d=google.com; s=arc-20160816; b=W8+6Alv3Qz8M+dIgZuhusSM5MW94EeOTGvl9QthrwdMnt4DQlWxfTqLVjCh21zzna3 RCbvJsFo47gMkrzsJcEyY4RXKGjE+dYVLahIxJUWceJofsV3Inh6H/Yxbq15ugQhno++ 6FCGlGkjhjvot2+6wTemY7g8509gJz6PiUpnMfiynfuBp9sZrx/+6fVbSFe1wPYEp4La gDFzzUxlAqenCl53+ZutNxrRykNAfKx4aG5x7WOq8filSs1FntEZCCDGXs1r7fgm976R CcraPkojXxq9CZ+tFSAppptalWgaTXQq/9hmf6zS/INmtSWP3YiD6NU9YAE9ZohPZ3U+ wxgg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=9se+I1bVzSGFCzzbJS6Ist8AUI7EMxjL64J/1ddQygI=; b=iglUdQQmWlugio0Mj7NuH8px/njlaTbdIc0C7x8JLNd1lMJXLe+5Be9qGFxJ1zcIsU 0EZ+WqVph7UATurO+C8cwo01DGuDYaLdsB70EN2881aBYyMfTE/68KrI+ImRzBGF5WS8 mkt/jFOyv6myVVdXXhIJIEmG3j7xfkVK8yx3z9tADIFDuNXM8tq2aYC24jx3La/SckfP mJKcQkMB6x7qYWNArikImkwcaIbseZM9/mQqFbxe+bKgTpefFWBmLDAkLzEufX2L2lHY ae/UHQpVnvIM3Ej7p3g4WFTTy7E7yZBwgyBeT5yC+mUoAMEftqK8kmpZ6XMsSgOG7dWf ZQ9w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=YLFfNfVR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z7si12614edm.477.2021.01.11.06.58.43; Mon, 11 Jan 2021 06:59:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=YLFfNfVR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388924AbhAKO4Z (ORCPT + 99 others); Mon, 11 Jan 2021 09:56:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732579AbhAKO4Y (ORCPT ); Mon, 11 Jan 2021 09:56:24 -0500 Received: from mail-wr1-x42f.google.com (mail-wr1-x42f.google.com [IPv6:2a00:1450:4864:20::42f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B5EA1C0617BB for ; Mon, 11 Jan 2021 06:54:55 -0800 (PST) Received: by mail-wr1-x42f.google.com with SMTP id i9so77095wrc.4 for ; Mon, 11 Jan 2021 06:54:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9se+I1bVzSGFCzzbJS6Ist8AUI7EMxjL64J/1ddQygI=; b=YLFfNfVRAiYcTgmFLqoE4Z2bi6XlMhIBpMNAqdYu6XuTMrxs+zUeA8yu6QvFDvbq5Q HgpRpM2dzP6LmN51VRglBL02zKxlk4aug1qomnCucJPSx55JtKLWPUcJwrU2QjM19azG RNv5F+ZXqB7Ibf1DM1HnRBmhP4cFr+vLxR2kg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9se+I1bVzSGFCzzbJS6Ist8AUI7EMxjL64J/1ddQygI=; b=qjzKZxsThaKeBID1PKkWqrOmfXCgmIrQ0AVeOhvfYWDN0fhzzRD3W3GAQj4OHVlATQ YswWTKHN/29niNi09RVzJf3luDLCJ2XQnUmRE/xnOafY4IMufhMcZ6+1X7SLcVl0vEO7 6zBgLLfUK6LEKeYrDMP1376Qu89s6nbVWfD6B7coBn+sh8CWQKK1FJPsGJbO0XaByZST OkpyVSL8F/q01QUSopHhKzFKRqqHqlocjsCjr83r7rXPwdb6g5kL9PuAMQgPGuKdJ+Bz g4PuKAfydHSX0Sxwnq/cQHDHHXdGG49JRm4TUf20TokZ/V6R9dDiSDwTO0gdodW1pGco fKlg== X-Gm-Message-State: AOAM532076Mgb/s1xDn5dD1aWehr/bR00Z/JTw1t5b+LF8WYckbHXjGK kJqYBvDZ2wW5SCJVaQucHjSxjw== X-Received: by 2002:a05:6000:1d1:: with SMTP id t17mr17198876wrx.164.1610376894533; Mon, 11 Jan 2021 06:54:54 -0800 (PST) Received: from alco.lan ([80.71.134.83]) by smtp.gmail.com with ESMTPSA id s133sm17780wmf.38.2021.01.11.06.54.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Jan 2021 06:54:53 -0800 (PST) From: Ricardo Ribalda To: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Ricardo Ribalda , Hans Verkuil Subject: [PATCH 8/9] media: vicodec: Do not zero reserved fields Date: Mon, 11 Jan 2021 15:54:44 +0100 Message-Id: <20210111145445.28854-9-ribalda@chromium.org> X-Mailer: git-send-email 2.30.0.284.gd98b1dd5eaa7-goog In-Reply-To: <20210111145445.28854-1-ribalda@chromium.org> References: <20210111145445.28854-1-ribalda@chromium.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Core code already clears reserved fields of struct v4l2_pix_format_mplane, check: 4e1e0eb0e074 ("media: v4l2-ioctl: Zero v4l2_plane_pix_format reserved fields"). Cc: Hans Verkuil Signed-off-by: Ricardo Ribalda --- drivers/media/test-drivers/vicodec/vicodec-core.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/media/test-drivers/vicodec/vicodec-core.c b/drivers/media/test-drivers/vicodec/vicodec-core.c index 025f3ff77302..33f1c893c1b6 100644 --- a/drivers/media/test-drivers/vicodec/vicodec-core.c +++ b/drivers/media/test-drivers/vicodec/vicodec-core.c @@ -811,9 +811,6 @@ static int vidioc_g_fmt(struct vicodec_ctx *ctx, struct v4l2_format *f) pix_mp->xfer_func = ctx->state.xfer_func; pix_mp->ycbcr_enc = ctx->state.ycbcr_enc; pix_mp->quantization = ctx->state.quantization; - memset(pix_mp->reserved, 0, sizeof(pix_mp->reserved)); - memset(pix_mp->plane_fmt[0].reserved, 0, - sizeof(pix_mp->plane_fmt[0].reserved)); break; default: return -EINVAL; @@ -886,8 +883,6 @@ static int vidioc_try_fmt(struct vicodec_ctx *ctx, struct v4l2_format *f) info->sizeimage_mult / info->sizeimage_div; if (pix_mp->pixelformat == V4L2_PIX_FMT_FWHT) plane->sizeimage += sizeof(struct fwht_cframe_hdr); - memset(pix_mp->reserved, 0, sizeof(pix_mp->reserved)); - memset(plane->reserved, 0, sizeof(plane->reserved)); break; default: return -EINVAL; -- 2.30.0.284.gd98b1dd5eaa7-goog