Received: by 2002:a05:6a10:2785:0:0:0:0 with SMTP id ia5csp2397429pxb; Mon, 11 Jan 2021 08:39:18 -0800 (PST) X-Google-Smtp-Source: ABdhPJyeEQ7gbpjAj9Fw068+ZX4P3NOdpn11ra9J0LufIzsPaGp33FgushsTcW2L/KcYfpUH0HG1 X-Received: by 2002:a17:906:cd06:: with SMTP id oz6mr222093ejb.25.1610383157741; Mon, 11 Jan 2021 08:39:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1610383157; cv=none; d=google.com; s=arc-20160816; b=tusPXZYfaC0qL0zApsyqBImDOJRvRJ/B1Jim+reXgFdCaPwgJPi+rI7H+npJeukni2 i3CijL3uNm9glO+/7gsGpfa7xTRveFm636MPlUTK9uKteP97IBPMfdnxFL+0b7rmTTkd FmbaWmutDAVBFwRK18r7X7o0kbT9pkYfnK6yOv/ANlyPXkbipsDHlFO9zC5sGA8Yw4rs ma5p1NaIhAIdYSWQNZCrtyRuGW374PmaBsBKcJ8pB5qXe+iX/zHIXpkb6SAzLRgFAkMy frwc0Il3mDBenhODiTYuEErFV6g7/3plMd4B0L48AbLekWZlOzV8vrND0QAJyh0jXe1c ss4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=s1KTXlwp8MgqklrnUJdGKCevVdUlwPda3x7X4dCY/bA=; b=xOb14i8uKONUtXa/XRLQNAteqqtaqW/CSJDrdG86g9j/ZKJNcXoMF6sWdjwhHoveeW EV+Lr6C6w+RoiJhRhG8pPEBG+V1l4HaNqWBLyRFv3NQNqYNCBZk8J5D9mnOpP67opWzi xUmkQ0Za/yB3++AEFooFMcJgbEDqjILBk2wK96wQrF2JM4TifWQgOnU2p5F0+AIpZxGs R/BIMggKZD0J6uYiYY3i6A/AsSjdefu8fy4WFlgjLuI3kWKEtc82y7BZ3hV7gt41Qx+Z WAdNjapna9k6krqa0lep4fp4OWNHKlfrBY3U14YqHn7hWzy2Pj1L1ja5diL0SH1rlLlP zjCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cBk+zJJG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id jo16si6915548ejb.86.2021.01.11.08.38.52; Mon, 11 Jan 2021 08:39:17 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=cBk+zJJG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732237AbhAKQgR (ORCPT + 99 others); Mon, 11 Jan 2021 11:36:17 -0500 Received: from mail.kernel.org ([198.145.29.99]:42600 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728591AbhAKQgR (ORCPT ); Mon, 11 Jan 2021 11:36:17 -0500 Received: by mail.kernel.org (Postfix) with ESMTPSA id 74E41221FE; Mon, 11 Jan 2021 16:35:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1610382936; bh=RE1Md8cmppu1xKF0msv57vimbUhlP4+7Lx/7ygdMAPs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cBk+zJJGnYddOl/czcVfF2W4yAH8sy1jqATOCC+tCVJkOywQ7sdsMXZVwnwYbcBdZ kR/su628sjS3ApqkD1RtF0xSpksd67XwENPgHCeE6XF7cB/IAhpeUGE+H9sNqBR9oH tLgiGSW/OreqsjsafiCgguIaiHPDH+LAIjnjE5HxnwzP25oGf1SQyu9CgiiACIlKc5 rHWXhXdBrgpRXbmEnGaNDj0Qtof1RJVWfxLWArysRtc2Z1dI2OYX6Wuvj4YF6L8YPp QhAwoMEwW/EmmUF13zHi99e8R9ofvHT0iNnCZIT3p2Qft4SFkwGK3fFTi7NBqwnqL5 aWM53dmIa2gTg== Date: Mon, 11 Jan 2021 16:35:04 +0000 From: Mark Brown To: Vinod Koul Cc: Bjorn Andersson , Wolfram Sang , linux-arm-msm@vger.kernel.org, Andy Gross , Matthias Kaehlcke , Douglas Anderson , Sumit Semwal , Amit Pundir , linux-spi@vger.kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/7] spi: spi-geni-qcom: Add support for GPI dma Message-ID: <20210111163504.GD4728@sirena.org.uk> References: <20210111151651.1616813-1-vkoul@kernel.org> <20210111151651.1616813-5-vkoul@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="pQhZXvAqiZgbeUkD" Content-Disposition: inline In-Reply-To: <20210111151651.1616813-5-vkoul@kernel.org> X-Cookie: Too much is not enough. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --pQhZXvAqiZgbeUkD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Mon, Jan 11, 2021 at 08:46:48PM +0530, Vinod Koul wrote: > +static int get_xfer_mode(struct spi_master *spi) > +{ > + struct spi_geni_master *mas = spi_master_get_devdata(spi); > + struct geni_se *se = &mas->se; > + int mode = GENI_SE_FIFO; Why not use the core DMA mapping support? --pQhZXvAqiZgbeUkD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl/8fjcACgkQJNaLcl1U h9Dg7wf6AiVIGMV8fdSxV/+rvHOKoT4lSj+DxPZgO4ziYL6vqk7upbg1Qm7+ipoi EDQ68FPLAKZky09U0ZK3AP/kMn4hAAezlBysnKqYyNGF6fTbzszOP/WZICjFcWG8 w4ebN0qPW8o1UoC7CUDDdD0GxlFS+rugmEogvdsrhtNiOSodkhn8ibqL5QVYIzYZ ndVwlAAgW3+WuDNd/vV4nTT8HvKp7a0ZJeoOygXCpX70uzD1Lztd6mA/v0aWIeub xv5mZJb54rUmooaudUoRI14Zs2xhU4iyo+Zj/SQpDAa5uwdkRT4NxV1zWyvR1Lup Ro3frvVVNALn6RtdXWhw1oo3GVtJXg== =SIUq -----END PGP SIGNATURE----- --pQhZXvAqiZgbeUkD--