Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] spi: spi-bcm-qspi: style: Simplify bool comparison
To:     Mark Brown <broonie@kernel.org>,
        YANG LI <abaci-bugfix@linux.alibaba.com>, kdasu.kdev@gmail.com
Cc:     bcm-kernel-feedback-list@broadcom.com,
        linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org
References: <1610357189-60031-1-git-send-email-abaci-bugfix@linux.alibaba.com>
 <161038255869.32886.11006261963964555197.b4-ty@kernel.org>
From:   Florian Fainelli <f.fainelli@gmail.com>
Message-ID: <ec735a59-0fbd-3d4a-e997-895099a8e534@gmail.com>
Date:   Mon, 11 Jan 2021 08:41:19 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Firefox/78.0 Thunderbird/78.6.0
MIME-Version: 1.0
In-Reply-To: <161038255869.32886.11006261963964555197.b4-ty@kernel.org>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 1/11/2021 8:29 AM, Mark Brown wrote:
> On Mon, 11 Jan 2021 17:26:29 +0800, YANG LI wrote:
>> Fix the following coccicheck warning:
>> ./drivers/spi/spi-bcm-qspi.c:884:5-34: WARNING: Comparison to bool
> 
> Applied to
> 
>    https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
> 
> Thanks!
> 
> [1/1] spi: spi-bcm-qspi: style: Simplify bool comparison
>       commit: 6650ab2a44268af8d24995d28ae199b57b2ebff8

I don't think that "style: " is a subject prefix that is used commonly
and it certainly should not belong in a commit subject. Mark can you
please people at least 10-12 hours to review changes before applying
them? This one is trivial except the commit subject does not match
previous changes done to this file and it should have been fixed.
-- 
Florian