Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 11 Jan 2021 17:05:56 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Florian Fainelli <f.fainelli@gmail.com>
Cc:     YANG LI <abaci-bugfix@linux.alibaba.com>, kdasu.kdev@gmail.com,
        bcm-kernel-feedback-list@broadcom.com,
        linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org
Subject: Re: [PATCH] spi: spi-bcm-qspi: style: Simplify bool comparison
Message-ID: <20210111170556.GF4728@sirena.org.uk>
References: <1610357189-60031-1-git-send-email-abaci-bugfix@linux.alibaba.com>
 <161038255869.32886.11006261963964555197.b4-ty@kernel.org>
 <ec735a59-0fbd-3d4a-e997-895099a8e534@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="cz6wLo+OExbGG7q/"
Content-Disposition: inline
In-Reply-To: <ec735a59-0fbd-3d4a-e997-895099a8e534@gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--cz6wLo+OExbGG7q/
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Jan 11, 2021 at 08:41:19AM -0800, Florian Fainelli wrote:

> > [1/1] spi: spi-bcm-qspi: style: Simplify bool comparison
> >       commit: 6650ab2a44268af8d24995d28ae199b57b2ebff8

> I don't think that "style: " is a subject prefix that is used commonly
> and it certainly should not belong in a commit subject. Mark can you
> please people at least 10-12 hours to review changes before applying
> them? This one is trivial except the commit subject does not match
> previous changes done to this file and it should have been fixed.

Honestly for super trivial stuff like this I'm not sure it's a useful
use of anyone's time to police this sort of stuff aggressively, it's
after the prefixes that matter so I saw it easily and I'm having a hard
time caring that it happens to be done as a prefix rather than saying
style somewhere else in the subject.

I will generally hold off for longer with these trivial patches on
things where I expect to see some review but that's felt a bit patchy
with the Broadcom drivers.

--cz6wLo+OExbGG7q/
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl/8hXMACgkQJNaLcl1U
h9Dwgwf/YCFcxryTJnVKlTEM26muvYJidZX7j5hFAFMsUOcnTH8Y/TCcHxBx5d6a
NiC7G8gPDrsw8yByKD5NUuDkLWc7fbvjJUQTZ4LxIM+zoT7tC10L1DQAJzoYrDHI
d/5vr5rrHjJERjB0X4BvV9sNyfrbFtbCXZBl6m3bTD4p++rTpLHhzqR6c/GkpP2a
nM7u61sfQCKvp4yLxA1Q389Weiy3z20hs/vbBbWTml3ppjEqUbQlvPkaLpYRjv/L
EzOfirWtHoF286LL3KMH4d4doqSOnf/otbenLl4Bp8ahVc2bOtyklnJwJ6P1iFvm
XopmzF+1B8YnMvt0btDIgydsQaP21w==
=IhKH
-----END PGP SIGNATURE-----

--cz6wLo+OExbGG7q/--